mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <balbi@kernel.org>
Cc: <vivek.gautam@codeaurora.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device
Date: Mon, 3 Apr 2017 15:20:29 +0300	[thread overview]
Message-ID: <1491222031-18120-2-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1491222031-18120-1-git-send-email-rogerq@ti.com>

allow usb_del_gadget_udc() and usb add_gadget_udc() to be called
repeatedly on the same gadget->dev structure.

We need to clear the gadget->dev structure so that kobject_init()
doesn't complain about already initialized object.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/usb/gadget/udc/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index d685d82..efce68e 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -1273,6 +1273,7 @@ void usb_del_gadget_udc(struct usb_gadget *gadget)
 	flush_work(&gadget->work);
 	device_unregister(&udc->dev);
 	device_unregister(&gadget->dev);
+	memset(&gadget->dev, 0x00, sizeof(gadget->dev));
 }
 EXPORT_SYMBOL_GPL(usb_del_gadget_udc);
 
-- 
2.7.4

  reply	other threads:[~2017-04-03 12:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 12:20 [PATCH v3 0/3] usb: dwc3: dual-role support Roger Quadros
2017-04-03 12:20 ` Roger Quadros [this message]
2017-04-03 14:19   ` [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device Alan Stern
2017-04-04  7:47     ` Felipe Balbi
2017-04-04 14:17       ` Alan Stern
2017-04-05  8:34         ` Felipe Balbi
2017-04-05 14:12           ` Alan Stern
2017-04-10 10:05             ` Felipe Balbi
2017-04-10 15:17               ` Alan Stern
2017-04-11  7:34                 ` Felipe Balbi
2017-04-11 14:12                   ` Alan Stern
2017-04-11 14:19                     ` Greg KH
2017-04-12  6:01                       ` Felipe Balbi
2017-04-12  6:45                         ` Greg KH
2017-04-12  7:33                           ` Felipe Balbi
2017-04-12 14:30                         ` Alan Stern
2017-04-03 12:20 ` [PATCH v3 2/3] usb: dwc3: make role-switching work with debugfs/mode Roger Quadros
2017-04-03 12:20 ` [PATCH v3 3/3] usb: dwc3: Add dual-role support Roger Quadros
2017-04-03 19:21   ` kbuild test robot
2017-04-04  7:42     ` Roger Quadros
2017-04-04  7:46   ` [PATCH v4 " Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491222031-18120-2-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®