From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933553AbdDGMGk (ORCPT ); Fri, 7 Apr 2017 08:06:40 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:47094 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933242AbdDGMG3 (ORCPT ); Fri, 7 Apr 2017 08:06:29 -0400 X-AuditID: b6c32a59-f79166d0000017ce-83-58e780c2f825 Subject: Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs From: Smitha T Murthy To: Sylwester Nawrocki Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com In-reply-to: Date: Fri, 07 Apr 2017 17:38:09 +0530 Message-id: <1491566889.15698.1239.camel@smitha-fedora> MIME-version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsWy7bCmlu6hhucRBve7xS1urTvHanFk7VUm i5kn2lktzp/fwG5xtukNu8Wmx9dYLS7vmsNm0bNhK6vF2iN32S2WbfrDZLFo6xd2i8Nv2lkd eDw2repk89i8pN6jb8sqRo/Pm+Q8rhxpZA9gjeKySUnNySxLLdK3S+DK2HH2FVvBI86Kvpnr mBsYL7J3MXJySAiYSOz6sxTKFpO4cG89WxcjF4eQwFJGie63K1khnE+MEnPmHmKGc7a9f8rS xcgB1n7orzhEfCejxI5N15kgnLeMErtfzWcDmSss4C1xoOEUE4jNJqAj8e39abC4iIC+xJJV F8H2MQvMZpI4veQQWBGngL3E9WeLWEBsFgFViS+fdzKD2LwC5kA1HxhBNvMKCEr83SEMcbe2 xLqGM2DlzALyEtvfzgG7VELgP5tE8543UM+5SDzY+YcZwhaWeHV8C1RcSuJlfxs7REMzo8Tc bc0sEIkJjBIrW0shbHuJA1fmgL3MLKApsX6XPkTYVmLN0cvskJDgk7jxVhDiBj6J3t9PmCBK lCQWnTkBVcIr0dEmBBH2kHhw7yLrBEalWQjPzELywCyEVQsYmVcxiqUWFOempxabFpjqFSfm Fpfmpesl5+duYgSnJa3IHYxXZgYdYhTgYFTi4U3Y9SxCiDWxrLgy9xCjBAezkgjv0drnEUK8 KYmVValF+fFFpTmpxYcYpTlYlMR5NVZeixASSE8sSc1OTS1ILYLJMnFwSjUwsrV33118T2xe /KbPuld3+N6M+8Fp391/ppNPev25G+E5c07+afc6L3NtafWhuzvfqN22WCe+aaeoI1PM8/M/ pt88bmztLHK5qqV4nVzFc/1sb9HWvP+umitXhGgsv5E/vaTK54Xc2VN6V5TVZBnCHsTeep5y pdA/v/Uq+5MXlou8myYw6pzYpMRSnJFoqMVcVJwIAE7LFeBHAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42LZdlhJXrem4XmEwcwnVha31p1jtTiy9iqT xcwT7awW589vYLc42/SG3WLT42usFpd3zWGz6NmwldVi7ZG77BbLNv1hsli09Qu7xeE37awO PB6bVnWyeWxeUu/Rt2UVo8fnTXIeV440sgewRnHZpKTmZJalFunbJXBl7Dj7iq3gEWdF38x1 zA2MF9m7GDk4JARMJA79Fe9i5AQyxSQu3FvP1sXIxSEksJ1RYva33+wQCRWJyU/us0HYwhIr /z0HiwsJvGaUONGbC2ILC3hLHGg4xQRiswnoSHx7fxqsXkRAX2LJqotgQ5kFpjFJ7Nu0nhkk wSlgL3H92SIWiG0fmSTen/3JCJJgFtCUaN0OsZlFQFXiy+edYA28AuYSp5d8YAS5mldAUOLv DmGIg7Ql1jWcYYFolZfY/nYO8wRGoVlIJs1C6JiFpGoBI/MqRtHUguLc9NziAiO94sTc4tK8 dL3k/NxNjOAY0krawbhpRvghRgEORiUe3glPnkUIsSaWFVfmHmKU4GBWEuE9Wvs8Qog3JbGy KrUoP76oNCe1+BCjNAeLkjjv9uoNEUIC6YklqdmpqQWpRTBZJg5OqQZGnlUTe4/t/XR7vXyj Bu+Ch5tvqs2KWRHVv+KkuUeF+EOZ33v5fl3p2STwM7myb79g+f7yLLmtu/gnb/g0c1qanswX DeEVBdfZJzbV+uYbNi4u5z6o7L/Tf2eYqZbExJLOrEq/DRn9ajc5lhjpTv1z+M5Ru5X/zz2/ ndZevfvgz5N/jhrz1r1hVmIpzkg01GIuKk4EAMJxuSmdAgAA X-CMS-MailID: 20170407120625epcas5p1e3e21d9b96609474562e22e749de1623 X-Msg-Generator: CA X-Sender-IP: 182.195.40.13 X-Local-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG+yCvOyEseyghOyekBtMZWFkIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZCBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= Content-type: text/plain; charset=utf-8 X-MTR: 20170407120625epcas5p1e3e21d9b96609474562e22e749de1623 X-EPHeader: CA CMS-TYPE: 105P X-Auth-Email: smitha.t@samsung.com X-HopCount: 7 X-CMS-RootMailID: 20170406061027epcas5p2628e0a8e0fd76e2e267fad3ea1209f65 X-RootMTR: 20170406061027epcas5p2628e0a8e0fd76e2e267fad3ea1209f65 References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-13-git-send-email-smitha.t@samsung.com> <1491559409.15698.1237.camel@smitha-fedora> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-07 at 12:26 +0200, Sylwester Nawrocki wrote: > On 04/07/2017 12:03 PM, Smitha T Murthy wrote: > >>> +``V4L2_CID_MPEG_VIDEO_HEVC_LF`` > >>> + Indicates loop filtering. Control ID 0 indicates loop filtering > >>> + is enabled and when set to 1 indicates no filter. > >> > >> "Setting this control to 0 enables loop filtering, setting this control > >> to 1 disables loop filtering." ? > >> > >> Couldn't the meaning be inverted, so setting the control to 0 disables > >> the loop filtering? > >> > >>From register point of view, this control value needs be 0 to enable > > loop filtering. > > OK, this is true for our specific hardware/firmware implementation. > > In general, for this user space interface I would rather define that > boolean control so value 1 enables LF and value 0 disables LF. > The driver could simply negate the value when writing registers. > > BTW we might need to specify type of the control here as Hans suggested > commenting on other control. > > -- > Regards, > Sylwester > Ok I will change the implementation from the driver for this control. Yes in the next version I will add the type of the control for all. Thank you for the review. Regards, Smitha