From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbdDNOdx (ORCPT ); Fri, 14 Apr 2017 10:33:53 -0400 Received: from mail-by2nam03on0070.outbound.protection.outlook.com ([104.47.42.70]:24384 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751896AbdDNOdD (ORCPT ); Fri, 14 Apr 2017 10:33:03 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; From: Dong Aisheng To: CC: , Dong Aisheng Subject: [PATCH v2 2/2] regulator: anatop: make sure regulator name is properly defined Date: Fri, 14 Apr 2017 22:32:43 +0800 Message-ID: <1492180363-2578-1-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492180234-2496-1-git-send-email-aisheng.dong@nxp.com> References: <1492180234-2496-1-git-send-email-aisheng.dong@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131366539818504273;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39850400002)(39840400002)(39450400003)(39380400002)(39400400002)(39410400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(9170700003)(2950100002)(50466002)(305945005)(5660300001)(48376002)(189998001)(2906002)(38730400002)(33646002)(76176999)(86362001)(50986999)(77096006)(85426001)(110136004)(105606002)(106466001)(68736007)(6916009)(54906002)(8936002)(8656002)(50226002)(6666003)(81166006)(4326008)(104016004)(8676002)(5003940100001)(356003)(47776003)(36756003)(53936002)(2351001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR03MB2287;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD042;1:jzR1NHc/LsmuqWiUMCgttWYViD3IeOF74P/pTwO8qlwVar61n/O62dl0MXMW6+hNrP9lRWR+EEWUOnfKZat8mXrheQ04p6SC8Czpuke0lWt+Sv1Oe8VsbKkytho5UMnWRM9YgOX5CcpotbP5qtKdShWauFjgOqK393wUU4rk2eS/iUTg37wi7fQ5Hzs5W7CRF7pyjYBpjQmNA35DW9STa/7BiqzemQBOuXvDVzXj3E7nT6BE/fVQ41Zu/IEOtngixkvRGg++kH3CVb1YJUs0bdAFazlkaX5cb2fExYlSmX1EQ5NTklORo/p+dedIqNETIV5GEn30R3xjNLqpCFRqhm7MO/ngSuN2EdXbfg6CJJGQY//WGu6cA2iv3ggHQnbcyrypg/F/cDNOCzH0pI9d7p15qcx9z5H3UnEbJgmkFhbMq+OiMLjN44As8NH0v5ngOrT0bSCz2RikflNUHblzYOH5+hh/Ns0M6ASepIO5VYn60bmuIHdknvj32wbD7KqU/cEQsiDB2gLCwNlhvKk3wXYn1A/oTA23JUGjPgNMLvmP7xYr8jSzm6O1pt8Q9+dgHsho0hEy+kJMkWHIBB6mBwBo+TZWDf6JbWLBKMvoxmLk8NZjqvfswiCVX679SjmvjRQU7a+RwVXIRsqlAdZ4ldLCqs4BZvpj8/lOrUvugmFHDQcLPlUVKRWD29TwQzaDU/N7TpQu0+l4M14Dgz8zdV6Yg/1zdT0qtPnqr0+2g2c= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 2483b584-c098-41a2-4d8f-08d4834327b3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:SN2PR03MB2287; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2287;3:2CsV6jgsF6PR7by5Kv87wdeXNjfR05jGu0CmWPaoHtJpt+RC8IAZQQFVfik6PWsTQb3wOAYTbN12/xI3UygS8D7rV2Rs5WJPeVMG1Jg/Da90+LjGGANcMR3658ISAAlopysB9E7wfIhEZFO1BSeqfkPYrfjkWCGqGvd9hh7JmMFF7kbgovDSW8VHW/RPsVc0qxuw0J9cDBfDUh658d4pMZc/yJ+Ll6BnysPmvSMXC+oRMeHBLTtfaqs2yekmuc1rhkf1FMQxcE96FOVYeRdYozmsOBjCh9c1sYILfKMVWMujiBz4/vMxCX0BtzvJlD93zK45cTXAmY8sppIC00vpXtK2Z74gvrIC836FC1rVfpSkqEBPX17D94yj5ExucTo2Ww95QY6HrNUdKdiil2fJqZMhYWNEkP7YWNJed1QhXN4PrlEqIW6pJBiLIc40oFcp;25:qN1whWGggLwYicOZJi7Ej0mNdEEA9vHELTls6tiM4PqqjcJHxDVBUg4pBKG3pbg/UCKBfP4Ebe/6sGJa9RvOVKPVmXgw/LCaVHPzDI/vRJssB6zBVUglIxF8HQ6Axk4kXZiz0gzpeZ/HWQb9iM2zjSintsV36GLzygEJUZUsQgZo835LTQefrT7j6xgs+v1DTxorHQ+kukzOknQdS7JZX9OQs8mf9L33F6Q3mpAa3YCoTkwOl7PjvaqNltEE7Ct9CT6bI4zFaRTyxK++eu5IYF0MX9jxPpl9Q7bfjt6fy2H70VtUdwTpY64Ne9iN/lp6JOASwlpRAAfIXiYLkcOO7XB1FpGTVG4XCEOdK78QBVmAXHJHKZy2U53ItJgrpn+mEQLjDAz8zh3Q1vSH/LqutYi+BidAltgh2CgviOn7Xo9e22PaxFinvSpxX38oHAJMTb4NXU8WoC+i9hMkb3o/nQ== X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2287;31:JtwpKrrWg7z5Ssqb0ZZseeETPDgomObnTBjxaqJlgWwqTpxYf4iy0utysvJTKk4+MCUg7ZG/7z/KK85dID/o6pRs+w3gA1E3Ga7Jt4ThNeIl+9/2Jm09WUkRKQE7u6KwJrhiZGrVJf2cPtSlAJWr1VGTcQ8oHzEsSJsaevV2wrRXRaU8u8m2Zm6PelILZu3eCtUmc9bK3Jod0R/ZkWBXjE9csZmsZWv4sX2GZW6Ux5yau5O1G0hiDGcMPr5wiNyq0/URYNoOtzgbS7sg2Ztdvw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259075)(20161123556025)(20161123565025)(20161123563025);SRVR:SN2PR03MB2287;BCL:0;PCL:0;RULEID:(400006);SRVR:SN2PR03MB2287; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2287;4:KJc0k/2jJsvOuFsTzCCS7DZ9/iGQ3c3Hman/sifgoEXNZlWNwsGMx96V8Vir7GvWyfGbyBhMBvoc3S0R13TdVxQqNvoHD0pOFA0jNvp4gMKUnmUg7sQtzwsGdDOhIpS38FkFbH6PMJPRFB/4iSlOC4fQW7Cm4OAq4//E4Y28NQ7Q8R+KJ7828ykOa8nueEbiIkxM6iNE/D4mFH6fgXzoBgogGJZMos7upOCxgkltDyfyEe7vh8NLoieDMDNeGfILyWV0qczBMnFYnSkUJk08G1MckJlCO9jsHt7RJzL60zJ17wTI36u7zXstKmBqgN9PxG2XFCZfIT25g5cyu5sy5IlPIn7NQuC6NjowuIBEJZTjik6zuezQsBtUPta4t1leU++DaW6aN/K3a764xSObdo7gSIL9T3VjMDu2DsPJjX1HyZ/aZ4R/CIvtDBzg8l0JG3zyhejrUORAVzIqKqmhxMkjG3AndEJ9R77A4mSMEIiXPPyk1NVcmiy2QjUW8MAdyDY1mZOX+d9hcyYDYmbIch1HoQNsTElt4mGn7VUG2a6GE8ivRN41qAJ+jSfpyNQky0fOOnEXEYatdAng2+XomUUONHkhMTQAVmgR6VBJjTe2FmLSODUqMnn7EdzevX8s8LsFXiv9nA82szIxMOFj+mreGDFbKilG7mDU1ZyWAtmVQ5UVaFC+QDeE/wWuos1yXrIazHTuY+FOWg6hSiOThIzXqgyLBz0jJwWU98jp/tJdaS2DXZQjgZs/OdwuK/SL4G1xM1Qp/d5/yDnOJmqjgoK4Hp20P5mNG3iWah/3oy+q0saR/nUY7o6gcbSvurwpK+NuD8SjnxG691ByuxADV/tMFaRl8jWZBVZyxhMymKCVFiRL5lqWPk3gkYJMVIzRW0Zki/M8FC9pn1vy5pripA== X-Forefront-PRVS: 02778BF158 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR03MB2287;23:w7NzM1+YC75IYFNDCq/M1b0NQnTwyBXTbsz+ASTTe?= =?us-ascii?Q?7LUjH+lNtKtFWfQb5jESwIfYcApWaNuEuatkc/dWfYrYs4mScyN/dqZd3YnM?= =?us-ascii?Q?u4rvjnMH09gt2NAQZn3trqSIiqEaBTapioRxGYjOpbTwEpOMcdNYI2g4+d5n?= =?us-ascii?Q?23PvgrxY6rUOrBpBYu474K4ytSNgvllEL+8DalA4QAVchOYv3YuYk8p4TdS6?= =?us-ascii?Q?BnZViIu1PeScLrRQyslsJNr+VsNkDLE/sRLAyVFyOBlp76TF2UItxXU7HuEE?= =?us-ascii?Q?d19X5TbvWcq4AlcGtGtMIwX9SPphpOOZJbu1fUv36O/8bCvBtZlY+T25nc0J?= =?us-ascii?Q?trFOWCpLExZiZn0CQcZbqbmjMd6C0yKwKtY5rpywBtNS7mwJhmvXcxfYpXwq?= =?us-ascii?Q?qCqci2CZdJI+7hQZBghJWXbAJc2xoj3Hi1DX/mk9iRX8AR5h/c9UT9WB8yOR?= =?us-ascii?Q?2in/hsvBkBdMsTIdxtW9k6szEpf6BEKb76Buj8uWOs1Fm9Ra+kplehhmZaZ1?= =?us-ascii?Q?XP75SgvyNzutUMrSug5NWIw4unxp7na5bf42DOl/8wzQAj6HZLMKd50X2xhx?= =?us-ascii?Q?VyZ6yXnAIhATIKqAZmBE80S+VEAcijeqjd4wDE/hgRqyTtYV4r+5XDGYF4J5?= =?us-ascii?Q?JyMB8LmsOh1RE1Q/4ovIjz9jN+TJneo713zMtxF13joMB/m5SHssXaUj/Gr9?= =?us-ascii?Q?UwBaDNnzcNUfv6appo0uPo7uIDiHJsgWaz3FZgYbFGhPrFOCOCFQhr4zTMAw?= =?us-ascii?Q?GG07SL6rwd2u80cBKt0wL98RwBxOd2zF/kaVbsOxBuO5Bh0yuZCiYNJu/POJ?= =?us-ascii?Q?nXi3SAFSE5sN5dHJ00un6zxzbgCzqLrkXzYfI4kIbGV3g4KE4k/y9LFgQZj9?= =?us-ascii?Q?hmaZsISHHkNtg1hsga78W29Hi+PPeF1mHP3vDWLF7i9JfiDgH5R3sJ4aVJ+v?= =?us-ascii?Q?Q6bfZxGN6VgyhvRwXgo7KepDd+iEDueilPFudG5CvHUhgiuotKGdPRHtBNNy?= =?us-ascii?Q?xuUM/gR14lbQjjPEcxHrUvX/rMps0BNGcMaPFLNoNeu8UObUIixjU5cWWOAE?= =?us-ascii?Q?t9IEz3KNM1DiSMZoiKVmMRcfkQHQi2YVF5xM70rYZQHmQ3VqKcbHl3RP3z3g?= =?us-ascii?Q?w/zpwvFLT/5wlftZ0e0qmBmefeWGe+Ji68O1WrZeOwZ/maAGLEEw5ZIVh++g?= =?us-ascii?Q?/RWzLO4fDtyOsKm+whB2dZL8EqignVEBAsfMZU4tSpMnHY58NTjPh2pVQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2287;6:zSfVmhXKJwZrKFsr2bO+Ni2E4jD9k/Af5yVm1GMSSbZuJCTK5jtxEp7kojr0wMmgvrrNNLzSNdynAVj2DBu4KVSZjFAD7vcPVweZTi2EjuNA2whmITVlXB6sXNTX3R1DgGYlYbS5tvGncX9uA0tuq2HrU3/Ldw9nQ5V5U2j1gy8wPJzhSW0VbY6eZGJF6Mn2iLiT0zi1Md7y0afbje49GpnHKFF9AIGNcYkxNENcNEP7B1z+EZSfL58BLc5qQGb17tXltRz+pmY2rpVPhplCtUsA3s1Y1fk+b2VBgh6Sp3haDRmvsEN8ggSi7594e7ZYlJLh6iZi6P14oECUWy+L/MpgjbNUDKKYGyqJiGbM9qWYSgFIZZYLGw9c3OHxJ+HoMJ/rr8vURApnxFTZhy8xoV9KUCCvFa72edgg4nYA0NRi3uSGrSovqQtDqXXVWEFAGanehO3GfOIlEqKh5evVsA==;5:st368iDujRYeOIGBJVwiu/uLmHj5OFUydXt46/3qRUqU3sv8DhD92RIuDqg6OjcUAn6L9eK6tyabDfVms8dsykYcSF4dnczZ+UotaQosnRz0Cn1WVEffLq2uW08Fje/24FycUhpsO6h9EIbH2wDS2JjMQ68WWfJ3tLs/iS86aFu9eZamyQgoeZ81zKJA28QG;24:McqMm5a1aK5uXtr5wsoCaFwTpxtjYn/ekoQPp1aXtYVAOV5gFnXtPl26HXgrYK3t+4L99NF11ZRBeQOKMU73xlzMbPcfyc5vhsjP4Lw6ln8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2287;7:sLSayLgkda/5s6aR5bsRz6yK8wg0Q7kjsqHxbtJULw6QatcbNGnLmb73H7tPF5ZLAQbAMltfjok3lXyIrODfSfAkbMadM3jBB+V1WgSZnXoUEJkpbiH1MiO3+JtUjcvEPv6iJR8wRuxYaKThE986wlvupKAcFAPA52VhbkTa2TzUS5MrLOIJkK5VBzUL3Vs9Xxipzz6k/2HQFls3hMEFeBSGedjj+zAcpVXD1WZIEzbVVPC83xgwHkPWxXYGFY0CL1+dBxIdxnyGkPNvkLMOVnPjF57+f7VDLF1D8EoJtvkMcusm6A0f0bGLMV9N2sqbiUKU7T5dI5xrFCR9egGONw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2017 14:33:01.6008 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2287 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For anatop regulator we must have a name accordingly. Make sure the name is properly checked before using it to avoid a possible kernel NULL point crash. Signed-off-by: Dong Aisheng --- drivers/regulator/anatop-regulator.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c index 6135995..7d6478e 100644 --- a/drivers/regulator/anatop-regulator.c +++ b/drivers/regulator/anatop-regulator.c @@ -198,6 +198,10 @@ static int anatop_regulator_probe(struct platform_device *pdev) rdesc->owner = THIS_MODULE; of_property_read_string(np, "regulator-name", &rdesc->name); + if (!rdesc->name) { + dev_err(dev, "failed to get a regulator-name\n"); + return -EINVAL; + } initdata = of_get_regulator_init_data(dev, np, rdesc); if (!initdata) @@ -300,8 +304,7 @@ static int anatop_regulator_probe(struct platform_device *pdev) sreg->sel = 22; /* set the default voltage of the pcie phy to be 1.100v */ - if (!sreg->sel && rdesc->name && - !strcmp(rdesc->name, "vddpcie")) + if (!sreg->sel && !strcmp(rdesc->name, "vddpcie")) sreg->sel = 0x10; if (!sreg->bypass && !sreg->sel) { -- 2.7.4