From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S947553AbdDTU7z (ORCPT ); Thu, 20 Apr 2017 16:59:55 -0400 Received: from mail-ve1eur01on0138.outbound.protection.outlook.com ([104.47.1.138]:63216 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S947474AbdDTU7w (ORCPT ); Thu, 20 Apr 2017 16:59:52 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; From: Peter Rosin To: CC: Peter Rosin , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Subject: [PATCH] iio: inkern: fix a static checker error Date: Thu, 20 Apr 2017 23:01:57 +0200 Message-ID: <1492722117-19618-1-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: DB6P193CA0021.EURP193.PROD.OUTLOOK.COM (10.175.237.31) To VI1PR0202MB2558.eurprd02.prod.outlook.com (10.173.79.137) X-MS-Office365-Filtering-Correlation-Id: 61a5bd44-36e6-42c8-5b3f-08d488302e17 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2558; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;3:mry7Eucjchzg8nI24rvB8EduBW55ofzjSMj3Uo3xhBdSB0NXZFzk/M+uB28OLGwlgFJzOJx/cgZFLJc2vnhjRnSeygL6pZ21aMEdFuwqOJMwpBVCODkHjQDV515UYB0Qodr5FHSR3wYxbuvGe3Fg0nnZlfUMdp1BpoiOrUpyr+I7tUJAm4GPyxy/bU5t8nCqUR6TbZoe+NXmWJleszoNC238uhjurFI+HeFStq7trj6japy3gPcD314Yf+T87H049ATATZPQdXtKP8cOm7Vbkn200cDsDoUvAsZYenP3OsSVq8ehXz5RD2jCxwC7AwUP;25:br65CbJJ5RE93ScZ3CnrFiMs7K+fxGDUsio0L1VBOZDMMp7ekQ9WIdu5mq9J6YOiN365fUPiHi9k7v3R/6MtxcJbHv77DET3DSeYOymL66aBxxQSmPDmAVZwWlYttxz17T//Hh2Dl5OwPan0ZuqsfmstTwPq4m9uTiQmvOr7k2/6/4KuP9oT7X69nN5A/EVEVb63bYbTouk9JGmcQfboRNIs0vzIMKMYdhdGFtKYcEa6s54ajtEz6+pqxfSCKqE6PToY/61aN15Xlq1B6GFtye1d9sGvwDAeK/qxWQ6xG/ORKlxz0ln/qE0SGWycsDztpSfJhEr0HSU/IJTgvcwM+/lR2/LUzStPogq17GpfRk4gfnKBIYHous8q9+BpLJ75WQAxxIon0setxcLN1VSK1U+v3uTiIaBIGUqrnbjZidf9/fwICYYnhE87mFfaQPpeUJ3wVpCGWo2YBB8cvHZZrA== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;31:BLa+doJzVzknmgqyGu2VWkBxQlqD4BF8w0W8t2/OrzWWSP7FC7lCGarO6rM+oEuUPkRanXnKjZFyOGjLQpuAbX/dIG76XOltmf1wIJriOpDltDGj0p2DQPhhjzBpR0Rqt/P3oZTd+g5Ey5Ij0nqxHB5o0Ww6FCaW9fg6zwh1SM9TJq0chvCLLC0yOi7ktLAFti3zBehlurRidTNjEYWPuNkVQI+rQphsiE4n5yP2HqY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(2016111802025)(20161123555025)(20161123564025)(6072148)(6043046);SRVR:VI1PR0202MB2558;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2558; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;4:ZdsjNwaCmmHc46gNI7MwzN4XYjC2WUwOVGaEIlfCVY0TZcDrHeR+HhRgSVbyvQRwe3RBPZxaXKOlZ0BsDDJh5zMxqCvpLHUnJSK9AWpaUOfyDLBn+MHAQ1amzBHCh004IsDDy3Fg+A3OC7LVfHAdPFmS2NPqe7TyDm+SvPtDsFCO13SgS0y5NKUlwA890lNRkmEtrWebwsYqiDfCxZdzwRsnkWg6qiJy1q3DuUqD85F3WlIYatuDrDeqH4c2NjMR5yDfIha4ojK+/QSo4eduOCcjgO0s3H4wtc1fGbvCr4R2V8JWR2OUryDGexk5/2NrNB6KN4TvqXEKfRg1kEzKzx2rbRNu7M/TDmsFYdn6u9v32NYQNTbKuKF8RF9AYfgbbp3SsiNssajfNczO7+4WlMmIkDm6iZWrNccUs98ke1cM5MGoG5AAhOLkd5YxEC/JW6DPqsDWtZu7WdMeE7LYycqSUmZzRFNGyNRlJX+qcgzGZAbzELL4r/qb66LOkWJwxGM7fhLCO6neTQyb5NWkU8UC1wGTTX8CasTn5w3ZoXKA8JsxUHkkx7ugoygdFUZw1la2Prs8wxAM7zxQy1f0lr3n5Q2CFXfiaRlICKaoJhfXidgjm5dS82UgsmdVoKjKX9L3Jn4Imy6XTjfJ55lFJApm4lAHrx6y+b97YCqD0zfSGkOVTwsT0U3vfdhJwB3hos3T7n9CurAqSAZTTftI7GmabiQxlaIse0M7SOO5lCmmw69ALouQR8YEKYvN+thkH7srB7NnZkze/pGme5GrCQ== X-Forefront-PRVS: 02830F0362 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(39400400002)(39410400002)(39830400002)(39450400003)(50226002)(66066001)(2351001)(53936002)(33646002)(74482002)(2906002)(6116002)(110136004)(3846002)(6486002)(86362001)(305945005)(6916009)(38730400002)(7736002)(25786009)(6666003)(6512007)(47776003)(54906002)(4326008)(50466002)(5003940100001)(8666007)(36756003)(8676002)(5660300001)(81166006)(6506006)(42186005)(189998001)(50986999)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2558;H:localhost.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0202MB2558;23:cwZY+izk9EWH1ZgXz2a+oAmNOUbTjikxt9U57zs?= =?us-ascii?Q?q3TuBCnoFo5dnxdi6Sa5DMRwcg1Er5/q4o80FsyU+p1Mmg2BcvieXkFhYopA?= =?us-ascii?Q?dOI5URjWLtujdGYQz1vku+F2pKJNGqzzcm/mafeK6Pz1ojijqlw/RFwJgGHk?= =?us-ascii?Q?RXtHlIQ/Z89+lcjXENlDgSTAmgwJU4x+4ExxVXEepeufO1luJfy59b5V1nfP?= =?us-ascii?Q?uYMD4a2LESRBmmOQ8NThNJK8lZdBgnYzXASZs6HvTPGLKgai3//DZXqt3epA?= =?us-ascii?Q?PiL2Z2t4FReU8czob8tg8Zf1IQdW23ZqS5U1Fvsjny/cYiR1K8SlZFQd1URZ?= =?us-ascii?Q?wRxmA1hO8mOrKo4WayBde69SxPAEeDRce8tWX77PjmkvcgsnDu+5Fw88hOaY?= =?us-ascii?Q?BBJVVQR2Fh9+0EgAOTPwblj4GxE3b1JDZLaXkvnikCIEwaWiPpx/0HtB+9dw?= =?us-ascii?Q?sZhcIjejRAArYjotxuNDTLx9XbKg/6WxunQ+8NlqT37NOxknXCDCjXrChUK/?= =?us-ascii?Q?tmqeQQJ74WgZhdvJ3zdzNNqKaWHBp5gScUdMOt07is5oStKgpx7fjRJKp/xI?= =?us-ascii?Q?qFrv3q6xYucBtFCyUdhKRZLTy+4byQM4iqTpx/t90mN7O9Fsi+yacQla7w2Q?= =?us-ascii?Q?uKu08VJV3OYiJpfHaxeD68Un7fX/smfsNSq0t9eyzUvpI7Z3r7AiRAImpSuY?= =?us-ascii?Q?b1TLd046+ySlpdk1zhLuqTl4+giNr11od13ambM3riAF+vAXD5Xen5xpNN+6?= =?us-ascii?Q?GW90RdPZ6SVo5q3YVYPQxMwhGDMzijtxFiSdwM33UOtaEIBbhYDS6HWNZcXr?= =?us-ascii?Q?aoVzhrg4U3KI5YBc6Mmj3n2YBnlcmxcBtnc/H6cvpv0XWCnfm+yY5lj72w8J?= =?us-ascii?Q?jzNz+391J2/6r4EqA1QvDF+1ddY+HOxbs0+JLSqmMSk/X6tKEIZ6oFGQsUth?= =?us-ascii?Q?cplODVM1wPFdr8a3wHyB2Ftyut+p07Yh6O8mvgv01oDRM2VvakAyax8wP1+D?= =?us-ascii?Q?sRwTRdBkKM3lL6wWKGPjNilMZBDhoMmPTu0lLn9rTdNc0Kw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;6:bAs+ae1bo+2o4IYMG3pq2w784EjfXR+E/B72nNQfBV9cvi/2m0M8Vq0gLMs/cv3FFg5EB3UCQXQKLgUq4tBfX+qlj2vB/P+A+ZphDiYhVePkNW0MhupORy0cm1fBu1XXLoyXAR4kqRKFWjqCM7yQCVXLOi7MYUA2J1/55aRxBS32xYKbJajyOH7u4AJVfDPZe4k6wwbscU0xKtTC4J6yJ0RrY+fnxuwwhuR0TBEfoVIxIQW1KRlzxqiCsdqC+LzaABaBHInrIfZzLnaiOjPh5KRwuTg+cBcJ0QhfR5Po9wKb5I0Xac7Hm3qESfiUUCp7K3XU7GtgshWsRLF81CvLS/dWjoWWVbbZbQ4sjn1WlJ61l3vwtSJTvzhP9k5Cihy/uowxLuQt6M4J9ae9XMzNss8fwmLKjB7rjhaN3KCcyAUeufGyEHxTa3AaDG07FXzR1GPHqhebHsTasHAfnjgbgQ==;5:U8kkQB+l60TLhwJjoDmm1FivvTlNCPJUaZlAa+nuvQyM+nevvR7iW8DL4rqRh5GM9UPm7HKE0enOP/CXOGSyqFJU8M717zZMTi7uEt54w5hJ3dt/7e7plrUeEdmrHJRQFu5FyaFezRXJlt4uUw9d0A==;24:Kh8HiOArRTq9mzvHKuM6dIpiIf1G/WM9SQf63/xFHtQma401Y+BNVLlkUM7buCpcXKAejiZ+deFvNqfoa0WoblfSh0VdY8t9LH34FTWhggo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;7:Q1BWcKQBVdQx8vn3AAsklvY1j4FXifXfu/FdYUvG2Itr726QJ4QA84yxCT5XmXLDOJMDDwbLtmcRymVL5QKg4VRI/GNDzQaPJ5cMKmwvHGK5MvaAyxKruGl1l1KWEbpaoMOLQRJvbFsQcqgHO+jPVY6kl31upC8Zf/pPNp9HlrDGJd0JumJiVN34dueyhWE5ArC5GPaBvPOqAFjMvM83xRUV4TNcjHbrgnlUUjaUO5gJg8m+x2UNefoixbBn05zd3jAFSUcnGz+fs3dcrQ3ydsq39DqjMOftLBJhUiWMmFRwNpjbOzxsJD2AAsF1A4o296vsSiUCWXhi83+OZEW9Rg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2017 20:59:46.8413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid this smatch error: drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock 'mutex:&chan->indio_dev->info_exist_lock' Fixes: 00c5f80c2fad ("iio: inkern: add helpers to query available values from channels") Signed-off-by: Peter Rosin --- drivers/iio/inkern.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c index 7a13535dc3e9..a3941bade6a7 100644 --- a/drivers/iio/inkern.c +++ b/drivers/iio/inkern.c @@ -750,11 +750,9 @@ int iio_read_avail_channel_raw(struct iio_channel *chan, err_unlock: mutex_unlock(&chan->indio_dev->info_exist_lock); - if (ret >= 0 && type != IIO_VAL_INT) { + if (ret >= 0 && type != IIO_VAL_INT) /* raw values are assumed to be IIO_VAL_INT */ ret = -EINVAL; - goto err_unlock; - } return ret; } -- 2.1.4