From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1044713AbdDWKBk (ORCPT ); Sun, 23 Apr 2017 06:01:40 -0400 Received: from m50-135.163.com ([123.125.50.135]:47961 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1044397AbdDWKBc (ORCPT ); Sun, 23 Apr 2017 06:01:32 -0400 From: Pan Bian To: Florian Fainelli , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] net: bcmgenet: fix incorrect return value checks Date: Sun, 23 Apr 2017 18:01:05 +0800 Message-Id: <1492941665-17155-1-git-send-email-bianpan201602@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: D9GowABHItlhe_xYD02BAA--.432S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XF1kXrWfCFWkuFyxJw47Arb_yoWkGrX_K3 yUXF47Gr48Gryq9a1Fya17ArySqFykCr18uFWkW34avF9rZw4qqws5AFn5AF18u3y7KFyq qr1akFZxu34SyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUngTmDUUUUU== X-Originating-IP: [123.118.194.153] X-CM-SenderInfo: held01tdqsiiqwqsqiywtou0bp/xtbBXgXC4FaDqPaqmwAAsD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian Function platform_get_irq() will return a negative value on errors. However, in function bcmgenet_probe(), 0 is considered as a flag of error. This patch fixes the bug by checking whether the return value of platform_get_irq() is less than 0. Signed-off-by: Pan Bian --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 365895e..0bccf2b 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3329,7 +3329,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->irq0 = platform_get_irq(pdev, 0); priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq(pdev, 2); - if (!priv->irq0 || !priv->irq1) { + if (priv->irq0 < 0 || priv->irq1 < 0) { dev_err(&pdev->dev, "can't find IRQs\n"); err = -EINVAL; goto err; -- 1.9.1