From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1045260AbdDWMS6 (ORCPT ); Sun, 23 Apr 2017 08:18:58 -0400 Received: from m50-135.163.com ([123.125.50.135]:36155 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1045244AbdDWMSo (ORCPT ); Sun, 23 Apr 2017 08:18:44 -0400 From: Pan Bian To: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] [media] cobalt: fix unchecked return values Date: Sun, 23 Apr 2017 20:18:29 +0800 Message-Id: <1492949909-893-1-git-send-email-bianpan201602@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: D9GowAA3XDiVm_xYQLmJAA--.800S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xr4xWFyDCr4DWrWrGryxGrg_yoWDWrbE9a yfWryxZrWUCrs8C3WSk34xZryFq3y3ZF1kZFyxtasxCrs3Ca1vqryqvF1qyr1UWw4fZFyD trWDZF12vr1IkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnhL0UUUUUU== X-Originating-IP: [123.118.194.153] X-CM-SenderInfo: held01tdqsiiqwqsqiywtou0bp/xtbBXhjC4FaDqPdvIwAAsi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function cobalt_pcie_status_show(), its return value is used without validation. This patch adds checks to validate the return address. Signed-off-by: Pan Bian --- drivers/media/pci/cobalt/cobalt-driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c index d5c911c..f8e173f 100644 --- a/drivers/media/pci/cobalt/cobalt-driver.c +++ b/drivers/media/pci/cobalt/cobalt-driver.c @@ -205,6 +205,8 @@ void cobalt_pcie_status_show(struct cobalt *cobalt) offset = pci_find_capability(pci_dev, PCI_CAP_ID_EXP); bus_offset = pci_find_capability(pci_bus_dev, PCI_CAP_ID_EXP); + if (!offset || !bus_offset) + return; /* Device */ pci_read_config_dword(pci_dev, offset + PCI_EXP_DEVCAP, &capa); -- 1.9.1