From: Karim Eshapa <karim.eshapa@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Karim Eshapa <karim.eshapa@gmail.com>
Subject: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.
Date: Wed, 26 Apr 2017 18:15:40 +0200 [thread overview]
Message-ID: <1493223340-13794-1-git-send-email-karim.eshapa@gmail.com> (raw)
Fixing sparse warnings incorrect type assignment.
Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6134eba..cf6bf65 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
datap = skb_put(skb, sizeof(struct p80211_caphdr));
caphdr = (struct p80211_caphdr *)datap;
- caphdr->version = htonl(P80211CAPTURE_VERSION);
- caphdr->length = htonl(sizeof(struct p80211_caphdr));
+ caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+ caphdr->length = __be32_to_cpu( htonl(sizeof(
+ struct p80211_caphdr)));
caphdr->mactime = __cpu_to_be64(rxdesc->time) * 1000;
caphdr->hosttime = __cpu_to_be64(jiffies);
- caphdr->phytype = htonl(4); /* dss_dot11_b */
- caphdr->channel = htonl(hw->sniff_channel);
- caphdr->datarate = htonl(rxdesc->rate);
- caphdr->antenna = htonl(0); /* unknown */
- caphdr->priority = htonl(0); /* unknown */
- caphdr->ssi_type = htonl(3); /* rssi_raw */
+
+ /* dss_dot11_b */
+ caphdr->phytype = __be32_to_cpu(htonl(4));
+
+ caphdr->channel = __be32_to_cpu(htonl(hw->sniff_channel));
+ caphdr->datarate = __be32_to_cpu(htonl(rxdesc->rate));
+ caphdr->antenna = __be32_to_cpu(htonl(0)); /* unknown */
+ caphdr->priority = __be32_to_cpu(htonl(0)); /* unknown */
+ caphdr->ssi_type = __be32_to_cpu(htonl(3)); /* rssi_raw */
caphdr->ssi_signal = htonl(rxdesc->signal);
caphdr->ssi_noise = htonl(rxdesc->silence);
- caphdr->preamble = htonl(0); /* unknown */
- caphdr->encoding = htonl(1); /* cck */
+ caphdr->preamble = __be32_to_cpu(htonl(0)); /* unknown */
+ caphdr->encoding = __be32_to_cpu(htonl(1)); /* cck */
}
/* Copy the 802.11 header to the skb
--
2.7.4
next reply other threads:[~2017-04-26 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 16:15 Karim Eshapa [this message]
2017-04-28 10:02 ` Greg KH
2017-04-30 16:26 ` Karim Eshapa
2017-05-07 18:39 ` [PATCH] " Arnd Bergmann
2017-05-10 13:15 ` Karim Eshapa
2017-05-12 8:07 ` Greg KH
2017-05-12 12:47 ` Karim Eshapa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493223340-13794-1-git-send-email-karim.eshapa@gmail.com \
--to=karim.eshapa@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome