From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S376634AbdD2Lfc (ORCPT ); Sat, 29 Apr 2017 07:35:32 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34488 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1166638AbdD2LfL (ORCPT ); Sat, 29 Apr 2017 07:35:11 -0400 From: Tuomo Rinne To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction Date: Sat, 29 Apr 2017 12:35:06 +0100 Message-Id: <1493465706-16290-3-git-send-email-tuomo.rinne@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1493465706-16290-1-git-send-email-tuomo.rinne@gmail.com> References: <20170428102731.GA10820@kroah.com> <1493465706-16290-1-git-send-email-tuomo.rinne@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 9304b5b0d4fe8498d3d059db4bb8a7de253355a5 adds casting of le16 values to cpu to get rid of sparse warnings. The u4bAcParam is therefore constructed using machines endianess. However, the parameter ought to be casted back to little endian to keep the function logic the same as before. Unfortunately I don't have the hardware to test this change. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 5e84ed7..dceec20 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -2321,10 +2321,10 @@ static void dm_check_edca_turbo( u1bAIFS <<= AC_PARAM_AIFS_OFFSET; u4bAcParam = op_limit | cw_max | cw_min | u1bAIFS; + cpu_to_le32s(u4bAcParam); write_nic_dword(dev, EDCAPARA_BE, u4bAcParam); - /* * Check ACM bit. * If it is set, immediately set ACM control bit to downgrading AC for passing WMM testplan. Annie, 2005-12-13. -- 2.1.4