From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbdECLVa (ORCPT ); Wed, 3 May 2017 07:21:30 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33437 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbdECLVX (ORCPT ); Wed, 3 May 2017 07:21:23 -0400 From: Surender Polsani To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Surender Polsani Subject: [PATCH] staging : rtl8188eu : remove void function return Date: Wed, 3 May 2017 16:51:14 +0530 Message-Id: <1493810474-26794-1-git-send-email-surenderpolsani@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernel coding style doesn't allow the return statement in void function. Signed-off-by: Surender Polsani --- Changes for v2: corrected subject line as suggested Changes for v3: modified from line as suggested by Greg KH placed a semicolon in label for fixing build error Changes for v4: removed label as suggested by Dan Carpenter --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index d04b7fb..f3871a5 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -144,8 +144,8 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) hw_init_completed = Adapter->hw_init_completed; - if (!hw_init_completed) - goto skip_dm; + if (hw_init_completed) + { /* ODM */ pmlmepriv = &Adapter->mlmepriv; @@ -162,10 +162,9 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) Adapter->HalData->odmpriv.bLinked = bLinked; ODM_DMWatchdog(&Adapter->HalData->odmpriv); -skip_dm: + } /* Check GPIO to determine current RF on/off and Pbc status. */ /* Check Hardware Radio ON/OFF or not */ - return; } void rtw_hal_dm_init(struct adapter *Adapter) -- 1.9.1