From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbdEFP2G (ORCPT ); Sat, 6 May 2017 11:28:06 -0400 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:34235 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751572AbdEFP17 (ORCPT ); Sat, 6 May 2017 11:27:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3872:3873:3874:4321:5007:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13141:13181:13229:13230:13311:13357:13439:14181:14659:21080:21433:21451:21627:30045:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: sky67_450e96c426d5f X-Filterd-Recvd-Size: 1720 Message-ID: <1494084473.31950.26.camel@perches.com> Subject: Re: [PATCH] kernel/cpu.c: fix many errors related to style. From: Joe Perches To: Matej Dujava , Thomas Gleixner Cc: linux-kernel@vger.kernel.org Date: Sat, 06 May 2017 08:27:53 -0700 In-Reply-To: <20170506150958.GA17249@ns1.kocurkovo.cz> References: <20170506150958.GA17249@ns1.kocurkovo.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-05-06 at 17:09 +0200, Matej Dujava wrote: > This patch fixes the checkpatch.pl warning: > ERROR: spaces required around that '=' (ctx:VxW) > WARNING: Block comments use a trailing */ on a separate line > CHECK: Please don't use multiple blank lines > CHECK: Blank lines aren't necessary before a close brace '}' > CHECK: braces {} should be used on all arms of this statement > CHECK: Blank lines aren't necessary after an open brace '{' [] > diff --git a/kernel/cpu.c b/kernel/cpu.c Please don't modify core kernel files just to shut-up checkpatch messages. If you are doing rework, it makes some sense, otherwise it doesn't add much value. > - /* Entry state on starting. Interrupts enabled from here on. Transient > - * state for synchronsization */ > + /* > + * Entry state on starting. Interrupts enabled from here on. Transient > + * state for synchronsization Fixing typos would be nicer than merely reformatting comments.