From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754420AbdEGVoZ (ORCPT ); Sun, 7 May 2017 17:44:25 -0400 Received: from mail-eopbgr30082.outbound.protection.outlook.com ([40.107.3.82]:50515 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751726AbdEGVoQ (ORCPT ); Sun, 7 May 2017 17:44:16 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; From: sanshan zhang To: CC: , , , Subject: [PATCH] leds/trigger: system can't enter suspend. Date: Sun, 7 May 2017 10:01:21 +0800 Message-ID: <1494122481-15228-1-git-send-email-sanshan.zhang@nxp.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [123.151.195.1] X-ClientProxiedBy: HK2PR0401CA0005.apcprd04.prod.outlook.com (2603:1096:202:2::15) To AM4PR0401MB1810.eurprd04.prod.outlook.com (2a01:111:e400:7a71::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 286e036c-4ecd-4ec6-37e8-08d494ee74b4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:AM4PR0401MB1810; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0401MB1810;3:ZXxMOZLZwB172xt9Fz5rAFABfTcn/zr7VIZtxbIxKw2WYheHGF4lA8zsOCeKwcEH5yxFug+x2/+ey3WD4oeBXyI3OPZW7+NIJxhLycbU3h8I+i0y9/bb90vSKQTweFp+nAkc0qiT4zsbmgYItfpixCahr3/tXdbDN+98jO/Z7UhzIhyYaC3USG9EFSyrZ6VkToTThhKklj2ECuUjhT3U8K6+vrc0nNGXUJrspcZsIdRczR8Y1zp3a5f6wqU+GKxrR+0OirGbzfpRurlX/DIzjp83xBZ15cHHd0FMKQy8WpIO9A47IBKlzbAwh2ztx4c50xlA7tdBP9iCC/1FokXtnqzviu6gVlIIXEnje2jljJA=;25:ZUIU+OpldTp9lg8JcuPMO+F4PmCko91PKq3Ch8ElKb9O0Ui+ei2WA3c8UrjJ7sil+LnSW4GwnyN8HtTjM1qaa3Y6iemmq7d7kVgFeUwNiUQIbpme1l8OSYvhWKHwERfGIASGKVXL1FVcfSKKnKttdHcawiqa1oJBjhQeJtQfhmRys2zTxYOTqmbq86AN7lqN2MrlN6leYvLme2nRhtN3JZEqweZIjmHJ4+fyWQRe2d+lvABtWqVBQpYWbSOqIn+rd3f9yJ/gnn+PuBu5j5O/UpD61HN6o2QEC0Dh+aVkduBsuKY0m8BakgE4STL/7wycZuoVxYZmzgs54PlgxXVvc40gHQvBQ0sIG4w+6iXiflJtOdxa7MFQCRwirukjJmWmQmSwLHl6TxkfxH8vO53fB3zkmXwIMCSgxbTH1z7Yvnb5xfQPwFjF/kQwYwsnKAE1NiHZGF3E3jIn2N47OEuL1zTbgVX4ePwdXtuOs8PNJlI= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0401MB1810;31:EP/W1TMa1YNjxz+U3vKanALD5of7HIoRrvUGt/r4kVAeVX0zd9rsLx1iDrAkKLviuXsa/DwSsMN/mYrEzhJFbzZFjCnO4WAT2zzT/2xhKMnr+3ghEdEToP6NDj52bz6V5ITGxW3vZVyGOnkKQzy0tFYMlx1PciqMrQPX78VfZxoIZRCN9DMj5aVq7Noh5HphQQ7+fYwYui3GGeq8wSVHFTtctufiJ84L/7d/fQhy3U/S/NiWG/e6X71x268IPTdrBTz8YxvuT42ySy5ZPRlqcA==;20:aOA5ygMS6WWQoK2ZjFldUpXd8mHEetYIKVyhD1w+u8JPpO3cQ1XrzBBSSbQDKVGREUH1pO9rHgDhDDAtWt0XvLvOZgGohazGjEbNpdbFACtGmvM1tjfcpOPbHdKwxCIslTnA2xLl/g2i7cXQCWHqSyA0iYssFfFxmXMKVuEe9M0oDHXYOOCVkoZIOSwu6riuJZ6A4tSoyda9YTZ2fB+bZi7oiCM0VI8a7b9+gnkMs5eAu4QwtU4J8Qr/ckxbvEhDFgjyKREpxIuq1MV9K9qcPLOibGNEmN6iC+mqcPD8G6g7xTCMsHgy5BjV+cvw7Te2wOkFsyKhrQiu1mbcTD+brIFQsF6W2/rTo3dvotLtXvqim9tVngIzbDYbU8NmZkIHtPf9pMV67vtJ+TNaU8nYUBbPqFyyM13C8ELHVcTAAKaYdyWVUMMvuGQoaQ9Gi90fl8URWlfXzeXZVoIq3yngkjoEqCmHwzrs9O6Zc1tboMULsP3awxTssg/+5xGbn5nu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148);SRVR:AM4PR0401MB1810;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB1810; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0401MB1810;4:V6XzPuAEQ2XA0vJ1N5MaCIA7rIUfcCckIuTihDQLuFriiB3Kh++aoIygFLyq1BXLTAXeE9HNDEKbIVCANxTiq2aoSpfcpGbSpgRwRrWiINa4wWrrQUov0nWLetFJlP7hIvb+S781p3UMcToiuV6YIRxPQnocjwRmt5QFRK+1KbaXCJrQVqZvrcVZ3oTrtN0s2lfSA6I6IA1W8ROXUvWSEJalQcPI3bv4fiUnCkue8agq26IZpKhUVHHDGMvrZkbiuK05L0aLMAf+e0hj5Hdvkxz+ggpIDMALZg5VT/KONxOYDtDjklhp8aoVdl17xV+0PMYnZYKinauNep/cfMv/dSp/kHvuYKiZZNYH4UHFk2YfNYGCa75z4LHBD7eQjUMYc9VwrX/3FXF2q8sgobv0X/ikVRkihRsZQtoXCgi8dQMPtRQnhiuditNNGLqo8dk6cheZMftCnheN3d3lzbIaydHNDIzDr3GsUODStZ6l6/lzKL1tNSD+VAIGmew5MZErXdZO+mrXHUBGTRZv7NPFGOBqn55+QQgnpEa0bzHez74fjmbsBR1Prwv1Tz26Q28q+ZIJ331j5hcpUdlZukoEtj638LcK6rFu+FMMVuBq7iVcQDyi4rM2syF0DMjE0UCkOFbwi939hYIjp78OjG2ZA48zTwrrenx032UJL/m0EzDPPxCocrS4dC9aJPJ+6VdRZncHe+zp5SfxLVb169g7HKsTN5gnh2BycMoUCB40IaCOLbd55hCo6T7EtR6X0G6cBCEY4ymrmUW1b8rfvZcebzlEf6fLi3gMXAizyv3cvENiS0ycGwrm3NGGZvy7ZfSX7FlNdkESElnPjPHqgB7fzyhsa+8SbltODPNGCKk3pws= X-Forefront-PRVS: 03008837BD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39400400002)(39850400002)(39410400002)(39840400002)(39450400003)(39860400002)(38730400002)(7736002)(6116002)(3846002)(110136004)(36756003)(5003940100001)(15650500001)(2906002)(6512007)(53936002)(4326008)(86152003)(81166006)(8676002)(50226002)(50986999)(478600001)(54906002)(189998001)(6666003)(2351001)(6506006)(25786009)(305945005)(42186005)(6486002)(5660300001)(47776003)(6916009)(33646002)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0401MB1810;H:scmbld2.ap.freescale.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM4PR0401MB1810;23:AbEb91shQh/oYdzKcbDNdzWDPY0LvrKn9X3cFmn?= =?us-ascii?Q?m3XMSZkMTwkOLCuQ6tN9m3HjL985kTC3j30yhkXdO2Bz72i6M2qVRabOboWp?= =?us-ascii?Q?I71YYMUuGSXAehdSBmss8fbGGZ+3Cy6fjtQ2iqpA3YjWePl5ZwEfWLr2cxeo?= =?us-ascii?Q?h9/c2QI1rpFGjGD0+MtNMnYxl9o82bsCXW/QU3WYkCd51HmU/T1juFO0GsEw?= =?us-ascii?Q?+c5ndi9VR6OlWiA9KfWdn6FulAOjgEj/IikjWv9xuEOEaCbbKO2EU8FfzOyz?= =?us-ascii?Q?rLqRU9JoF8dVoQ1pWwFloRCSGUXaB4KzXxFSwIlMymOJkXyynKRzMnS5l+Vb?= =?us-ascii?Q?VWc9cAZ/dFV1Av5dADcr8JVP9MvEv0QtdNkiCTtNdcg/cq5k4YcpupP8sMCn?= =?us-ascii?Q?5uOn8KRP0YIp3HRV8N3JChqMF+Tt3/RdL2oY3FKXD1aZmvjjehfzJpsuQ56r?= =?us-ascii?Q?ivHTTwoNnkTztBkdcYC7j1RV6wGSaHK6Mdp4sEhWmWiVYKxRt4V4h4IxRtpm?= =?us-ascii?Q?AhnlHc35TgY5JfhlL4Q1R1u6QlMTvmprlrkPhFCsIAyww3vFnIthHAWTtdZz?= =?us-ascii?Q?qTDWKDXAiYYdLKCqFnpfsAwpvHuh++t6MQiawxm6Go5qgfSXA5C9f/w9uQQN?= =?us-ascii?Q?YfGeAMUojM2zo42IwhXHsAvXo6VsBOx5GKWScSLrlilsbEzkD4yemXzRl2A0?= =?us-ascii?Q?VNCvFkZHPc/0PHn1Fkn5GDw8FDslq1EKQS/08ziKvCTHNuY8IfImkPcEGQJo?= =?us-ascii?Q?tUb5mRqyYBL19ePJFBi3SL+xhOJj1gOFql23OseialTXTbHPQOGexauIF6fd?= =?us-ascii?Q?VjBWw1KbW+9sftBsajeSO0OtHrromy17tbBRcMTWQm2hhZFGyB7/lTiOhMj/?= =?us-ascii?Q?R9m2dHTkxEGTlJ6CQ5Xqi3hXY6beUj7G+nGUVNgsLS0jwXVq8+QEPMJ5AVMH?= =?us-ascii?Q?KJZY9GWstsOffh/Xwj6+uw4Uvrq36Rwrdp+O4z80RLtCzWsKbPVoyfyFp7cb?= =?us-ascii?Q?FSSeCHIZRSrJvPfeTRK+YQImlXffnbxSWF7DjaHZllZ4QYA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0401MB1810;6:lNjXgtAapPVfzwcCQ2w+V3pkc4siiTYjFz3Vp9bn2HPa6X0qmjOdfJQvAoTloHBvJihuC8aiwvojW8/gWvMs7494zosOSXU9gkPPy2T60iniYVWuqLhXwcX3eqj+C+2Ep9AiNyQLGri5AyDmmaf9muqvYVFekXlSzv+/4i5M+q0C1PhOFrNT4L+HxxgiL3Jt+5jhFlIONDPOsnuL1VgQ0dyzEtMg9pOgUUeE36jDHJRVdsmmxnuTSMBHhfrISYhp+gCc+qqMt8cCPvaj4UAEhN/MrSOyN5gYySYgFMvZ/l9lN8JtepayQfTZmV0of+G7kw+UamJb0NTTxWpBpC1OZV4if+1yyLhFhso5Ic12BjS4KJcKSmSQd6spZxQZi4FmPx/F6XntItdQwIslR5LzdM9XcOZfseJmzYcvSSUv+P+lywCX9Ak3lOnp4MwcZ6D+YO5giBYG54BP26F785setf3bKfn+EAj8iJZAGt9rkaTlaEtZiF7cJ+gkTJ6ZSoqdwx2cwYGsdirEQ4pojQZcME3xCsfL8CPypsofmGSxyZA=;5:c2XMhNdPpB+QlNQvvjuu2wL+sCDSJVF7QkTeUl3hzmnknM2GvwStnZRvy3dasAkpkP3m8eAQj5H6YyzMLfSpJcdN2YofoN97YN3M41lSJ1cECF5LSTtu+4lRyu8GTqNpZrCGCOY9iEOJ1TzBmu3C/Q==;24:/nSHNMP68/eaInJfGOIc93dVN8gbMs9wOiKvvhAcZ512HrmCLYk6Lo6hQ7Sw2E1u8iXevAGUinjMP9YbwSMiKFMBiytofSwT/PIIH0Ip2pM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR0401MB1810;7:syRzFeAyL/Yn2V+NBhB34sx36cuCj7Uh/VcpwqKTIsfXi32Qsu02adkU0608AtMxUOBzyejgy4kqkXyHyTBV8gJDCymXuupBSjgyUnZEPuDlGNHFnWCteGEXUkcGscno0+l3vXrNfPr03DtCdRtQ1ZJtPSDDziicfDh4V1VHpC01US3vnpQPfJ71ssbun0h8tlNnlvX3q+M0Zav3uQRTTI+2VdYGgfBtzS04l0cK9/tmjsSl9gcpA7AtVL+x5OcM+a1WFXEXnkpVw3Ob0f56QHko1jLHR2ea+QO1C5kb8mXxoIPRXCFHYtpqRRARidwUJJhyGcj8B9tfzYy2RlC8mQ==;23:NObdNcqsTT9uxVXpHvMZsoTIXeu4WQi0LDkdZA0vfI9LNyKxUAJrjFmyikUKx6Tn+vdFmz9GQois+gGEV4dynyqv/uHrujQNeGmL8WdQsJ9IR1HMMHvf0ZXrZ92r+ho6/U6SxtwBVNnetw3l/ZQXyA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2017 02:12:02.5129 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB1810 X-OriginatorOrg: nxp.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhang sanshan system can't enter suspend when enable led heartbeat. pm will call heartbeat_pm_notifier when suspend. system will prepare led states, and led_trigger_unregister will use led_trigger_set to set trigger. kobject_uevent_env will send event,it will call ep_poll_callback to hold a wakeup source if we enable wakelock in kernel. So that system can't enter suspend. If we set led device tigger to NONE, there is not need to send notification to user space. Change-Id: I9f7ee5764d7e31b9a225dae5517cb36137675f9d Signed-off-by: zhang sanshan Signed-off-by: Zhang Bo --- drivers/leds/led-triggers.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 431123b..f03c2bd1 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -108,13 +108,10 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) unsigned long flags; char *event = NULL; char *envp[2]; - const char *name; if (!led_cdev->trigger && !trig) return; - name = trig ? trig->name : "none"; - event = kasprintf(GFP_KERNEL, "TRIGGER=%s", name); /* Remove any existing trigger */ if (led_cdev->trigger) { @@ -138,6 +135,10 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) trig->activate(led_cdev); } + if (NULL != trig) + event = kasprintf(GFP_KERNEL, "TRIGGER=%s", trig->name); + else + return; if (event) { envp[0] = event; envp[1] = NULL; -- 1.9.1