From: Karim Eshapa <karim.eshapa@gmail.com>
To: tytso@mit.edu
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Karim Eshapa <karim.eshapa@gmail.com>
Subject: [PATCH] char: random: casting prevents missing calculations
Date: Sun, 7 May 2017 14:47:25 +0200 [thread overview]
Message-ID: <1494161245-5722-1-git-send-email-karim.eshapa@gmail.com> (raw)
Cast (long)jiffies and (long)state->last_time beacause
they tends to unsigned long. may cause a problem specially
when comparison happens (< 0).
Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
drivers/char/random.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 0ab0249..f685e78 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1012,7 +1012,7 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num)
preempt_disable();
- sample.jiffies = jiffies;
+ sample.jiffies = (long)jiffies;
sample.cycles = random_get_entropy();
sample.num = num;
r = &input_pool;
@@ -1025,7 +1025,7 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num)
*/
if (!state->dont_count_entropy) {
- delta = sample.jiffies - state->last_time;
+ delta = sample.jiffies - (long)state->last_time;
state->last_time = sample.jiffies;
delta2 = delta - state->last_delta;
--
2.7.4
next reply other threads:[~2017-05-07 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 12:47 Karim Eshapa [this message]
2017-05-07 18:36 ` Arnd Bergmann
2017-05-07 19:58 ` Karim Eshapa
2017-05-07 21:34 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494161245-5722-1-git-send-email-karim.eshapa@gmail.com \
--to=karim.eshapa@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®