From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbdEILFZ (ORCPT ); Tue, 9 May 2017 07:05:25 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33333 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753043AbdEILFU (ORCPT ); Tue, 9 May 2017 07:05:20 -0400 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: [PATCH v3 6/7] perf config: Check whether items are from system config in set_config() Date: Tue, 9 May 2017 20:05:05 +0900 Message-Id: <1494327905-25291-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not being checked that items are from system config or not (i.e. a boolean variable item->from_system_config), when iterating over item list of each section in set_config(), instead only section->from_system_config is being checked multiple times, so fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index f62cc2d..34ebe83 100644 --- a/tools/perf/builtin-config.c +++ b/tools/perf/builtin-config.c @@ -56,7 +56,7 @@ static int set_config(struct perf_config_set *set, const char *file_name) fprintf(fp, "[%s]\n", section->name); perf_config_items__for_each_entry(§ion->items, item) { - if (!use_system_config && section->from_system_config) + if (!use_system_config && item->from_system_config) continue; if (item->value) fprintf(fp, "\t%s = %s\n", -- 2.7.4