From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbdEJAYi (ORCPT ); Tue, 9 May 2017 20:24:38 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57001 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdEJAYg (ORCPT ); Tue, 9 May 2017 20:24:36 -0400 X-ME-Sender: Message-Id: <1494375875.1064702.971453736.29BB0B11@webmail.messagingengine.com> From: Henrique de Moraes Holschuh To: Andy Shevchenko Cc: Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cc55fe1 Date: Tue, 09 May 2017 21:24:35 -0300 In-Reply-To: <1494351185.30052.94.camel@linux.intel.com> Subject: Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back References: <20170509141721.15841-1-andriy.shevchenko@linux.intel.com> <20170509141721.15841-2-andriy.shevchenko@linux.intel.com> <20170509171040.GD19242@khazad-dum.debian.net> <1494351185.30052.94.camel@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4A0OgWu010580 On Tue, May 9, 2017, at 14:33, Andy Shevchenko wrote: > On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh wrote: > > > While here, print negative error without changing a sign as it is a > > > common pattern in the kernel. > > > > A separate patch for this would be better: it would be easier to > > actually check that no functional changes crept in by mistake. > > It doesn't make sense to me. It would touch same lines of code I do > already here and it's only one place, see below. I had to go line-by-line looking for the darn thing, instead of just compiling before-and-after and checking for an unchanged object file. > > >   rc = fan_set_enable(); > > >   if (rc < 0) { > > > - pr_err("fan watchdog: error %d while enabling fan, > > > " > > > -        "will try again later...\n", -rc); > > > + pr_err("fan watchdog: error %d while enabling fan, > > > will try again later...\n", > > > +        rc); Yeah. This one. I don't have a problem with this change at all (I acked it), but it took some effort to find the nail in the hailstack. -- Henrique Holschuh