From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbdEJVIn (ORCPT ); Wed, 10 May 2017 17:08:43 -0400 Received: from a2nlsmtp01-03.prod.iad2.secureserver.net ([198.71.225.37]:56824 "EHLO a2nlsmtp01-03.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbdEJVIm (ORCPT ); Wed, 10 May 2017 17:08:42 -0400 x-originating-ip: 107.180.71.197 From: Long Li To: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Long Li Subject: [PATCH] scsi: zero per-cmd driver data for each MQ I/O Date: Wed, 10 May 2017 14:07:23 -0700 Message-Id: <1494450443-2921-1-git-send-email-longli@exchange.microsoft.com> X-Mailer: git-send-email 1.7.1 X-CMAE-Envelope: MS4wfMJ/TP+wwUh+0YW2K3qvgE32O5IMP7kjO8u7vAgC1BW9tff7AnNMdu36pkhHfddjdryvHsPYfuyokRjCIfFLestBqPWzpTRA+MUz6xBy05Y4HwvC9jVn fQD4zbwm/bt1CxE4AgOI1w6mOcAqDcexLOspuPjy5w5X2qKkJZ1t2cEvnHflnnhTi0y+8xUyXggNs5KVXgE8mRtxi0SX+8r4pVtaxeEjVxZiFCtxXy2if/nW Ro04PyXlhPcQUwu2bqU8+VKNFXnkeb1ZguHvps2qYJC9xKfvrnq4XLb5hME03vRhNZG81EGzL2NjaL6+ot68Z8uT5XPL0DgS3xW6Hfv3QFM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Long Li Lower layer driver may not initialize private data before use. Zero them out to prevent use of stale data. Signed-off-by: Long Li --- drivers/scsi/scsi_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 19125d7..a821593 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1850,7 +1850,7 @@ static int scsi_mq_prep_fn(struct request *req) /* zero out the cmd, except for the embedded scsi_request */ memset((char *)cmd + sizeof(cmd->req), 0, - sizeof(*cmd) - sizeof(cmd->req)); + sizeof(*cmd) - sizeof(cmd->req) + shost->hostt->cmd_size); req->special = cmd; -- 2.7.4