From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754025AbdEKEj7 (ORCPT ); Thu, 11 May 2017 00:39:59 -0400 Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:34092 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751029AbdEKEj5 (ORCPT ); Thu, 11 May 2017 00:39:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3872:4321:5007:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12679:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: army57_569d96d3cb64b X-Filterd-Recvd-Size: 1471 Message-ID: <1494477592.2028.7.camel@perches.com> Subject: Re: [PATCH] FS: Fixing return type of unsigned_offsets From: Joe Perches To: Pushkar Jambhlekar , Al Viro Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 10 May 2017 21:39:52 -0700 In-Reply-To: <1494476871-26474-1-git-send-email-pushkar.iit@gmail.com> References: <1494476871-26474-1-git-send-email-pushkar.iit@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-11 at 09:57 +0530, Pushkar Jambhlekar wrote: > Fixing Sparse warning. It should return bool, instead it returns > int. [] > diff --git a/fs/read_write.c b/fs/read_write.c [] > @@ -33,9 +33,9 @@ const struct file_operations generic_ro_fops = { > > EXPORT_SYMBOL(generic_ro_fops); > > -static inline int unsigned_offsets(struct file *file) > +static inline bool unsigned_offsets(struct file *file) > { > - return file->f_mode & FMODE_UNSIGNED_OFFSET; > + return !!(file->f_mode & FMODE_UNSIGNED_OFFSET); trivia: the !! isn't necessary as by definition all non-zero assigns to bool are converted to 1.