From: Joe Perches <joe@perches.com>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] FS: Fixing return type of unsigned_offsets
Date: Wed, 10 May 2017 21:55:35 -0700 [thread overview]
Message-ID: <1494478535.2028.9.camel@perches.com> (raw)
In-Reply-To: <CAMvNc9AsahXxFsYo91VoW-YLLk9=BFE9j1BK-Bkm_ZQrvsS67w@mail.gmail.com>
On Thu, 2017-05-11 at 10:13 +0530, Pushkar Jambhlekar wrote:
> Should I change my implementation, i.e. remove '!!'?
That'd be up to Al.
At least one implementation using similar bit comparisons
in fs/*.c does not use !!
fs/locks.c:static bool lease_breaking(struct file_lock *fl)
fs/locks.c-{
fs/locks.c- return fl->fl_flags & (FL_UNLOCK_PENDING | FL_DOWNGRADE_PENDING)
fs/locks.c-}
I didn't look very hard.
next prev parent reply other threads:[~2017-05-11 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 4:27 Pushkar Jambhlekar
2017-05-11 4:39 ` Joe Perches
2017-05-11 4:43 ` Pushkar Jambhlekar
2017-05-11 4:55 ` Joe Perches [this message]
2017-05-11 5:04 ` Pushkar Jambhlekar
2017-05-11 6:07 ` Al Viro
2017-05-11 20:09 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494478535.2028.9.camel@perches.com \
--to=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pushkar.iit@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome