From: Baoquan He <bhe@redhat.com>
To: tglx@linutronix.de, keescook@chromium.org, mingo@kernel.org,
m.mizuma@jp.fujitsu.com
Cc: linux-kernel@vger.kernel.org, dyoung@redhat.com,
douly.fnst@cn.fujitsu.com, dan.j.williams@intel.com,
hpa@zytor.com, x86@kernel.org, Baoquan He <bhe@redhat.com>
Subject: [PATCH v5 0/3] Handle memmap and mem kernel options in boot stage kaslr
Date: Sat, 13 May 2017 13:46:27 +0800 [thread overview]
Message-ID: <1494654390-23861-1-git-send-email-bhe@redhat.com> (raw)
People reported kernel panic occurs during system boots up with mem boot option.
After checking code, several problems are found about memmap= and mem= in boot stage
kaslr.
*) In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), only one memmap
entry is considered and only the last one if multiple memmap entries are specified.
*) mem= and memmap=nn[KMG] are not considered yet. They are used to limit max address
of system. Kernel can't be randomized to be above the limit.
*) kernel-parameters.txt doesn't tell the updated behaviour of memmap=.
This patchset tries to solve above issues, and it sits on top of
tip:x86/boot branch.
Changelog
v4->v5:
1. Change patch log according to Thomas's comment.
2. Put "Fall through" to the right place in parse_memmap() according
to Kees's suggestion.
v3->v4:
1. Code improved patch 1/3 according to Kees's suggestion.
2. Add 'Fall through' in switch case of parse_memmap() which
is suggestd by Kees.
v2->v3:
No functionality change in this round.
1. Use local static variable insted of global variable
mem_avoid_memmap_index in patch 1/3.
2. Fix a typo in patch 3/3.
v1->v2:
1. The original patch 1/4 has been put in tip:x86/boot and no update,
so it's not included in this post.
2. Use patch log Ingo reorganized.
3. lib/ctype.c and lib/cmdline.c are needed for kaslr.c, while those
EXPORT_SYMBOL(x) contained caused failure of build on 32-bit allmodconfig:
......
ld: -r and -shared may not be used together
scripts/Makefile.build:294: recipe for target 'arch/x86/boot/compressed/kaslr.o' failed
......
Disabling the symbol exporting removes the build failure.
4. Use dynamic allocation to allocate memory to contain copied kernel cmdline
buffer, it's implemented in include/linux/decompress/mm.h.
Baoquan He (3):
KASLR: Parse all memmap entries in command line
KASLR: Handle memory limit specified by memmap and mem option
Documentation/kernel-parameters.txt: Update 'memmap=' option
description
Documentation/admin-guide/kernel-parameters.txt | 9 ++
arch/x86/boot/compressed/cmdline.c | 2 +-
arch/x86/boot/compressed/kaslr.c | 190 ++++++++++++++++--------
arch/x86/boot/string.c | 8 +
4 files changed, 143 insertions(+), 66 deletions(-)
--
2.5.5
next reply other threads:[~2017-05-13 5:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 5:46 Baoquan He [this message]
2017-05-13 5:46 ` [PATCH v5 1/3] KASLR: Parse all memmap entries in command line Baoquan He
2017-05-24 10:19 ` [tip:x86/boot] x86/KASLR: Parse all 'memmap=' boot option entries tip-bot for Baoquan He
2017-05-13 5:46 ` [PATCH v5 2/3] KASLR: Handle memory limit specified by memmap and mem option Baoquan He
2017-05-16 0:56 ` Dou Liyang
2017-05-16 1:12 ` Baoquan He
2017-05-16 1:43 ` Dou Liyang
2017-05-16 2:37 ` Baoquan He
2017-05-24 10:20 ` [tip:x86/boot] x86/KASLR: Handle the memory limit specified by the 'memmap=' and 'mem=' boot options tip-bot for Baoquan He
2017-05-13 5:46 ` [PATCH v5 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description Baoquan He
2017-05-24 10:20 ` [tip:x86/boot] Documentation/kernel-parameters.txt: Update 'memmap=' boot " tip-bot for Baoquan He
2017-05-15 17:51 ` [PATCH v5 0/3] Handle memmap and mem kernel options in boot stage kaslr Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494654390-23861-1-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®