From: Matej Dujava <mdujava@kocurkovo.cz>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Matej Dujava <mdujava@kocurkovo.cz>
Subject: [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations
Date: Sun, 14 May 2017 00:42:37 +0200 [thread overview]
Message-ID: <1494715362-5545-5-git-send-email-mdujava@kocurkovo.cz> (raw)
In-Reply-To: <1494715362-5545-1-git-send-email-mdujava@kocurkovo.cz>
This patch remove unnecessary operation (eg. ``X | (0x0 << Y)`` to ``X``).
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.h | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
index cef7f46..f9e1614 100644
--- a/drivers/staging/sm750fb/ddk750_display.h
+++ b/drivers/staging/sm750fb/ddk750_display.h
@@ -9,8 +9,8 @@
#define PNL_2_OFFSET 0
#define PNL_2_MASK (3 << PNL_2_OFFSET)
#define PNL_2_USAGE (PNL_2_MASK << 16)
-#define PNL_2_PRI ((0 << PNL_2_OFFSET) | PNL_2_USAGE)
-#define PNL_2_SEC ((2 << PNL_2_OFFSET) | PNL_2_USAGE)
+#define PNL_2_PRI (PNL_2_USAGE)
+#define PNL_2_SEC (PNL_2_USAGE | (2 << PNL_2_OFFSET))
/*
* primary timing & plane enable bit
@@ -20,8 +20,8 @@
#define PRI_TP_OFFSET 4
#define PRI_TP_MASK BIT(PRI_TP_OFFSET)
#define PRI_TP_USAGE (PRI_TP_MASK << 16)
-#define PRI_TP_ON ((0x1 << PRI_TP_OFFSET) | PRI_TP_USAGE)
-#define PRI_TP_OFF ((0x0 << PRI_TP_OFFSET) | PRI_TP_USAGE)
+#define PRI_TP_ON (PRI_TP_USAGE | BIT(PRI_TP_OFFSET))
+#define PRI_TP_OFF (PRI_TP_USAGE)
/*
* panel sequency status
@@ -30,8 +30,8 @@
#define PNL_SEQ_OFFSET 6
#define PNL_SEQ_MASK BIT(PNL_SEQ_OFFSET)
#define PNL_SEQ_USAGE (PNL_SEQ_MASK << 16)
-#define PNL_SEQ_ON (BIT(PNL_SEQ_OFFSET) | PNL_SEQ_USAGE)
-#define PNL_SEQ_OFF ((0 << PNL_SEQ_OFFSET) | PNL_SEQ_USAGE)
+#define PNL_SEQ_ON (PNL_SEQ_USAGE | BIT(PNL_SEQ_OFFSET))
+#define PNL_SEQ_OFF (PNL_SEQ_USAGE)
/*
* dual digital output
@@ -40,8 +40,8 @@
#define DUAL_TFT_OFFSET 8
#define DUAL_TFT_MASK BIT(DUAL_TFT_OFFSET)
#define DUAL_TFT_USAGE (DUAL_TFT_MASK << 16)
-#define DUAL_TFT_ON (BIT(DUAL_TFT_OFFSET) | DUAL_TFT_USAGE)
-#define DUAL_TFT_OFF ((0 << DUAL_TFT_OFFSET) | DUAL_TFT_USAGE)
+#define DUAL_TFT_ON (DUAL_TFT_USAGE | BIT(DUAL_TFT_OFFSET))
+#define DUAL_TFT_OFF (DUAL_TFT_USAGE)
/*
* secondary timing & plane enable bit
@@ -51,8 +51,8 @@
#define SEC_TP_OFFSET 5
#define SEC_TP_MASK BIT(SEC_TP_OFFSET)
#define SEC_TP_USAGE (SEC_TP_MASK << 16)
-#define SEC_TP_ON ((0x1 << SEC_TP_OFFSET) | SEC_TP_USAGE)
-#define SEC_TP_OFF ((0x0 << SEC_TP_OFFSET) | SEC_TP_USAGE)
+#define SEC_TP_ON (SEC_TP_USAGE | BIT(SEC_TP_OFFSET))
+#define SEC_TP_OFF (SEC_TP_USAGE)
/*
* crt path select
@@ -61,8 +61,8 @@
#define CRT_2_OFFSET 2
#define CRT_2_MASK (3 << CRT_2_OFFSET)
#define CRT_2_USAGE (CRT_2_MASK << 16)
-#define CRT_2_PRI ((0x0 << CRT_2_OFFSET) | CRT_2_USAGE)
-#define CRT_2_SEC ((0x2 << CRT_2_OFFSET) | CRT_2_USAGE)
+#define CRT_2_PRI (CRT_2_USAGE)
+#define CRT_2_SEC (CRT_2_USAGE | (0x2 << CRT_2_OFFSET))
/*
* DAC affect both DVI and DSUB
@@ -71,8 +71,8 @@
#define DAC_OFFSET 7
#define DAC_MASK BIT(DAC_OFFSET)
#define DAC_USAGE (DAC_MASK << 16)
-#define DAC_ON ((0x0 << DAC_OFFSET) | DAC_USAGE)
-#define DAC_OFF ((0x1 << DAC_OFFSET) | DAC_USAGE)
+#define DAC_ON (DAC_USAGE)
+#define DAC_OFF (DAC_USAGE | BIT(DAC_OFFSET))
/*
* DPMS only affect D-SUB head
@@ -81,8 +81,8 @@
#define DPMS_OFFSET 9
#define DPMS_MASK (3 << DPMS_OFFSET)
#define DPMS_USAGE (DPMS_MASK << 16)
-#define DPMS_ON ((0 << DPMS_OFFSET) | DPMS_USAGE)
-#define DPMS_OFF ((3 << DPMS_OFFSET) | DPMS_USAGE)
+#define DPMS_ON (DPMS_USAGE)
+#define DPMS_OFF (DPMS_USAGE | (0x3 << DPMS_OFFSET))
/*
* LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
--
1.8.3.1
next prev parent reply other threads:[~2017-05-13 22:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 22:42 [PATCH 0/9] staging: sm750fb: cleaning code Matej Dujava
2017-05-13 22:42 ` [PATCH 1/9] staging: sm750fb: fix length of lines Matej Dujava
2017-05-15 8:32 ` Dan Carpenter
2017-05-13 22:42 ` [PATCH 2/9] staging: sm750fb: unifying macro definitions Matej Dujava
2017-05-13 22:42 ` [PATCH 3/9] staging: sm750fb: reordering of " Matej Dujava
2017-05-15 10:20 ` Greg KH
2017-05-13 22:42 ` Matej Dujava [this message]
2017-05-15 10:21 ` [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations Greg KH
2017-05-13 22:42 ` [PATCH 5/9] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 6/9] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 7/9] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 8/9] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 9/9] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava
2017-05-15 10:22 ` [PATCH 0/9] staging: sm750fb: cleaning code Greg KH
2017-05-15 21:54 ` [PATCH v2 0/7] " Matej Dujava
2017-05-16 9:20 ` [PATCH v3 " Matej Dujava
2017-05-16 11:34 ` Greg KH
2017-05-16 9:20 ` [PATCH v3 1/7] staging: sm750fb: fix length of lines, function calls and declaration Matej Dujava
2017-05-16 9:20 ` [PATCH v3 2/7] staging: sm750fb: unifying macro usage and definitions Matej Dujava
2017-05-18 13:56 ` Greg KH
2017-06-13 7:40 ` Matej Dujava
2017-05-16 9:20 ` [PATCH v3 3/7] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 4/7] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 5/7] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 6/7] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 7/7] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 1/7] staging: sm750fb: fix length of lines, function calls and declaration Matej Dujava
2017-05-15 21:54 ` [PATCH v2 2/7] staging: sm750fb: unifying macro usage and definitions Matej Dujava
2017-05-15 21:54 ` [PATCH v2 3/7] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 4/7] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 5/7] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 6/7] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 7/7] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494715362-5545-5-git-send-email-mdujava@kocurkovo.cz \
--to=mdujava@kocurkovo.cz \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®