From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760207AbdEOITb (ORCPT ); Mon, 15 May 2017 04:19:31 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:35284 "EHLO andre.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760053AbdEOITY (ORCPT ); Mon, 15 May 2017 04:19:24 -0400 From: Geert Uytterhoeven To: Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto Cc: Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/2] ALSA: firewire-tascam: Use do { } while for loops executed at least once Date: Mon, 15 May 2017 10:19:10 +0200 Message-Id: <1494836350-28790-2-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1494836350-28790-1-git-send-email-geert@linux-m68k.org> References: <1494836350-28790-1-git-send-email-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a loop is intended to be executed at least once, it is better to use "do { ... } while (...)" instead of "while (...) { ... }". The former is easier to understand for the casual reviewer, and doesn't require preinitializing the canary variable. Signed-off-by: Geert Uytterhoeven --- Compile-tested only. --- sound/firewire/tascam/tascam-stream.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/firewire/tascam/tascam-stream.c b/sound/firewire/tascam/tascam-stream.c index e433b92ac6904db5..4ea6845aae87fdef 100644 --- a/sound/firewire/tascam/tascam-stream.c +++ b/sound/firewire/tascam/tascam-stream.c @@ -80,17 +80,17 @@ static int set_clock(struct snd_tscm *tscm, unsigned int rate, int snd_tscm_stream_get_rate(struct snd_tscm *tscm, unsigned int *rate) { - u32 data = 0x0; unsigned int trials = 0; + u32 data; int err; - while (data == 0x0 && trials++ < 5) { + do { err = get_clock(tscm, &data); if (err < 0) return err; data = (data & 0xff000000) >> 24; - } + } while (data == 0x0 && ++trials < 5); /* Check base rate. */ if ((data & 0x0f) == 0x01) -- 2.7.4