mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, boris.ostrovsky@oracle.com,
	Stefano Stabellini <stefano@aporeto.com>
Subject: [PATCH 04/18] xen/pvcalls: xenbus state handling
Date: Mon, 15 May 2017 13:35:56 -0700	[thread overview]
Message-ID: <1494880570-14209-4-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1494880570-14209-1-git-send-email-sstabellini@kernel.org>

Introduce the code to handle xenbus state changes.

Implement the probe function for the pvcalls backend. Write the
supported versions, max-page-order and function-calls nodes to xenstore,
as required by the protocol.

Introduce stub functions for disconnecting/connecting to a frontend.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 133 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 133 insertions(+)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 46a889a..86eca19 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -25,6 +25,9 @@
 #include <xen/xenbus.h>
 #include <xen/interface/io/pvcalls.h>
 
+#define PVCALLS_VERSIONS "1"
+#define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
+
 struct pvcalls_ioworker {
 	struct work_struct register_work;
 	atomic_t io;
@@ -45,15 +48,145 @@ static void pvcalls_back_ioworker(struct work_struct *work)
 {
 }
 
+static int backend_connect(struct xenbus_device *dev)
+{
+	return 0;
+}
+
+static int backend_disconnect(struct xenbus_device *dev)
+{
+	return 0;
+}
+
 static int pvcalls_back_probe(struct xenbus_device *dev,
 			      const struct xenbus_device_id *id)
 {
+	int err;
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "versions", "%s",
+			    PVCALLS_VERSIONS);
+	if (err) {
+		pr_warn("%s write out 'version' failed\n", __func__);
+		return -EINVAL;
+	}
+
+	err = xenbus_printf(XBT_NIL, dev->nodename, "max-page-order", "%u",
+			    MAX_RING_ORDER);
+	if (err) {
+		pr_warn("%s write out 'max-page-order' failed\n", __func__);
+		return -EINVAL;
+	}
+
+	/* "1" means socket, connect, release, bind, listen, accept and poll*/
+	err = xenbus_printf(XBT_NIL, dev->nodename, "function-calls", "1");
+	if (err) {
+		pr_warn("%s write out 'function-calls' failed\n", __func__);
+		return -EINVAL;
+	}
+
+	err = xenbus_switch_state(dev, XenbusStateInitWait);
+	if (err)
+		return err;
+
 	return 0;
 }
 
+static void set_backend_state(struct xenbus_device *dev,
+			      enum xenbus_state state)
+{
+	while (dev->state != state) {
+		switch (dev->state) {
+		case XenbusStateClosed:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateConnected:
+				xenbus_switch_state(dev, XenbusStateInitWait);
+				break;
+			case XenbusStateClosing:
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateInitWait:
+		case XenbusStateInitialised:
+			switch (state) {
+			case XenbusStateConnected:
+				backend_connect(dev);
+				xenbus_switch_state(dev, XenbusStateConnected);
+				break;
+			case XenbusStateClosing:
+			case XenbusStateClosed:
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateConnected:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateClosing:
+			case XenbusStateClosed:
+				down_write(&pvcalls_back_global.privs_lock);
+				backend_disconnect(dev);
+				up_write(&pvcalls_back_global.privs_lock);
+				xenbus_switch_state(dev, XenbusStateClosing);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		case XenbusStateClosing:
+			switch (state) {
+			case XenbusStateInitWait:
+			case XenbusStateConnected:
+			case XenbusStateClosed:
+				xenbus_switch_state(dev, XenbusStateClosed);
+				break;
+			default:
+				__WARN();
+			}
+			break;
+		default:
+			__WARN();
+		}
+	}
+}
+
 static void pvcalls_back_changed(struct xenbus_device *dev,
 				 enum xenbus_state frontend_state)
 {
+	switch (frontend_state) {
+	case XenbusStateInitialising:
+		set_backend_state(dev, XenbusStateInitWait);
+		break;
+
+	case XenbusStateInitialised:
+	case XenbusStateConnected:
+		set_backend_state(dev, XenbusStateConnected);
+		break;
+
+	case XenbusStateClosing:
+		set_backend_state(dev, XenbusStateClosing);
+		break;
+
+	case XenbusStateClosed:
+		set_backend_state(dev, XenbusStateClosed);
+		if (xenbus_dev_is_online(dev))
+			break;
+		/* fall through if not online */
+	case XenbusStateUnknown:
+		set_backend_state(dev, XenbusStateClosed);
+		device_unregister(&dev->dev);
+		break;
+
+	default:
+		xenbus_dev_fatal(dev, -EINVAL, "saw state %d at frontend",
+				 frontend_state);
+		break;
+	}
 }
 
 static int pvcalls_back_remove(struct xenbus_device *dev)
-- 
1.9.1

  parent reply	other threads:[~2017-05-15 20:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 20:35 [PATCH 00/18] introduce the Xen PV Calls backend Stefano Stabellini
2017-05-15 20:35 ` [PATCH 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-05-15 20:35   ` [PATCH 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-05-15 20:35   ` [PATCH 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-05-16  1:28     ` Boris Ostrovsky
2017-05-16 20:05       ` Stefano Stabellini
2017-05-16 20:22         ` Stefano Stabellini
2017-05-16  6:40     ` Juergen Gross
2017-05-16 19:58       ` Stefano Stabellini
2017-05-17  5:21         ` Juergen Gross
2017-05-18 21:18           ` Stefano Stabellini
2017-05-19 22:33             ` Stefano Stabellini
2017-05-15 20:35   ` Stefano Stabellini [this message]
2017-05-16  1:34     ` [PATCH 04/18] xen/pvcalls: xenbus state handling Boris Ostrovsky
2017-05-16 20:11       ` Stefano Stabellini
2017-05-15 20:35   ` [PATCH 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-05-16  1:52     ` Boris Ostrovsky
2017-05-16 20:23       ` Stefano Stabellini
2017-05-16 20:38         ` Stefano Stabellini
2017-05-15 20:35   ` [PATCH 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini
2017-05-16  2:06     ` Boris Ostrovsky
2017-05-16 20:57       ` Stefano Stabellini
2017-05-15 20:35   ` [PATCH 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-05-16  2:12     ` Boris Ostrovsky
2017-05-16 20:45       ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-05-16  2:36     ` Boris Ostrovsky
2017-05-16 21:02       ` Stefano Stabellini
2017-05-16 21:56         ` Boris Ostrovsky
2017-05-18 19:10           ` Stefano Stabellini
2017-05-18 20:19             ` Boris Ostrovsky
2017-05-15 20:36   ` [PATCH 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-05-15 20:36   ` [PATCH 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-05-15 20:36   ` [PATCH 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-05-15 20:36   ` [PATCH 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-05-15 20:36   ` [PATCH 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-05-15 20:36   ` [PATCH 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-05-15 20:36   ` [PATCH 15/18] xen/pvcalls: introduce the ioworker Stefano Stabellini
2017-05-15 20:36   ` [PATCH 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-05-15 20:36   ` [PATCH 17/18] xen/pvcalls: implement write Stefano Stabellini
2017-05-15 20:36   ` [PATCH 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494880570-14209-4-git-send-email-sstabellini@kernel.org \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano@aporeto.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome