From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: christoffer.dall@linaro.org
Cc: agraf@suse.de, andreyknvl@google.com, marc.zyngier@arm.com,
mark.rutland@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com,
suzuki.poulose@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Christoffer Dall <cdall@linaro.org>
Subject: [PATCH v3 1/2] kvm: arm/arm64: Force reading uncached stage2 PGD
Date: Tue, 16 May 2017 10:34:54 +0100 [thread overview]
Message-ID: <1494927295-29369-2-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1494927295-29369-1-git-send-email-suzuki.poulose@arm.com>
Make sure we don't use a cached value of the KVM stage2 PGD while
resetting the PGD.
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
virt/kvm/arm/mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c
index 909a1a7..704e35f 100644
--- a/virt/kvm/arm/mmu.c
+++ b/virt/kvm/arm/mmu.c
@@ -837,7 +837,7 @@ void kvm_free_stage2_pgd(struct kvm *kvm)
spin_lock(&kvm->mmu_lock);
if (kvm->arch.pgd) {
unmap_stage2_range(kvm, 0, KVM_PHYS_SIZE);
- pgd = kvm->arch.pgd;
+ pgd = READ_ONCE(kvm->arch.pgd);
kvm->arch.pgd = NULL;
}
spin_unlock(&kvm->mmu_lock);
--
2.7.4
next prev parent reply other threads:[~2017-05-16 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:34 [PATCH v3 0/2] kvm: arm/arm64: Fixes for race conditions Suzuki K Poulose
2017-05-16 9:34 ` Suzuki K Poulose [this message]
2017-05-16 9:34 ` [PATCH v3 2/2] kvm: arm/arm64: Fix use after free of stage2 page table Suzuki K Poulose
2017-05-16 9:53 ` [PATCH v3 0/2] kvm: arm/arm64: Fixes for race conditions Christoffer Dall
2017-05-16 10:01 ` Suzuki K Poulose
2017-05-16 13:29 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494927295-29369-2-git-send-email-suzuki.poulose@arm.com \
--to=suzuki.poulose@arm.com \
--cc=agraf@suse.de \
--cc=andreyknvl@google.com \
--cc=cdall@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®