From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbdEQA3H (ORCPT ); Tue, 16 May 2017 20:29:07 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33965 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbdEQA3F (ORCPT ); Tue, 16 May 2017 20:29:05 -0400 From: Myungho Jung To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fs: fix utimensat to return correct error code Date: Tue, 16 May 2017 17:28:55 -0700 Message-Id: <1494980935-6926-1-git-send-email-mhjungk@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to man utimensat(2), EACCES should be returned if the file is immutable and time values are null or UTIME_NOW. Testcase is utimesat01/LTP. Signed-off-by: Myungho Jung --- fs/attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/attr.c b/fs/attr.c index 1353041..4c06aae 100644 --- a/fs/attr.c +++ b/fs/attr.c @@ -222,7 +222,7 @@ int notify_change(struct dentry * dentry, struct iattr * attr, struct inode **de */ if (ia_valid & ATTR_TOUCH) { if (IS_IMMUTABLE(inode)) - return -EPERM; + return -EACCES; if (!inode_owner_or_capable(inode)) { error = inode_permission(inode, MAY_WRITE); -- 2.7.4