From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754058AbdEQPeX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 17 May 2017 11:34:23 -0400
Received: from smtp.nsa.gov ([8.44.101.8]:55219 "EHLO emsm-gh1-uea10.nsa.gov"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752721AbdEQPeT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 May 2017 11:34:19 -0400
X-IronPort-AV: E=Sophos;i="5.38,355,1491264000"; 
   d="scan'208";a="7154921"
IronPort-PHdr: =?us-ascii?q?9a23=3ACa6TAxJEmo9qPk++tNmcpTZWNBhigK39O0sv0rFi?=
 =?us-ascii?q?tYgXKPjzrarrMEGX3/hxlliBBdydsKMbzbOJ+PC/EUU7or+5+EgYd5JNUxJXwe?=
 =?us-ascii?q?43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRp?=
 =?us-ascii?q?OOv1BpTSj8Oq3Oyu5pHfeQtFiT6/bL9oMRm7rwrdu8oUjIB/Nqs/1xzFr2dSde?=
 =?us-ascii?q?9L321oP1WTnxj95se04pFu9jlbtuwi+cBdT6j0Zrw0QrNEAjsoNWA1/9DrugLY?=
 =?us-ascii?q?TQST/HscU34ZnQRODgPY8Rz1RJbxsi/9tupgxCmXOND9QL4oVTi+6apgVQTlgz?=
 =?us-ascii?q?kbOTEn7G7Xi9RwjKNFrxKnuxx/2JPfbIWMOPZjYq/RYdYWSGxPUcZLUyxKH52y?=
 =?us-ascii?q?YY0BAeEcOepUtpfxq0cLoRa4GAKiBv7gyiVQi3H1wKM00/ovHw/E0wwuGNIBrH?=
 =?us-ascii?q?Pao9r6OqoJTeC4z7PFwSnZYv9K2zrw7pXDfBA7ofGLWLJ9adffyVUxGAPdjlWf?=
 =?us-ascii?q?t4rlNC6I2OQIqWeb6+5gWvyvimU6rAxxuSWgxtw3h4nVhoMa1lDE9SJjzIYzPt?=
 =?us-ascii?q?23UlR3YdGjEJtOriyXMZZ9TMA6Q2xwpSo3xbILtYS7cSQX0pgr2RHSZ+Kdf4SV?=
 =?us-ascii?q?5B/oSfyfLi1ihH1/fbKynxOy8U+9xeLiTsS0y1NKrjZdktnLq3ANywTf6siZRf?=
 =?us-ascii?q?t5+UeswSqP2BrJ6uFFPEA0jrDXK4Ihw7EslpoTtl7PHinql0XtkKCabEAk+ums?=
 =?us-ascii?q?6+j/Y7XmoIGTN5Nshw3jPakjldazDOQlPgQUQWSW9vqw2Kf+8UHhRbVFlPw2kq?=
 =?us-ascii?q?3XsJDAIsQbo7a0AxRI3YY48Bu/Ezen38gYnXkANl5FfgmHgJLzN1HBJ/D4E++z?=
 =?us-ascii?q?g06wnzdz2/DGIrrhD43WLnfYjbfhfK1961VbyAo11t1Q+o9bCrcbLP3vXU/xsc?=
 =?us-ascii?q?TSDgUlPAys3+bnFNJ925sGWW2VH6+ZNLjfsUeS6eIyJ+mAfYoVuDH6K/g/+fHi?=
 =?us-ascii?q?l2M2mVgYfaOxx5sYdGi4Huh6I0WeeXfjnM8BHn0Qvgo/V+znk0WCXiRJZ3azRK?=
 =?us-ascii?q?I8/jU7B5i6AojdXIyth6aB3CijFJ1Mem9GEkyMEWvvd4icWfcDcieSLdF6kjAe?=
 =?us-ascii?q?UbitUYoh1Ra0tA/gyrpnNfHZ+ioCtZ35yNd14/PcmQsu+jxzCsSXy3uNQH1snm?=
 =?us-ascii?q?MUWz8227hyoVdjxVeZ3qh3nedVFdxJ6PNNVgc7NZjcw/ZmBND1XwLLZs2JR0q+?=
 =?us-ascii?q?QtW6HTExSco8w9sPY0Z7BtWjgQnP3ym0DL8PkbyEGpg0/7nC33j+Ocl90WzK1K?=
 =?us-ascii?q?o/gFk8RMtAK2mmirR49wjJCI7Di1+ZmLqydaQAwC7N83+OzW6PvEFeTQ5xXrzJ?=
 =?us-ascii?q?XWsBaUTKsNT5/ELCT6OuCLg+NwtBztONKrZOatL3llhGWvjjN8rEY26rmGe/Gw?=
 =?us-ascii?q?yIxrWSY4ruYWkd2z/dCEccmQAJ4XmGLRQ+Bjumo2/GFzxhDk/vY0L38ellr3O7?=
 =?us-ascii?q?SFU4wByXYE1nzLe19RsViuadS/MXxL4LpCAhqzAnVGq6iunbAdObuwtseu12fN?=
 =?us-ascii?q?Im+1BBnTbCvRF8JYenKeZuilg2fAF+vkeo3BJyXNZui88v+Ug2wRJyJKTQ61ZI?=
 =?us-ascii?q?czeVzNikIbHMAnXj9xCoLajN0xfR18jAqfRH0+gxt1i25FLhLUEl6XgyloAPi3?=
 =?us-ascii?q?Y=3D?=
X-IPAS-Result: =?us-ascii?q?A2GSAgAhbBxZ/wHyM5BcGwEBAQMBAQEJAQEBFwEBBAEBCgE?=
 =?us-ascii?q?BgwEpgW6DbZpMAQEBAQEBBoEmmASGJAKFW1cBAQEBAQEBAQIBAmgogjMkAYJBA?=
 =?us-ascii?q?QUjDwFGEAkCDQEKAgImAgJXBhOIB4IPDY8knWCCJiYCil0BAQEBAQUBAQEBASO?=
 =?us-ascii?q?BC4UOhT+HdYJgAQSeEJMbixqGU5RGWIEKJgkCHggfD4dYJDaIaAEBAQ?=
Message-ID: <1495035491.32535.6.camel@tycho.nsa.gov>
Subject: Re: [PATCH v5 1/2] selinux: add brief info to policydb
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Sebastien Buisson <sbuisson.ddn@gmail.com>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org,
        selinux@tycho.nsa.gov, serge@hallyn.com, james.l.morris@oracle.com,
        Eric Paris <eparis@parisplace.org>, Paul Moore <paul@paul-moore.com>,
        Sebastien Buisson <sbuisson@ddn.com>
Date: Wed, 17 May 2017 11:38:11 -0400
In-Reply-To: <CAPkE-bWykonYBssXGphktM7jANY_nbtQi7EVc4uLwjm-fdM8Kg@mail.gmail.com>
References: <1494928281-11128-1-git-send-email-sbuisson@ddn.com>
         <1494967240.21557.18.camel@tycho.nsa.gov>
         <CAPkE-bWykonYBssXGphktM7jANY_nbtQi7EVc4uLwjm-fdM8Kg@mail.gmail.com>
Organization: National Security Agency
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-05-17 at 16:59 +0200, Sebastien Buisson wrote:
> 2017-05-16 22:40 GMT+02:00 Stephen Smalley <sds@tycho.nsa.gov>:
> > > +     strcpy(*brief, policydb.policybrief);
> > > +     /* *len is the length of the output string */
> > > +     *len = policybrief_len - 1;
> > 
> > Is there a particular reason to not just return policybrief_len
> > here as
> > well, for consistency in the interface?  How do you intend to use
> > this
> > value in the caller?
> 
> As called in the other patch to expose policy brief via selinuxfs
> (sel_read_policybrief), the intent is to provide the caller with the
> length of the string returned.
> Or should I set *len to policy brief_len here, and just make the
> caller aware that the returned length is in fact the length of the
> buffer (i.e. including terminating NUL byte)?

Looking at the caller usage in the other patch, I guess it makes sense
in its current form.