From: Masami Hiramatsu <mhiramat@kernel.org>
To: Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/6] um: Use printk instead of printf in make_uml_dir
Date: Thu, 18 May 2017 02:14:57 +0900 [thread overview]
Message-ID: <149504128715.2543.10601605976866434403.stgit@devbox> (raw)
In-Reply-To: <149504121868.2543.16105153409840504430.stgit@devbox>
Since this function will be called after printk buffer
initialized, use printk as other functions do.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
Changes in v2:
- Use "%s", __func__ according to checkpatches.pl
---
arch/um/os-Linux/umid.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/um/os-Linux/umid.c b/arch/um/os-Linux/umid.c
index c1dc892..37cfaba 100644
--- a/arch/um/os-Linux/umid.c
+++ b/arch/um/os-Linux/umid.c
@@ -35,8 +35,9 @@ static int __init make_uml_dir(void)
err = -ENOENT;
if (home == NULL) {
- printk(UM_KERN_ERR "make_uml_dir : no value in "
- "environment for $HOME\n");
+ printk(UM_KERN_ERR
+ "%s: no value in environment for $HOME\n",
+ __func__);
goto err;
}
strlcpy(dir, home, sizeof(dir));
@@ -50,13 +51,15 @@ static int __init make_uml_dir(void)
err = -ENOMEM;
uml_dir = malloc(strlen(dir) + 1);
if (uml_dir == NULL) {
- printf("make_uml_dir : malloc failed, errno = %d\n", errno);
+ printk(UM_KERN_ERR "%s : malloc failed, errno = %d\n",
+ __func__, errno);
goto err;
}
strcpy(uml_dir, dir);
if ((mkdir(uml_dir, 0777) < 0) && (errno != EEXIST)) {
- printf("Failed to mkdir '%s': %s\n", uml_dir, strerror(errno));
+ printk(UM_KERN_ERR "Failed to mkdir '%s': %s\n",
+ uml_dir, strerror(errno));
err = -errno;
goto err_free;
}
next prev parent reply other threads:[~2017-05-17 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 17:13 [PATCH v3 0/6] um: Output messages to stderr and support quiet option Masami Hiramatsu
2017-05-17 17:14 ` Masami Hiramatsu [this message]
2017-05-17 17:16 ` [PATCH v3 2/6] um: Add os_info() for pre-boot information messages Masami Hiramatsu
2017-05-17 17:17 ` [PATCH v3 3/6] um: Use os_info for the messages on normal path Masami Hiramatsu
2017-05-17 17:18 ` [PATCH v3 4/6] um: Add os_warn() for pre-boot warning/error messages Masami Hiramatsu
2017-05-17 17:19 ` [PATCH v3 5/6] um: Use os_warn to print out " Masami Hiramatsu
2017-05-17 17:20 ` [PATCH v3 6/6] um: console: Ignore console= option Masami Hiramatsu
2017-07-05 21:25 ` [PATCH v3 0/6] um: Output messages to stderr and support quiet option Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149504128715.2543.10601605976866434403.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome