From: Frank Wang <frank.wang@rock-chips.com>
To: heiko@sntech.de, kishon@ti.com, william.wu@rock-chips.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, charles.chen@rock-chips.com,
cody.xie@rock-chips.com, kevan.lan@rock-chips.com,
huangtao@rock-chips.com, wmc@rock-chips.com,
Frank Wang <frank.wang@rock-chips.com>
Subject: [PATCH 2/4] phy: rockchip-inno-usb2: increase otg sm work first schedule time
Date: Thu, 18 May 2017 11:43:00 +0800 [thread overview]
Message-ID: <1495078982-2555-3-git-send-email-frank.wang@rock-chips.com> (raw)
In-Reply-To: <1495078982-2555-1-git-send-email-frank.wang@rock-chips.com>
From: William Wu <william.wu@rock-chips.com>
In rockchip-inno-usb2 phy driver, we use otg_sm_work to
dynamically manage power consumption for phy otg-port.
If the otg-port works as peripheral mode and does not
communicate with usb host, we will suspend phy.
But once suspend phy, the phy no longer has any internal
clock running, include the utmi_clk which supplied for
usb controller. So if we suspend phy before usb controller
init, it will cause usb controller fail to initialize.
Specifically, without this patch, the observed order is:
1. unplug usb cable
2. start system, do dwc2 controller probe
3. dwc2_lowlevel_hw_enable()
- phy_init()
- rockchip_usb2phy_init()
- schedule otg_sm_work after 2s
put phy in suspend, and close utmi_clk
4. dwc2_hsotg_udc_start() - fail to initialize the usb core
Generally, dwc2_hsotg_udc_start() can be called within 5s
after start system on Rockchip platform, so we increase the
the first schedule delay time to 6s for otg_sm_work afer usb
controller calls phy_init(), this can make sure that the usb
controller completes initialization before phy enter suspend.
Signed-off-by: William Wu <william.wu@rock-chips.com>
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
drivers/phy/phy-rockchip-inno-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c
index f12dc8d..d6e459d 100644
--- a/drivers/phy/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/phy-rockchip-inno-usb2.c
@@ -421,7 +421,7 @@ static int rockchip_usb2phy_init(struct phy *phy)
goto out;
schedule_delayed_work(&rport->otg_sm_work,
- OTG_SCHEDULE_DELAY);
+ OTG_SCHEDULE_DELAY * 3);
} else {
/* If OTG works in host only mode, do nothing. */
dev_dbg(&rport->phy->dev, "mode %d\n", rport->mode);
--
2.0.0
next prev parent reply other threads:[~2017-05-18 3:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 3:42 [PATCH 0/4] fix some issues for Rockchip usb2-phy and add rk322x SoCs' support Frank Wang
2017-05-18 3:42 ` [PATCH 1/4] phy: rockchip-inno-usb2: add a delay after phy resume Frank Wang
2017-05-18 3:43 ` Frank Wang [this message]
2017-05-18 3:43 ` [PATCH 3/4] phy: rockchip-inno-usb2: add one phy comprises with two host-ports support Frank Wang
2017-05-18 3:43 ` [PATCH 4/4] phy: rockchip-inno-usb2: add support of usb2-phy for rk322x SoCs Frank Wang
2017-06-01 20:18 ` Heiko Stuebner
2017-06-02 1:42 ` Frank Wang
2017-05-25 7:25 ` [PATCH 0/4] fix some issues for Rockchip usb2-phy and add rk322x SoCs' support Frank Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495078982-2555-3-git-send-email-frank.wang@rock-chips.com \
--to=frank.wang@rock-chips.com \
--cc=charles.chen@rock-chips.com \
--cc=cody.xie@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kevan.lan@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=william.wu@rock-chips.com \
--cc=wmc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®