From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754567AbdESNtL (ORCPT ); Fri, 19 May 2017 09:49:11 -0400 Received: from mail-by2nam01on0066.outbound.protection.outlook.com ([104.47.34.66]:28222 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753536AbdESNtH (ORCPT ); Fri, 19 May 2017 09:49:07 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=fail action=none header.from=nxp.com; From: Dong Aisheng To: CC: , , , , , , , , , , , , , , , , , , , Subject: [PATCH V3 0/3] clk: introduce clk_bulk_get accessories Date: Fri, 19 May 2017 21:49:03 +0800 Message-ID: <1495201746-31841-1-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131396753446390403;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39840400002)(39860400002)(39400400002)(39450400003)(39410400002)(39380400002)(39850400002)(2980300002)(1110001)(1109001)(339900001)(54534003)(189002)(199003)(9170700003)(7416002)(54906002)(6306002)(104016004)(38730400002)(48376002)(5660300001)(50466002)(53936002)(33646002)(2906002)(50986999)(110136004)(36756003)(2351001)(106466001)(498600001)(8656002)(966005)(4326008)(8676002)(50226002)(81166006)(6916009)(6666003)(189998001)(8936002)(105606002)(47776003)(356003)(39060400002)(86362001)(77096006)(5003940100001)(305945005)(85426001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB161;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD045;1:5ja3pk3auM+ZnSWGrgIUnR8gzFPLGJbadW1N1DAyhpmEvIEWGc6B2L4Dv2lGa6l08unvUv3ILQRMPaT1N30NTersnojFc8QtkncmgPizycip1/qzvG0tjqu4/qBGCPXWDXuTMqXth6Oo9oOtbFR1CzNTBwyQkp2bemdwFYAYF5IOM33JulsM7AycIQaAo/kuEuF0TsKco995XAZvtoQwYQEeUdnVJ+atMGunfk0x871yF0J/rdkGDWvkxF8KCfgwAKYcQxWCpysH8zyPJL2kyTuMF3O7F6mO9gf5O08mvsWhLayERQw5mQkz18UPs1rlHehl45sawDlzMENoNs40UeTLLEmdBMRZ1DnloHhuQP8uy5kNOidOs1BjwkHH/f3WAhcGd80qJWEq7rzQY4Ms6DCB91H4e4RiDHa9h5yPXXZ6heFE6Z0WX6vq7uR7R+B7sKpnojWjyjIivbjl4Ttam2qfkqRU8T7x9ci++hk3N/uREs6BJ7r9UAqAifOLMQk27PBZY5/6qCkBs6WZazbTU4PnmSsC8qusK+qVm1OVWSNvxobQzf8808kl5ZQoZ5CUExAZFsmhOCoBZwYXlh6PlWaPpcOz9FbjY9eT4evGbpHzemYUXIxDSGduSRe/atyC MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL2PR03MB161: X-MS-Office365-Filtering-Correlation-Id: 0a5c2024-f41e-461c-ca83-08d49ebdd046 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BL2PR03MB161; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB161;3:CDHPZRCeAu3qGGw6bTm2bHwnVF5Zp5LYpLllZQVDAxL0YSJOuRNycuk68kRLHtDLB7dQTGcMHaERMLdA8ikKRXd38KVQn9cznUJ8aEsT7tD9DJkT5Nc3VanbEQQaIBNSunNKNYJQkH+CA0sEHi7bVrkEn3mvLGmsdCrbkUhhRKtVQ1PSWW0GZACW6mmeQ2YC+J9h99yZk3BMtY/kzuKfYct3UgP3rGrsjjN+eD1+4TeBUZnk04/UggbSNb5Fz1o0UKnn8Xbf5FjsDmv+5oYD/fwnUXv+s7DFyTVewvor/dY3jUMVyXc2XjrRtUjBiQ4xeLDmAvvINrevyTF0klGEX0RA5FUzBCk1kRZ4Rqh8+Pbyzptjv1tbSlv79TtHvF3WFeUysEkZLa3H9WSfyaLNoPt1kHSZLZiva4IhTM8freracUnHtGNjBCfRn6ky9J8V;25:2wfueKi/G/MGntJ5mi/cePa41dsazzU7MeZRBfQb7GShHHBGtAhHWx7bwH72+fujvauUItwK2MXPi/dSyYaQHZeDMrMUZn6ybRri6/6V+KkQl25tI3a4+QXZhWLRCoSHfKgWqlHPPu5OXQZQuCBz3/IKlTRrDIWAv+7aSM5vCeeFl8+1QVCX2Nri3optK8naHq9Y+oPu5cRszGEPjFUIduUx8Yonp+/sXYz+WghGLRbSaoyPzBEQmRIXek6eIpI64r/EwPVFDwC6+1/6l9EwkGKE7uu5gVYnP50NS/bE9dlXVzCax7lAWmffP9mPSL36BrW2TsPHYmX+qOtgnB5lOx0JOJurBgJLMK7b20pFm6GG7poXLMy7kay2k0y1hrziVYqCMQVsVMBUwdDtmeE3TTVpn790EWN7ewyUbuaOODBvEwUNlXhEnlqq9AThh9F/07A5dXpTM+REs3vUj/B/iJzgIJ0ry1OEOob/3S6hrP4= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB161;31:9l9zE02rFtaC+XYteBQ1Lv2RfbANYZnIp6RVWq/YeLvwGNRUZa0Z44kv5qG0UbkRFxg10UDt3EPO3McNlqrLieRnqSEqvugIfvnYiQzq4Sdc+RA7/Ojke2APfHiB0/GFarg45EiDkSxOyFvSNJhke6sC51kjB6xyIN3iExnvmUFSLlJGupCsVKIG+1v7Dt77yaWvN1fhrusMx66zAbhtp72MNFcjrQs38hdoeL/gle7ezv60Q9HOCtk4stA8QuXPAwt4hezFNT3VVsb6+/bdaQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13024025)(13023025)(8121501046)(13018025)(13015025)(5005006)(13017025)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123565025)(20161123556025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123561025)(20161123563025);SRVR:BL2PR03MB161;BCL:0;PCL:0;RULEID:(400006);SRVR:BL2PR03MB161; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB161;4:JHctVvHtQCHPtQkOAhnUPyDsj9XULb1FVbbkN0JD4qBOO6PgtELXcOKI0GUrF9lYQX8CxZif2XdthsEp4ttVKKaWXGuyvWMRzyy5G67TLnYYlL0ypud6pUKN+L7vZfxQevd51dYrrK/lIYH57ie2pe2n1su0+DfffH9gG6dfU1i0YG4jKlze73WsRAi5awU2dVCtZeJzW/rQzXssvHNgfjZcVA+mE+HS4cNAULMpGVn62S9Z7QoxUflm7Trl7VnGjIND0Y+aWyRfzbNPhx7jeDegTvYBgU0TLVpUEtFat7W2bsAIMhi7EAk5YFV6Un+IJq3L+HCggN3S6kcKArFtE8h2y1EklLNk3I3pxviXY/9d291lFmZ5ugq+BObwRiBy0TIyft7gb2ec5NLWMVt+t8/odJw70IPaoMh9v9nc0zazJiQiSJO82GE/Dsvqqe+weVIuviF70F12LDSahpJ02U/xyuEEj6n8rLFMEHhuB186u8k67BoJg8mbn4r3vweDtqf3NeHi2YVYoFo+Og22Us/RZxUmh9V/ZS3+jtyZ0AQ6e33vebsnQ3RdSUUahZd60UIq7OHj51/oWgpuVXkk1n329/Nzi08bT4/iEwivXPndsazmdYFc7Rr5kjAcX+lGwLj1SueIh2N5ND7HWtW74b4haVXqIxJPsBMgWlNNdAnqwQA3ukokmYvorUWF68IiRjGOewxeJDaiieAjEr4EtDb3PRjoqaXNr9D85O0YRDPU0KPvzn3RVB/KIADGp1/XxziG69rlj8Nk8FlJPmE2vZGWRTDHqjWxLmJZ40MK6dq0wsRe9d03uQMQf+UCOVvOeLDaeRr8rcIG025QKgiHJd4dtLOwHYrEjT8EWmCi0e3/dbxf4dgms8WF+gH4R2yZZC6PGozZCKSRb32mDr4KxdJ95UCdfSk7ui75mCVT2EY= X-Forefront-PRVS: 031257FE13 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB161;23:vy4j4Z7ckzHtcO4XdjjEoqMKsHbLovPuXy7VSGZ0HF?= =?us-ascii?Q?TMfTG+lxQ5Lz97hS7x9+A4uX9xuJWrLmkojZ6oTZm6rX8zuGC1dsw/lKDcFE?= =?us-ascii?Q?5tQSKxeeQ27XCABB8nhtLIAFApxn7l3RZphgvcRllSY0LYbdbRM2MuBMLYlH?= =?us-ascii?Q?J1+lIUg7cOcOhsFTtpopW25cvwsXI8JOHYPt7XQAkptmpv0m6FIwfyi3i66g?= =?us-ascii?Q?FZ9Nc/P9Uexy6k5xjYYWAMCdPjoIh1/ZeRokh9C4TzSJ4q45aGr4B3s7mxB8?= =?us-ascii?Q?AghZ9ip7+s8mGqYp7VD7QlX/xrW04OuXPxNtl1zUPbytN/VE06AlGDN44qUR?= =?us-ascii?Q?f+ij4mzs2SxlEzBoVNYmQI10/g4TMsiPY2600J4qobYTGfYrmJEhUZOUd/bY?= =?us-ascii?Q?tg/4CeqavTsZsl3sBVVNgHHCJocK4lyBC8UsX09qCLSfrXy7QN+mLoToDs9X?= =?us-ascii?Q?ho9sUgxd8CO5DCUv51AwAbWtTycyJFJN23IjRBtShw3/8V8i/a6xaAusZp4P?= =?us-ascii?Q?W523KeAbO0dz+kKlqliok6v4yeHOu24tIXXU7k3Kk4i34FsV8LvUyvmXt5Gl?= =?us-ascii?Q?L3rfNqm8CONsdTtl/LMLHGQRPcjf0WYcbhqz/mVqIfdcnEsaZXIbOprEqu04?= =?us-ascii?Q?tIjlhr9v8BM/W3udsPunOF5QXEAiNr/N4UeiQAWhWGVca5wdXXptUxNLAq6M?= =?us-ascii?Q?Scd4ppU80MH5xQ5K7HB9aDG5iYA+XssxNAoMcgkhnRjGlKCqktFfzmGKm7st?= =?us-ascii?Q?tYNt1MIIAlRWUq8SXUf87wpo1SDn+ip3HMag/mC7LDN+828MPUklZGQG7hai?= =?us-ascii?Q?9sdpx3aae1sLlks+uX4D/00feeXXPNoPExP+A96rNgWtosw5dSMfjr+hjf1J?= =?us-ascii?Q?Q+ttAryILBhRjzIGe9JmoFYjc2aY5mSZaaaaBVFQGoZQoNKSV/UWen7upr7s?= =?us-ascii?Q?BKqL2LsCYM3qtX+gGGCVbXynFQ8dAnG6GTppdk7ftcLcfoerC5997z+R5gT2?= =?us-ascii?Q?++MGq/FDWv92CNsBDRxJFn8V/Kdem9ZQNn2eOb3PUtzGVyF+CR6wALT8RuPi?= =?us-ascii?Q?QhPP0q8V6iicPhV0OWgjWtvBgd4GZBoxkjU8OQDh1rhx5Iu7Uy8Rnc/s+XaT?= =?us-ascii?Q?VKMzFc5zHECqahri4C+Yu0L96WfuOsJsIpGRKGQBTYIaCQtYt+UPOCfjXLUT?= =?us-ascii?Q?j07FM5Z23xSlWguFaHJtwvJC5Z+i24wD817RCq4BNSKstzlO+BblcADxpXLo?= =?us-ascii?Q?PATgzDN+sgJ1iwryJrN7mDNrjPq48tJ0pJ4A3ZoqN9WKbXDXJB8cLFeDwi4g?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB161;6:+dYufkcbV3mdDNjNkMbSerPdRL66dkkDMwvX9T9BPb81pOUeG7qby/VZWV/6XPqiIG6s0WqJrrx/Fhv8M5sE14H+1gXAPrJ/rfwsNZw2ORRhCoPiQ7w2pcGzcnM5YO75R/9rR/4OMwYDXJeeNdCHaQrvG10ioJx/7HIMNLnJeFJ+3XTedt0h5Vw0h9qugY9iVNSKg+utsEZgq19iOFIUNndBYhj4Zz6fdnoW3uJ5AG+R8lCQ5U46j5qLmPlBed4FAIbbX02ErmG/DrsgKuijywULepIx19Q3V27tFzHvJb7Fwi7KYdHyIQddr7XRfqrZguP8He84M6F3u+iEgZXDuJxnLr1gmDaPKNuJ5lfDLCZ6GFq+c2GCI2NKSfVGx4xcecTkIF60txcCZvSE4YztAsG8oSUSZoCutYvkbqWtP8NwGjsUc2cFwamN030LJxgE+LPQXOnfoodD1mz8K+6KQR/q7BUd28eIl60zUCtZE0B0PT3gjpWVO5kwekcJjh9FL1zXF0SRCoy+81FxNpf6Sg==;5:0d2EuOkk0h6N8XT/GeL+10fXNjmvgWirhzVyIl/JSgrdYa5ecmaRSAFy+QR6AcmcnNJAR8VN+2UozkrctOhd8CuZE/JatYGOiCWDA48iJkn9ue8gcE5VDPFbGwuc414szTKf0OuCaEjWdLfiRq6zoQKffRVQeJnsGxvgGEysKI6/xU9YU/3NSfspui1/mL/c;24:2jUBdXCDGSRp5G+6uHBOZeOKYss3xx9IX+SghNqwMxKYrxoeBJHKKZYETEISZNLD9p/VkDp+ooHslczmHfXU+sV0TiyNClJbTGi19QNeVbA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB161;7:Xjhz+sP7GX4KedLNSQSjsvVCt+vA2icABOIUpdf62s5Bg/I/P1wIqY9plt6WlYN0G0yWsVUQS59h1HD4XJFm4BdRqunySS/S/yDUXX2zR+fP1Lmg+xF5bu7+tbto0aU+I9P8PRUbIGDkReJ/cWn5tcrUzfVfInMIJfbynIzjpSZg9Bo5rRVpssuqCVCDl0xTC+YJ/7atOi6lBJrITnCOFAhrmefopcpPeLT4W7j0yV4ezghpYMDF/B6Xcjl9Qsrms/wyGP4AAeCwIEmC2lqgihMQPp1RNK7aeunT7SeTYvDurL1U/eVWZTg51XMQzHOgOCNsCRDPFm8FnbVuTx9uQg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 13:49:04.2490 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB161 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These helper function allows drivers to get several clk consumers in one operation. If any of the clk cannot be acquired then any clks that were got will be put before returning to the caller. The idea firstly came out when i wanted to clean up and optimize imx6q-cpufreq driver which needs to handle a lot of clocks as it becomes a bit mess. e.g. drivers/cpufreq/imx6q-cpufreq.c You will see we need get 7 clocks during driver probe. (Add there will be more, e.g. pll1, pll1_bypass, pll1_bypass_src, in the future when adding busfreq support). static int imx6q_cpufreq_probe(struct platform_device *pdev) { .... arm_clk = clk_get(cpu_dev, "arm"); pll1_sys_clk = clk_get(cpu_dev, "pll1_sys"); pll1_sw_clk = clk_get(cpu_dev, "pll1_sw"); step_clk = clk_get(cpu_dev, "step"); pll2_pfd2_396m_clk = clk_get(cpu_dev, "pll2_pfd2_396m"); if (IS_ERR(arm_clk) || IS_ERR(pll1_sys_clk) || IS_ERR(pll1_sw_clk) || IS_ERR(step_clk) || IS_ERR(pll2_pfd2_396m_clk)) { dev_err(cpu_dev, "failed to get clocks\n"); ret = -ENOENT; goto put_clk; } if (of_machine_is_compatible("fsl,imx6ul")) { pll2_bus_clk = clk_get(cpu_dev, "pll2_bus"); secondary_sel_clk = clk_get(cpu_dev, "secondary_sel"); if (IS_ERR(pll2_bus_clk) || IS_ERR(secondary_sel_clk)) { dev_err(cpu_dev, "failed to get clocks specific to imx6ul\n"); ret = -ENOENT; goto put_clk; } } .... put_clk: if (!IS_ERR(arm_clk)) clk_put(arm_clk); if (!IS_ERR(pll1_sys_clk)) clk_put(pll1_sys_clk); ........... } Together with the err path handling for each clocks, it does make things a bit ugly. Since we already have regulator_bulk_get accessories, i thought we probably could introduce clk_bulk_get as well to handle such case to ease the driver owners' life. Besides IMX cpufreq driver, there is also some similar cases in kernel which could befinit from this api as well. e.g. drivers/cpufreq/tegra124-cpufreq.c drivers/cpufreq/s3c2412-cpufreq.c sound/soc/samsung/smdk_spdif.c arch/arm/mach-omap1/serial.c ... And actually, if we handle clocks more than 3, then it might be worthy to try, which there is quite many manay in kernel and that probably could save a lot codes. Comments are welcome and appreciated! Tested on MX6Q SabreSD board with CPUfreq stress. Also ran IA64 and m68k compiling test: make.cross ARCH=m68k make.cross ARCH=ia64 ChangeLog: v2->v3: Only Patch 1 changed. * release resource in reversed order in case an error according to Geert Uytterhoeven's suggestion v1->v2: * Most significant change is introducing clk-bulk.c to centrally handle bulk_clks and fix !CONFIG_CLKDEV_LOOKUP platforms build break. Other are comments fix, adding const annotation and etc. Refer to individual patches for details. [v1] https://lkml.org/lkml/2017/4/11/335 [v2] https://lkml.org/lkml/2017/5/8/276 Dong Aisheng (3): clk: add clk_bulk_get accessories clk: add managed version of clk_bulk_get cpufreq: imx6q: refine clk operations drivers/clk/Makefile | 2 +- drivers/clk/clk-bulk.c | 157 ++++++++++++++++++++++++++++++++++++++++ drivers/clk/clk-devres.c | 36 +++++++++ drivers/cpufreq/imx6q-cpufreq.c | 119 ++++++++++++++---------------- include/linux/clk.h | 132 +++++++++++++++++++++++++++++++++ 5 files changed, 379 insertions(+), 67 deletions(-) create mode 100644 drivers/clk/clk-bulk.c -- 2.7.4