From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756865AbdESWXj (ORCPT ); Fri, 19 May 2017 18:23:39 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:31210 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756707AbdESWXe (ORCPT ); Fri, 19 May 2017 18:23:34 -0400 X-IronPort-AV: E=Sophos;i="5.38,366,1491235200"; d="scan'208";a="18951064" From: Bart Van Assche To: "hare@suse.de" , "asavkov@redhat.com" CC: "hch@lst.de" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "axboe@fb.com" , "martin.petersen@oracle.com" Subject: Re: [PATCH] Use ctlr directly in rdac_failover_get() Thread-Topic: [PATCH] Use ctlr directly in rdac_failover_get() Thread-Index: AQHS0JhoxK18G+Kw5E+lDpL6RSG34aH8O+IA Date: Fri, 19 May 2017 22:23:30 +0000 Message-ID: <1495232608.2581.3.camel@sandisk.com> References: <1495195574-27835-1-git-send-email-asavkov@redhat.com> In-Reply-To: <1495195574-27835-1-git-send-email-asavkov@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=sandisk.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;7:soR2LMbRhp6STM9VgB0cHs76iS16fqZLw0TKMmmEEWA+LoR9RCj8FOwhyl4U7ozJFRAGq6V4SpGcQFBO82qBHpGXtMEk2PZvYzjnLUAWz5Bl++QEAIBJUoq7o9yMO4OYynoJBcFUJtCDcI7MxfBNskKKlcvz5BFj8ZkoBlk1K9wszYxCKwAtRX11qlf9oVmtl0Eu/c+K9VDkOvhRX9HRF4oWiL9Aau2qzPN/wphl8sKrtGRndxjz4vJWNF8UoOD2scEkDksi0uaVyEq+1gfRhwSrHq7yiudtljt+WLsSVVqk2LP+FtmLG9o/mTBw+/VqCx1uoqfwlCfS5kY45HDgLQ==;20:hLcy18xL3WPsnq3u5V95k+7KswapfOCIDoLmGoSVvnZEZ7CpoDYfjB8VCGrQ9rbnrnUdU8FWpS4KOTsQ1imTCeeR5sWwNpcutc1RCrvnTRrkY9Vmj5dEwZWx71IShatpWP8MB+jYPIYQgUl9gphsIbJc1OEi5AIW3yfAoJo47uk= x-ms-traffictypediagnostic: CY1PR0401MB1536: x-ms-office365-filtering-correlation-id: 59657830-f3fe-483a-d74b-08d49f05adf2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1536; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(20161123560025)(6072148);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1536; x-forefront-prvs: 031257FE13 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(39450400003)(39400400002)(39840400002)(39410400002)(39850400002)(24454002)(377424004)(4326008)(38730400002)(305945005)(6512007)(478600001)(86362001)(36756003)(6246003)(53936002)(229853002)(77096006)(8936002)(6486002)(33646002)(103116003)(2950100002)(8676002)(122556002)(6506006)(81166006)(6436002)(99286003)(50986999)(25786009)(3660700001)(66066001)(6116002)(102836003)(3846002)(2900100001)(189998001)(54906002)(3280700002)(5660300001)(54356999)(2501003)(72206003)(2906002)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2017 22:23:30.6546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4JMNlqe028765 On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote: > rdac_failover_get references struct rdac_controller as > ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being > inefficient this also introduces a null-pointer dereference as > send_mode_select() sets ctlr->ms_sdev to NULL before calling > rdac_failover_get(): > > [ ... ] > Signed-off-by: Artem Savkov Hello Artem, Although this patch looks fine to me, please consider adding the "Fixes:" and "Cc: " tags. Bart.