From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968240AbdEWOwP (ORCPT ); Tue, 23 May 2017 10:52:15 -0400 Received: from smtprelay0030.hostedemail.com ([216.40.44.30]:36374 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S967075AbdEWOwM (ORCPT ); Tue, 23 May 2017 10:52:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:4321:5007:7901:9010:10004:10400:10848:11232:11658:11914:12296:12740:12760:12895:13069:13311:13357:13439:13972:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:11,LUA_SUMMARY:none X-HE-Tag: boys69_129c175329c16 X-Filterd-Recvd-Size: 1349 Message-ID: <1495551126.2093.60.camel@perches.com> Subject: Re: [PATCH 1/2] crypto: engine - replace pr_xxx by dev_xxx From: Joe Perches To: Corentin Labbe , herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 23 May 2017 07:52:06 -0700 In-Reply-To: <20170523120903.31637-1-clabbe.montjoie@gmail.com> References: <20170523120903.31637-1-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-23 at 14:09 +0200, Corentin Labbe wrote: > By adding a struct device *dev to struct engine, we could store the > device used at register time and so use all dev_xxx functions instead of > pr_xxx. trivia: > diff --git a/include/crypto/engine.h b/include/crypto/engine.h [] > @@ -58,6 +58,7 @@ struct crypto_engine { > struct list_head list; > spinlock_t queue_lock; > struct crypto_queue queue; > + struct device *dev; Probably nicer to align to column for consistency struct device *dev;