From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760418AbdEYVdV (ORCPT ); Thu, 25 May 2017 17:33:21 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34255 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758444AbdEYVdS (ORCPT ); Thu, 25 May 2017 17:33:18 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Anup Patel , "Rob Herring" , "Mark Rutland" , "Stephen Boyd" From: Michael Turquette In-Reply-To: <1495454307-23464-4-git-send-email-anup.patel@broadcom.com> Cc: "Catalin Marinas" , "Will Deacon" , "Ray Jui" , "Scott Branden" , "Jon Mason" , "Florian Fainelli" , "Oza Pawandeep" , "Srinath Mannam" , "Pramod Kumar" , "Sandeep Tripathy" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com References: <1495454307-23464-1-git-send-email-anup.patel@broadcom.com> <1495454307-23464-4-git-send-email-anup.patel@broadcom.com> Message-ID: <149574798866.52617.17864487502272102012@resonance> User-Agent: alot/0.3.7 Subject: Re: [PATCH v4 03/11] clk: bcm: Add clocks for Stingray SOC Date: Thu, 25 May 2017 14:33:08 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4PLXX6S017845 Hello Anup, Quoting Anup Patel (2017-05-22 04:58:19) > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Are all of those headers really needed? > +CLK_OF_DECLARE(sr_genpll3_clk, "brcm,sr-genpll3", > + sr_genpll3_clk_init); Why use CLK_OF_DECLARE here? You've got a proper platform driver here. Regards, Mike