From: Kees Cook <keescook@chromium.org>
To: kernel-hardening@lists.openwall.com
Cc: "Kees Cook" <keescook@chromium.org>,
"Christian König" <christian.koenig@amd.com>,
"Eric Huang" <JinHuiEric.Huang@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Laura Abbott" <labbott@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 14/20] drm/amd/powerplay: Use designated initializers
Date: Fri, 26 May 2017 13:17:18 -0700 [thread overview]
Message-ID: <1495829844-69341-15-git-send-email-keescook@chromium.org> (raw)
In-Reply-To: <1495829844-69341-1-git-send-email-keescook@chromium.org>
The randstruct plugin requires designated initializers for structures
that are entirely function pointers.
Cc: Christian König <christian.koenig@amd.com>
Cc: Eric Huang <JinHuiEric.Huang@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
.../gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 28 ++++++++++++++--------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
index d5f53d04fa08..cfa187185dcc 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
@@ -709,17 +709,22 @@ static int tf_vega10_thermal_disable_alert(struct pp_hwmgr *hwmgr,
static struct phm_master_table_item
vega10_thermal_start_thermal_controller_master_list[] = {
- {NULL, tf_vega10_thermal_initialize},
- {NULL, tf_vega10_thermal_set_temperature_range},
- {NULL, tf_vega10_thermal_enable_alert},
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_initialize },
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_set_temperature_range },
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_enable_alert },
/* We should restrict performance levels to low before we halt the SMC.
* On the other hand we are still in boot state when we do this
* so it would be pointless.
* If this assumption changes we have to revisit this table.
*/
- {NULL, tf_vega10_thermal_setup_fan_table},
- {NULL, tf_vega10_thermal_start_smc_fan_control},
- {NULL, NULL}
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_setup_fan_table },
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_start_smc_fan_control },
+ { }
};
static struct phm_master_table_header
@@ -731,10 +736,13 @@ vega10_thermal_start_thermal_controller_master = {
static struct phm_master_table_item
vega10_thermal_set_temperature_range_master_list[] = {
- {NULL, tf_vega10_thermal_disable_alert},
- {NULL, tf_vega10_thermal_set_temperature_range},
- {NULL, tf_vega10_thermal_enable_alert},
- {NULL, NULL}
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_disable_alert },
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_set_temperature_range },
+ { .isFunctionNeededInRuntimeTable = NULL,
+ .tableFunction = tf_vega10_thermal_enable_alert },
+ { }
};
struct phm_master_table_header
--
2.7.4
next prev parent reply other threads:[~2017-05-27 1:12 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 20:17 [PATCH v2 00/20] Introduce struct layout randomization plugin Kees Cook
2017-05-26 20:17 ` [PATCH v2 01/20] NFS: Avoid cross-structure casting Kees Cook
2017-05-28 7:53 ` Christoph Hellwig
2017-05-28 16:55 ` Kees Cook
2017-05-26 20:17 ` [PATCH v2 02/20] gcc-plugins: Detail c-common.h location for GCC 4.6 Kees Cook
2017-05-26 20:17 ` [PATCH v2 03/20] compiler: Add __designated_init annotation Kees Cook
2017-05-26 20:17 ` [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin Kees Cook
2017-06-29 22:08 ` Arnd Bergmann
2017-06-29 22:53 ` Kees Cook
2017-06-30 0:04 ` Kees Cook
2017-06-30 7:35 ` Arnd Bergmann
2017-06-30 7:55 ` Ard Biesheuvel
2017-06-30 8:27 ` Arnd Bergmann
2017-06-30 14:41 ` Kees Cook
2017-06-30 15:22 ` Arnd Bergmann
2017-05-26 20:17 ` [PATCH v2 05/20] randstruct: Whitelist struct security_hook_heads cast Kees Cook
2017-05-27 8:41 ` Christoph Hellwig
2017-05-27 20:09 ` Kees Cook
2017-05-27 22:04 ` Tetsuo Handa
2017-05-28 0:43 ` [kernel-hardening] " Kees Cook
2017-05-30 10:34 ` James Morris
2017-05-26 20:17 ` [PATCH v2 06/20] randstruct: Whitelist UNIXCB cast Kees Cook
2017-05-26 20:20 ` Kees Cook
2017-05-28 7:56 ` Christoph Hellwig
2017-05-26 20:17 ` [PATCH v2 07/20] randstruct: Whitelist big_key path struct overloading Kees Cook
2017-05-28 8:12 ` Christoph Hellwig
2017-05-28 16:59 ` Kees Cook
2017-06-19 19:24 ` Kees Cook
2017-09-07 7:20 ` Christoph Hellwig
2017-09-07 22:55 ` Kees Cook
2017-05-26 20:17 ` [PATCH v2 08/20] randstruct: Whitelist NIU struct page overloading Kees Cook
2017-05-28 8:15 ` Christoph Hellwig
2017-05-28 17:35 ` Kees Cook
2017-05-28 17:37 ` Kees Cook
2017-05-26 20:17 ` [PATCH v2 09/20] randstruct: Mark various structs for randomization Kees Cook
2017-05-26 20:17 ` [PATCH v2 10/20] randstruct: opt-out externally exposed function pointer structs Kees Cook
2017-05-26 20:17 ` [PATCH v2 11/20] randstruct: Disable randomization of ACPICA structs Kees Cook
2017-05-27 8:42 ` Christoph Hellwig
2017-05-27 20:03 ` Kees Cook
2017-05-28 4:55 ` Christoph Hellwig
2017-05-26 20:17 ` [PATCH v2 12/20] sgi-xp: Use designated initializers Kees Cook
2017-05-27 8:44 ` Christoph Hellwig
2017-05-26 20:17 ` [PATCH v2 13/20] drm/amdgpu: " Kees Cook
2017-05-26 20:17 ` Kees Cook [this message]
2017-05-27 8:47 ` [PATCH v2 14/20] drm/amd/powerplay: " Christoph Hellwig
2017-05-27 20:10 ` Kees Cook
2017-05-26 20:17 ` [PATCH v2 15/20] mtk-vcodec: " Kees Cook
2017-05-26 20:17 ` [PATCH v2 16/20] ntfs: Use ERR_CAST() to avoid cross-structure cast Kees Cook
2017-05-26 20:17 ` [PATCH v2 17/20] ocfs2: " Kees Cook
2017-05-26 20:17 ` [PATCH v2 18/20] randstruct: Enable function pointer struct detection Kees Cook
2017-05-26 20:17 ` [PATCH v2 19/20] [RFC] task_struct: Allow randomized layout Kees Cook
2017-05-26 20:23 ` Linus Torvalds
2017-05-26 20:32 ` Kees Cook
2017-05-26 20:17 ` [PATCH v2 20/20] ACPICA: Use designated initializers Kees Cook
2017-05-28 7:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495829844-69341-15-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=JinHuiEric.Huang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®