From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750983AbdE2JrA (ORCPT ); Mon, 29 May 2017 05:47:00 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:44189 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbdE2Jq7 (ORCPT ); Mon, 29 May 2017 05:46:59 -0400 Message-ID: <1496051209.17695.36.camel@pengutronix.de> Subject: Re: [PATCH] reset: hisilicon: Fix hi6220 module license From: Philipp Zabel To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Chen Feng , linux-kernel@vger.kernel.org Date: Mon, 29 May 2017 11:46:49 +0200 In-Reply-To: <20170525092232.27960-1-afaerber@suse.de> References: <20170525092232.27960-1-afaerber@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On Thu, 2017-05-25 at 11:22 +0200, Andreas Färber wrote: > The hi6220_reset driver fails to load: > > [ 10.423640] hi6220_reset: module license 'unspecified' taints kernel. > [ 10.423644] Disabling lock debugging due to kernel taint > [ 10.423735] hi6220_reset: Unknown symbol regmap_write (err 0) > [ 10.423747] hi6220_reset: Unknown symbol devm_kmalloc (err 0) > [ 10.423759] hi6220_reset: Unknown symbol syscon_node_to_regmap (err 0) > [ 10.423768] hi6220_reset: Unknown symbol reset_controller_register (err 0) > [ 10.423784] hi6220_reset: Unknown symbol __platform_driver_register (err 0) > > Add a MODULE_LICENSE() to fix this. > > Fixes: 70b3590f639f ("reset: hi6220: fix modular build") > Cc: Arnd Bergmann > Cc: Chen Feng > Signed-off-by: Andreas Färber > --- > drivers/reset/hisilicon/hi6220_reset.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c > index 35ce53edabf9..d5e5229308f2 100644 > --- a/drivers/reset/hisilicon/hi6220_reset.c > +++ b/drivers/reset/hisilicon/hi6220_reset.c > @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void) > } > > postcore_initcall(hi6220_reset_init); > + > +MODULE_LICENSE("GPL v2"); Thank you, I have the same patch queued already. regards Philipp