From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbdE3KTo (ORCPT ); Tue, 30 May 2017 06:19:44 -0400 Received: from smtprelay0236.hostedemail.com ([216.40.44.236]:53557 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751004AbdE3KTm (ORCPT ); Tue, 30 May 2017 06:19:42 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:3872:4321:5007:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12048:12295:12296:12438:12555:12740:12895:12986:13069:13311:13357:13439:13894:14659:14721:21080:21220:21324:21433:21451:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: alley23_537f1905d3462 X-Filterd-Recvd-Size: 2250 Message-ID: <1496139572.2618.19.camel@perches.com> Subject: Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs From: Joe Perches To: Hirokazu Honda , Pawel Osciak , Marek Szyprowski , Kyungmin Park , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 30 May 2017 03:19:32 -0700 In-Reply-To: <20170530094901.1807-1-hiroh@chromium.org> References: <20170530094901.1807-1-hiroh@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-30 at 18:49 +0900, Hirokazu Honda wrote: > Some debug output whose log level is set 1 flooded the log. > Their log level is lowered to find the important log easily. Maybe use pr_debug instead? Perhaps it would be better to change the level to a bitmap so these can be more individually controlled. Maybe add MODULE_PARM_DESC too. Perhaps something like below (without the pr_debug conversion) ---  drivers/media/v4l2-core/videobuf2-core.c | 11 ++++++-----  1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 94afbbf92807..88ae2b238115 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -31,12 +31,13 @@    static int debug;  module_param(debug, int, 0644); +MODULE_PARM_DESC(debug, "debugging output control bitmap (values from 0-31)")   -#define dprintk(level, fmt, arg...)       \ - do {       \ - if (debug >= level)       \ - pr_info("vb2-core: %s: " fmt, __func__, ## arg); \ - } while (0) +#define dprintk(level, fmt, ...) \ +do { \ + if (debug & BIT(level)) \ + pr_info("vb2-core: %s: " fmt, __func__, ##__VA_ARGS__); \ +} while (0)    #ifdef CONFIG_VIDEO_ADV_DEBUG