From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751362AbdEaNmU (ORCPT ); Wed, 31 May 2017 09:42:20 -0400 Received: from mail-bn3nam01on0046.outbound.protection.outlook.com ([104.47.33.46]:4848 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750952AbdEaNmQ (ORCPT ); Wed, 31 May 2017 09:42:16 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Anurag Kumar Vulisha To: , CC: , , , Anurag Kumar Vulisha Subject: [LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg trb when cached ring is used Date: Wed, 31 May 2017 19:11:50 +0530 Message-ID: <1496238110-4998-1-git-send-email-anuragku@xilinx.com> X-Mailer: git-send-email 2.1.1 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23102.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39410400002)(39450400003)(39840400002)(39860400002)(39850400002)(2980300002)(438002)(199003)(189002)(9170700003)(2906002)(36386004)(478600001)(45336002)(189998001)(103686004)(46386002)(50466002)(90966002)(81166006)(33646002)(8676002)(8936002)(63266004)(42186005)(48376002)(356003)(305945005)(106466001)(5003940100001)(50226002)(50986999)(47776003)(54906002)(52956003)(107886003)(38730400002)(6266002)(4326008)(36756003)(5660300001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR02MB2684;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT064;1:XEwJGgsNSQKxU4s1B7b5lqlmTYn6eU+H7qe/GMGLSkJlDv8NoTQCXEkfG0u37TXTxqpfw1snvD+xZpKOzY0P9tBgVdHS7pmK87pVL4cEcXJy0lz7r9BrSyfp0NlZVAN+JPZF7TAKm4nzMDUIlJprA5CJsNyUPn7uvyWu6SfJ6WW6+Mz8hw+RwcTTPiiqg1Y/57FLck3/hl9jJ9fQg7CAuHGvrOjTZKLeNtrMH7HmP75e88Xd0roK49glQQnE6PX7Z1fMEIzfhU+R5hyWwMis6tFcBWVKV+H+mHFl06Npm6WJSaRv6CbG520ytoCfdkusISgg5VrL2TtN7TsWz22wcJH/kwWqf2VjWLH0BKzNOkf9QxxsBSEgkx/QtO/DGpQ64WMIGbMKOqkRWnwy35gzadK4KWdngKLh0dLxjPLqX05C8AukVzvCbVunlaKWzr9G2nR9HKBYdjMzyZeZjnQVLlq69jrw4vT2+6n7yxncj/2atKn4fDwUFhgyo7rrfFHIiphmnHw9sWu/OmxkiIa75rc/I637Pfd8VUVIoWAqse+RNdvGEtIHYDzPZiag/3SqxHvg2R4m9vej8HXTG8y6Zg== MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR02MB2684: X-MS-Office365-Filtering-Correlation-Id: 13c63b2a-deb3-46eb-b23f-08d4a82ad823 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081);SRVR:DM5PR02MB2684; X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2684;3:qR9gCD/L2DGyXMwc6zWwjmi0K4msJzyjv+4Cb0Z/Wy+vpKfAupXRWD9oM20sCX9Bi3NOHe5Avps8cHhNXsWmMGpC755vGeB0mAnP+fThSIGuzHcWbzLJoFw/03Fa9oNgqEBMgO+RwTAU/wOXsTpolsQ9A6M2iNLkilS0V8HutcgDzDguBtIH3+tpAZbL0SlnGPeI7id9/BQKSf/C1PZglizkV5sUpjLAORwCrlicW/CsZFNXVPgIPLRGyFMHal+kHPT8DTLeahoghv95ibsFSBvlu3Y1+iwGx2ATavPu5MXJr/X40XENE2gr1/V/nCnaxlcFNug6oFl1ULXCveLRQHegPbJ9InzNSquuXT7X/lX3VT6AEuytphcs1poPmxi9YBcXMwb0UyhzvwgCqbUsMgCsRPMvub5oGuMyOM5AJCHEdO+hcf06O57Aawr9zgEy91m+NSwS0hjwDubPjmkKXdKE9jWlhVSz3lqjiHPiMrpOXEgRFUIs1eL2c0eXGxig X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2684;25:Epm7d2uXd681oZzzX9eYb7AuYc++/E5B4pUA0PGAn4Q5YJGHyq3I/2L0vg5T141Bi9xYkP5Z1EW9ki4xo/BLXVb+AZG5cQ5+HdM/wuAzwgIwM4bfNphGkNPVEnIwJMxRi10eYOzFt8V0qieN/DO7Z8Mj5UotVABDwQcnxtH17xVkztREAnZ94vGLMdkxcDP2nWjsUdcW7ykLfnZumruPwjz82TotjRFHtc7FdQCbKiKeDIi0QzWsY+KyGA9HAMzu2f9A4k07M3uydfmIiJzoSLLhjcuQ25i3srAC9Taexq1vGLHH+wCMTTVzLwVCBz4rMk5bP6yVX0jA17sYBPx4YK/YApIb2SIv0+C1mTRc0CRY761DCHzwN7ED9looS15WTV3/pCXs/sZUn7KXGdwvvSVMNbMLvzlyK4MF5tsd737oLYgCL1SR6ALTqdehKxeHikfoXLfXKHPlsMYRWWoJIySFLW7Jrdv1onB4E9NQ7dk=;31:0iFOUhc0PuVlxrsSsdd8cK28ihhdxhlO0WJ/euJFRF1Rt01oA7rwOiNzL7g39eYYc6KK0GlJJqxzoKgjC12v3ifZv8BnPpY7iT6mb7S/aSOG6zyieB/Sz4Ulf5jkFISUkzu2mctR5/MlnXxAzcYQC32sRuoNJrpG9VhZzu6vnIdA0YVV6HB2BPdF52baX2B4dZX2TwjZQE660jXp7xlpBIV5z8rZPoMrgjWCxxycdlxwFbPeNoDcmCbgX15S5vIkq3I/apBBbrwFN0JHGExUBg== X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2684;20:ne3OJIzrWadmhX+1uMFeLBb4fJULU5uZSKApf5fwFZNfe8KdMeTcT47xtP4mCKdUvrCE09swiY+YmYukgTjIw7zqLAa4QKl0RLXwFnGR/0id8BdO5/JiTK83EYggCWduAXpqin75Dzg5hsKLwZGQUuElDZVQ3/ajA4PUQY8eg/+4PpDqrBySsK9Z56SPW70z4hMJoNm3//gn8QEKvXRTvU5OYNBrFtAnPp0B0rxhFplgBDlfgxDVTcFAs1ncSkrCNPAHSpEy2AxpbkM8zON1xzu3f9VDzTmOZXxbhcazB6fRsbxl/rVecOhRuR463Rxt+N01KKtKgegLH6ibhhTR0d8B8e0q5zH9A8u3RGkWuz/8iZ2v4on9ocuz60vpGQ+5SmNkCOeVghSIzzc8hHvxue2Lr6VS2ocjiOYbzj3uMYeBRKojnhCevJapiqiQ8l6FI/Tr9/VpjM/f1U6MMOzO+fGZdWXabhNRfwrkpujIJ6CCyl9Qp29mCeYVAWCA3c+B X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6040450)(601004)(2401047)(13018025)(13016025)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93004095)(100000703073)(100105400095)(6055026)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(6072148)(100000704073)(100105200095)(100000705073)(100105500095);SRVR:DM5PR02MB2684;BCL:0;PCL:0;RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(100000804073)(100110200095)(100000805073)(100110500095);SRVR:DM5PR02MB2684; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR02MB2684;4:+N5XurNH/bHcRPi2z2I0dqTNSNLHvBb92ONn0h3j/g?= =?us-ascii?Q?6YG2oYfc6COwVxijptvvoazDoVOZfehswGJDFzmXK1eH0pDA/Ku6c/XdU1U1?= =?us-ascii?Q?3msVzKNyrfGVVnqaUqMnCOhvPtgpR/snw5uB540UrUAxhjgiPkJkWSqGObIv?= =?us-ascii?Q?5vkek83GZd9lw6u3QFgiUh8rLyw9oIP1UYKffYYeDOdZIEuEoFBtndkvxVKe?= =?us-ascii?Q?cT+xrPyzonRP4v0/TP2Nb5jNzZeTM28NNB28TgsFcbXriuWy/iXISG1zMwr6?= =?us-ascii?Q?7tf43dsiHeHwOE7y1ZR6aGNFMwRQg2vfd0lA7e93iLelTH+lX4+UqRIHa3wH?= =?us-ascii?Q?t1JG8eBnAICfHrig/5X53PB1t+54rYPuwfzO64KsGD1d44zbordVIRakgNov?= =?us-ascii?Q?WQGIiPqm9v3Jh7Q9G6h1HlECRtVZg6zR2Vm5K9j45U9C8Avl0nkefx3Yyruj?= =?us-ascii?Q?oT7zUCZsMLLifamjQPunOt42usDx7/PpwFJ1r59mt8Tj96+FiSToNRXymQWL?= =?us-ascii?Q?yzitqr1WJxx41Rmln4e+eYgASD+Buhi0O00d+RdajO3HJCVxSlDjWUydG/Tn?= =?us-ascii?Q?WI2WRON74DeYwol5+8cAKgv974YC6ocfSxQlxD/QLX1TKuANPqR041enLX4f?= =?us-ascii?Q?Mt3iXybG6+fKjr1AE9zXROt4s/1OEXkzsPKJlQNozQKJS3m9MD5G/AT6HJ8N?= =?us-ascii?Q?+WtFsLCjlQ+hqGKzUnkL96eFqruA41Em99x/qRJLfrWLd4ksXpMSqZrBSsic?= =?us-ascii?Q?KfKXx1uxgR/StPBHp/oV7UKDnV9xH6FYUkbrsgoZn9vQVCwneGV3hM3G2I22?= =?us-ascii?Q?T0DA7JewpI5My90Yu4W9eROH/qx8O0wWC3ZyJpGyCTjOhsy+8ByksumcPAly?= =?us-ascii?Q?1y4liXb7rHij3WcDWC6wtPezk2fOg48AOAT54t+VyBqVgSTHkZ/PUsbfizX0?= =?us-ascii?Q?B0xqDWDx/yrIu2AjbsiscSOLCGsqi5ReX8jdCfFmxwR8wj3Mdl6CoRCJqjvj?= =?us-ascii?Q?A3wRhU0oh2GwXLkuy2RSKiV0QXQXk+y5NXBji5nORrML0nZgWc4qES1hKuX6?= =?us-ascii?Q?gnhNZ+KvL5zeTjLrPGrUiRJcVnCaGQGkaJ2BMRsN18Bunvpgh8ANH7j2plgd?= =?us-ascii?Q?XcW4EINlIZtyJ5cK0bQpMlu1M4Frnw2EIvaxVkn4qbAr8uBAsGbsM1TpQHaV?= =?us-ascii?Q?pvQreigYmc8jTme5qWKyijQQiOtP+I0b82uQZfkMo9zfINarMLAxgvEB3TPR?= =?us-ascii?Q?SY0aaYasooMfmxI/4=3D?= X-Forefront-PRVS: 0324C2C0E2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR02MB2684;23:DH95fXFVmwH9ZRThlziGYGVlHjuTE7ZMKm+KWzGAV?= =?us-ascii?Q?UKRKxFp9TlJTfFqx0j75rcz+HguWKVebqLS4q9igua3EKaZbddHQo6CChcsx?= =?us-ascii?Q?7wK5FU3kPGJg5T4MdjAL6YKiDOUqoxj9mnianZSxiW4Gko1xdFNXsvksJbHz?= =?us-ascii?Q?bk5/Oz4LJSl87wu06RXQVM1gnTDwsy48eJnibx5shdc0ia8uuU7XSFs83jcv?= =?us-ascii?Q?tQPI0qKJkXwlCm0B4HXzu1Z7NxFrstllRXe6JGKu+oLtWa67/vF/yFtweiqB?= =?us-ascii?Q?e5KyD1ol6lu2ZaJ4AT2LglEmPapjJ9CZpF5Rq+iIYl7UmHofNOJqmUNOFCUv?= =?us-ascii?Q?3gHgB78yBjR9fTgGA5vWyBL8mNb8aI82romMZSgS2U6jZOnFHPQWU7pB4KPN?= =?us-ascii?Q?cJ86fvzgx81JmR3M2hs+Us32WK7saLTMtB34BHVNP+eyDt91zJZhK3qSgcCf?= =?us-ascii?Q?s8uLAo0HwVSHOpQIw7GhjXfEjLJNcJKpfZQYKJKml4Hu9nTOkCFPcOGoC4/Q?= =?us-ascii?Q?wDgQ3+grBaAIVzRTot5P/wBDid5JQ+QlY35XXTkOcd/Y3crYiewapEYNPgQz?= =?us-ascii?Q?rYDBzUR0TayeMbffUMWu7ovx7yKl/pmv3HITwspIUOiaYK/NW3azCIgpKI+4?= =?us-ascii?Q?Ow1OKEoKPGdffNRZryHzzwh9XTjYX+YxalvQDG0GYbPbwlSuUfQPVDNVxvH0?= =?us-ascii?Q?ALkZi1m/ZoqLe0luJoCQLVgWHwQ9gmRoYelxMBzPPLqlv5T7G+2kOPXrpyx4?= =?us-ascii?Q?rj//vBws4yIgbK9J28+/2YAlNBckm4dfhewU1KJlE+aLMsMJzyFIoB3hRaWD?= =?us-ascii?Q?Dtpm8uj4ld6C23fuoJYFiw0XRBJVqeRhHf2XEiInrv1kgVVa5EMQ1xPNycDw?= =?us-ascii?Q?k2T7YMadYDFWU4t1umM8YEsYTYwj5FOjw+eVyUG6xaQazKpXUHka3UT/dlmW?= =?us-ascii?Q?jMRtiF+craqMUZPZ5Xw6uvcIEdSKXuew2BoJgkFsbkSo5Q57BhLDK50KxZ15?= =?us-ascii?Q?y4JFgxsvwOODF35M1otNulJn/0pvffMe0LSXGxyQ/Uj9ajeosY4A2Qo/TZA7?= =?us-ascii?Q?yKynx+pSCiJKlYp7V2tgYmKu90NUnYenSsm/KK/64ZX1PX55Z495fuesL0ka?= =?us-ascii?Q?J+SUkHJ9YE=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2684;6:bJlpPIuJui0w2ijP9T7cm/0lNNOd19Vs93xblX0vkH+Qmg4LTM5/8j4bkzfOV09Y+Ue2JrYyKbIAZHb/TRchy2jFyI4btO758A4GvLYg6d0MYnpp5x+VkyNZGFlNQfwSqCxtzWrKRORbKOvDXAiz1OTAWgYr8/yf1+gRYOXBKpOM+mWi3tbe+ZCQrV+HIpz29B3GlcTcrgiJ+QHOYufxkZ4TLR7gFTSKD5ADV/70NTEiR3gCJUMYB5ej9dbzQ4KMSxRn84+mfRZvWcURXumU6vSzhwoKV13GOum+rcg9uWKSCyhndcvI2/Pci+I77y9BRPbrSjCMuzz5NmO8jyX8/l7FZlrfDv93gNgrMZYK149eait2KR+UE7kCCQ6VOfcc8KO8j9z2XdTylZguzjAY2qJpx7UW6b7y5wzVQUk7MZlHJ9b2DOeRQq4VBjI6hUnSkpe7PVMuvFcrwEyP53ndC5hGz5065WahLBTu3KbL1Mn5VL7IJmLzPWq1lsE15ADEdwsr3HAFKOuCLmiNsQJlOENccLtxhLn1GNJLtWINn1o= X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2684;5:NVchQiYrd3w+htMm61iypfc4gCNBAwIdOEQLs3JAzIdMlAApd4UahTjmWDL4Bj9/wq3OE0XD8hlw1S4s6+LiQHS4t6xQvE2F6RTp02QUYW4hRE+ItvOWgK1mytpW1Re0r5VUG2XAfOujsqg/XUmcNkSVDZ6jDQj5ncNchvMnCCe8xzJmnzLjf9JfWL8qzgoKA8PUJmJ/b2JkiObjUfqJYe6s3mUqvUg4A1bUQZKAKkphloX1uzyRUTx3uW3vrv54yMRbOMXl4fLpc3iaMP8iaEVcPiLXhUDOWpoIvdGAVgT/n5icJxUm3Cd5VU/+T0XcMDseiqYgKgHDRRCDzSbbyCnZ01/I4wVhYa33pu/kKf/aNrMVo3udQL2zkx6hGLd+rn17ELO9wdDniFLWHFFAoOrB4gttOFcf1s6YRNuOSwAnEHJ8L7r210Q8deSNaettCFkO0cbPJ3CbYUEab6dzgpo4PTiNf2+s/fuWRL2y+dt32g+5vjw/UHI7Kq+/u9Gl;24:eKrdTDeejvLUYq6QQiC3H12+3/GzW04fz3uaFTlp/ZJl0OZQzpv7AWhtKUcTV6cPZElpmhojFjhKg6v4L0rup+r/vOsmfHI+EiXdMeCY8Ec= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2684;7:JbvRE3ZAI2efQmWknHINtWFmsWsHi1FxtQ3P/wcBM7pCpRFVb8VYtYY+8gazqMairyWQknpLW0yVielx78qhfVdcehMDeBvCDndwHAfLlVVMrkbEfQTtPVgMGSN35pB0Qh3aArVMmTBiKQwNCzmjuYANAJQwkWelKCCdd+aOfLF+slR6DEjtXyPiHHZwi2UxkHgnjkq6vvAJFzGE0zkHCGNCESpbVNdy1RUJrVkYY1zu0Hk71Ti2UsLOoicKkb0JrI/aqY4Zn80Gk7+r3P3UMd+lc7QrCt761U2pbx41qD5CQbESnzRtIZAVofKTnE6/R+OPltTWo5JBWynk3j2YAA== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 13:42:11.7049 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2684 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At present USB 2.0 cameras fail to play when run for 2nd time or greater. This issue occurs only when previous endpoint cached ring is used instead of allocating a new endpoint ring. The root cause of the problem narrows down to the Toggle bit, which is not getting set on the last trb of the cached ring last segment. When the controller fetches the last link trb with no toggle bit set, abnormal behaviour is generated. This patch solves that problem by adding the TOGGLE bit for the last trb of the last segment of the cached ring. Signed-off-by: Anurag Kumar Vulisha --- drivers/usb/host/xhci-mem.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 1f1687e..3e59ba9 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -455,6 +455,14 @@ static void xhci_reinit_cached_ring(struct xhci_hcd *xhci, } while (seg != ring->first_seg); ring->type = type; xhci_initialize_ring_info(ring, cycle_state); + + /* Only event ring does not use link TRB */ + if (type != TYPE_EVENT) { + /* See xhci spec section 4.9.2.1 and 6.4.4.1 */ + ring->last_seg->trbs[TRBS_PER_SEGMENT - 1].link.control |= + cpu_to_le32(LINK_TOGGLE); + } + /* td list should be empty since all URBs have been cancelled, * but just in case... */ -- 2.1.1