From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdFARkW (ORCPT ); Thu, 1 Jun 2017 13:40:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50126 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbdFARkT (ORCPT ); Thu, 1 Jun 2017 13:40:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 71C1D80E7D Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=longman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 71C1D80E7D From: Waiman Long To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, Davidlohr Bueso , Dave Chinner , Waiman Long Subject: [PATCH v5 9/9] locking/rwsem: Enable reader lock stealing Date: Thu, 1 Jun 2017 13:39:07 -0400 Message-Id: <1496338747-20398-10-git-send-email-longman@redhat.com> In-Reply-To: <1496338747-20398-1-git-send-email-longman@redhat.com> References: <1496338747-20398-1-git-send-email-longman@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 01 Jun 2017 17:40:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rwsem has supported writer lock stealing for a long time. Reader lock stealing isn't allowed as it may lead to writer lock starvation. As a result, writers are preferred over readers. However, preferring readers generally leads to better overall performance. This patch now enables reader lock stealing on a rwsem as long as the lock is reader-owned and optimistic spinning hasn't been disabled because of long writer wait. This will improve overall performance without running the risk of writer lock starvation. Signed-off-by: Waiman Long --- kernel/locking/rwsem-xadd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c index a571bec..f5caba8 100644 --- a/kernel/locking/rwsem-xadd.c +++ b/kernel/locking/rwsem-xadd.c @@ -529,6 +529,14 @@ struct rw_semaphore __sched *rwsem_down_read_failed(struct rw_semaphore *sem) goto enqueue; /* + * Steal the lock if no writer was present and the optimistic + * spinning disable bit isn't set. + */ + count = atomic_long_read(&sem->count); + if (!count_has_writer(count)) + return sem; + + /* * Undo read bias from down_read operation to stop active locking if: * 1) Optimistic spinners are present; * 2) the wait_lock isn't free; or -- 1.8.3.1