From: Neil Brown <neilb@cse.unsw.edu.au>
To: dcinege@psychosis.com, mingo@redhat.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] Remove arbitrary md= boot device limit
Date: Tue, 30 Jan 2001 07:26:39 +1100 (EST) [thread overview]
Message-ID: <14965.53759.893603.65327@notabene.cse.unsw.edu.au> (raw)
In-Reply-To: message from Dave Cinege on Monday January 29
In-Reply-To: <3A755950.9C730B80@psychosis.com>
On Monday January 29, dcinege@psychosis.com wrote:
> linux-2.4.1p11-1/drivers/md/md.c
> line 3643
> -#define MAX_MD_BOOT_DEVS 8
> +#define MAX_MD_BOOT_DEVS MAX_MD_DEVS
>
> -------------------------------------------------------
> To: Dave Cinege <dcinege@psychosis.com>
>
> On Mon, 29 Jan 2001, Dave Cinege wrote:
>
> > -#define MAX_MD_BOOT_DEVS 8
> > +#define MAX_MD_BOOT_DEVS MAX_MD_DEVS
>
> sure this is fine.
>
> Ingo
Actually, this is not fine. Check the code that says:
if (minor >= MAX_MD_BOOT_DEVS) {
printk ("md: Minor device number too high.\n");
return 0;
} else if (md_setup_args.set & (1 << minor)) {
printk ("md: Warning - md=%d,... has been specified twice;\n"
" will discard the first definition.\n", minor);
}
..........
md_setup_args.set |= (1 << minor);
Note that "md_setup_args.set" is an unsigned long.
If minor >= 32, then we wont successfully set a bit in the set, and
things wont work right.
NeilBrown
> -------------------------------------------------------
> To: Ingo Molnar <mingo@redhat.com>
>
> Devices above md8 will not be initialized when speced with md=.
> Error ("md: Minor device number too high.\n");
>
> The limitation is imposed by
> #define MAX_MD_BOOT_DEVS 8
> However it appears arbitray to me. Doesn't make much sence since you can create
> /dev/md100 and it may well be the only md device you have...
>
> Is there any reason the next 2.4.1 prepatch should not include this?
>
> -#define MAX_MD_BOOT_DEVS 8
> +#define MAX_MD_BOOT_DEVS MAX_MD_DEVS
>
> (If not I assume you will be submitting this to Linus...)
>
> --
> "Nobody will ever be safe until the last cop is dead."
> NH Rep. Tom Alciere - (My new Hero)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-29 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-29 11:51 Dave Cinege
2001-01-29 20:26 ` Neil Brown [this message]
2001-01-29 20:53 ` [patch] raid-B1, 2.4.1-pre11, fixes, cleanups Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14965.53759.893603.65327@notabene.cse.unsw.edu.au \
--to=neilb@cse.unsw.edu.au \
--cc=dcinege@psychosis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®