From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbdFETyE (ORCPT ); Mon, 5 Jun 2017 15:54:04 -0400 Received: from mail-dm3nam03on0062.outbound.protection.outlook.com ([104.47.41.62]:26432 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751188AbdFETyC (ORCPT ); Mon, 5 Jun 2017 15:54:02 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; From: Yazen Ghannam To: linux-edac@vger.kernel.org Cc: Borislav Petkov , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, Yazen Ghannam Subject: [PATCH] x86/mce: Don't disable MCA banks when offlining a CPU on AMD systems Date: Mon, 5 Jun 2017 14:53:47 -0500 Message-Id: <1496692427-7991-1-git-send-email-Yazen.Ghannam@amd.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR2201CA0047.namprd22.prod.outlook.com (10.172.59.21) To BN6PR1201MB0130.namprd12.prod.outlook.com (10.174.114.143) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1201MB0130: X-MS-Office365-Filtering-Correlation-Id: 476aedec-0764-4a84-bf4e-08d4ac4c9bb3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR1201MB0130; X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0130;3:Dza/0kxU4LEyTLaEhd+ys6lQwJs4NCyoASYTDNux7YdYo+OGaAfn0j24pnuUJu2h316hyXNlD4uEG78PMSQmNSYZR0VeVDwYpDM3McFP5ixSq13UlkNG8JUrgRmnpTkx4G21pBKPhgsECL1SVbXS1JCrZz9H4a481nX2RJeB7Y6h4kYMmsYVKjxY0KKZrjccrHL4E6r09wjf4xG3JUdPXO0sz+Y5SR4cRctFqdOYMTLjxH63K5dzUleZJGlmH6IFmEBaT/6KL3qQkjhMQXgjTSmeqa6ZDU2/9URkZfRCf+PFJ2pYlzi2EwwjxtcE3QrOWR20LuQ+Ikizhy7DeNbxjGi4wtHBowsfV0qQjDmDBpw=;25:pH/VbmWhg+r1cBKWZYWBfqxKfkb/d/0LWQtkF2s3jn1IA/ip5ACfxP6CUDeSWURMbDVyNaHKOIIpoN+HCzKW2/AcSXdAIp2Bqc1AkuduWWOsy1bGzl0k9eS2h6GzmpjyS1Yfw+KVx4BQ0KZ7X0p4rXruu0bq6rzEYyCtSvsbx8ASlUlVTyy45Ar5PCWCMUVoJrnQosQarhyiAOCaYo5t3cKPmdKireoXuaL1BcVy+/O1vhRLsUxKXoqRDNhMHwA2vusY8URj/4sqSOTxuH65b/bj4TeYCDe6bBEXCL4XbRNWMpkfPlzHTnqEzyiq2XS8p/nERI7BA5V1fL/dLBQMVXiU7meVPF22G9pix4k5KtZctKdRdy4Thq9sDNhgO/5pGglrULACWtwPxZeaeageqOIk6oYp32ShTNgz9pcN2KG/CbaxaQxg5tTphAU8y1j+iZ/xMPfSxuwvvBDiun2eMfqUxdn4mjIUO3V9iYPm+Gs= X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0130;31:b1gUOxSSOyQ7kevxxCmX6KAcgJk+NdV1zv43VMEYPvrydlFw2M8CT5mfBf/ppXKMwIbn58z879Ecoe8OEdM2CzId14hW+IZ7h6jocWY0S8oOxfh21mtp8OFpR03IeqQFidmUYej0Ekt9DhZQfLLrwNNSYmJdUTZPRxRILLIFoO3y5NnLtl1bsaVJH192dJq1bJTjnerWuIIjhdLM5jC7TigbyBeec9cHmzMBOh52L90NXuD71lkEPmJeaXB3C9rL/zEeS+wwfnRyWG12XjqYqw==;20:4sz01hsbUYqpek/CxuCjntWZDhFZwphcCsx8Kfh/v+QI55xT+zogUSDHyzzBUdw44A7dcYbDHi7En/aZOHVChfZCNj6ndxu4pFCmIoZN7MdorLeTzxSDzhB6HT7H5/pEpH6ldgw53H528QNH1DX1idyUUEeNwT2Zujj8P7AtpwXx2Tkh4azPbdgd//ZvlU0AVQYjNZ5aNsiZAMxjvmY7uTwAGbz6fw0TgDHFDZjPGTAQeaIH+35OzsWamB21JwirQRiPot2HgBng/VrG36Fj04Xh6+jEpAPDINw5eZHBSPNOV+VTvKCgVwuDb5HDSRntyGW8D2u2CNo22+W7727ZkXrZ3bLcWQm0Rusldq2PIzEMhtxAgrAAlU/XfHLJNNMwXyKxliz2RfYP9flN3nkiYG9UL4JwSdzRzcTxk4KeM6nnrjYAYL+5Omw4tG9F0E2M1IgVmXCC8FuQPegjc0wRVGilIxbKS6w9IY8bzJfzzZ68Snuq7Ez/sxksNmjX40Wf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR1201MB0130;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR1201MB0130; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR1201MB0130;4:E1kBklnaeVySoc+FdSxNPX9Dxa9s0mZC8d9qvsJ9?= =?us-ascii?Q?SfWwR0T6nEkEty9gZlglI6b8aih4Vrsx3DLSKUscy9QxrvN53FZQGsZuRoC4?= =?us-ascii?Q?fsQjhjyEIsjL7oU0SiUkSNqeJKkGrIjSVszQP2wH3E1NGSf5nmk3+iUuwm9+?= =?us-ascii?Q?yKYf3GrXI/NnxQCXSOBVjZHC5m1BIc7f1w1GpoWsePDodlsCVsPNou6FS2aM?= =?us-ascii?Q?6N7xjrLgvCTIDsS6ygqNLUYqtwWLVMdu3D7HBGRpREZSxIUfxYxHzKnTEsSr?= =?us-ascii?Q?/HWG6qsSwSdNTt3Ieh7kVnKpPeHTl38T02fj5zT37Iu8G54TaEeTOSo5UqDN?= =?us-ascii?Q?Yh6s7yz0DfEclRqKy1HuI8YMIzbWWdkPx5xbAm7w7KgVdCul3EKW1/JVnbzj?= =?us-ascii?Q?iixhWZn0kqNsCdAwPnhDtXyHdEUf0GVILa18ABCKmMRZlDD6kQJcrMktQtMP?= =?us-ascii?Q?O+/Il53U8Y66yn+0R49P6pssBYuODB88Rkw1zPJHFN50wrK/z4z2yz1IP3Hu?= =?us-ascii?Q?TDVv5bH/R6u9m4yKwpsjbkbWEk0rSsiOiWC9pJFC4BGx28BRCZtLlx479yJq?= =?us-ascii?Q?HdipeucNHvNSuHjMpPHsFSkDWVr6cA8tYYTemOdBSUs1JMJTjuDLxYev2eM6?= =?us-ascii?Q?15CCeVbkB2/k82GuvhZ02SoSRaKZGU0PCnFlRFZHD2IIaNY7+mWb5xhPJFqW?= =?us-ascii?Q?3spE68EVszB0UflijQsXlUK23+9ao76Qlm40635KEx8UGOdPyg33oD4RHvEG?= =?us-ascii?Q?1yZ9c5ZWZdXb5ThyjIx8NWoe4tz+LgkNZjcw2m0HemHphKBjjPnpyg1CcxqA?= =?us-ascii?Q?hS78bXkrRU7AqesaahwGRHhcxdjKlh14Vw+uORhYrqUeQcsBg1davem5Ejgs?= =?us-ascii?Q?4eo1jT07WMf6Bb/tjeNaiIyBXhUiTe7mShGZJJi+xcUl973xkAiTbBUn7E0k?= =?us-ascii?Q?fnGdAtChT05Smj+sdTuaq3U3Fp9vt5bDXTjxKxhdjvpSVc3mOfZCgQClgyJJ?= =?us-ascii?Q?0jM6kD35b7KB9sxwteRxEpldP9meWFGD2yF3t6Xt5uJ/IR1G6O2Xe+cLpynu?= =?us-ascii?Q?pFSbaawnsgZCaUtqLvXhA7xCqs5Olgm6TUwQxr67vP9AfNQ/v/7xe98sK1ny?= =?us-ascii?Q?R43KJXVAUGWf4WhyobYMyDyuTH5VgdBtfcEwKtznbIUPltrVB10TjuZvx/xq?= =?us-ascii?Q?DTMx9ZyJhmVbDCP/1lzblpVjp8Siak6T9T5dIlifvS9rXE/LFglHqNyJQfWr?= =?us-ascii?Q?C43Eh+38EgQgqKbYwaQ=3D?= X-Forefront-PRVS: 0329B15C8A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39450400003)(39410400002)(39840400002)(39860400002)(39850400002)(39400400002)(5003940100001)(4326008)(2351001)(478600001)(50466002)(25786009)(7736002)(53936002)(305945005)(2361001)(36756003)(38730400002)(110136004)(53416004)(15650500001)(54906002)(47776003)(50226002)(189998001)(5660300001)(50986999)(6666003)(6916009)(2906002)(42186005)(72206003)(3846002)(81166006)(6116002)(8676002)(6486002)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR1201MB0130;H:yaz-diesel.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR1201MB0130;23:old/G2aXqVDQgWo+z5r36x6UL853fPF1JJ7AKcF?= =?us-ascii?Q?NgFmasD73Xp5NVbUYmsr9oBzPLqu/xn3+cQIpmr1IpNDM8JpEiFR5fvp7O4I?= =?us-ascii?Q?5FPiBPqIyYwD1F0Q3/I7v8olDZc2hv8dEyv0E9DBKtXHK5QdROKzum2/mHRS?= =?us-ascii?Q?whgoHYeSTlY6INOSeye5GtovhAyBDsAxzEDrPk9bVbOiloaYj+VY+OeDQg7B?= =?us-ascii?Q?3e2+DofXFdisSxG3TBOAJtz0fz1jodvPO5S+ZoNpBsRmDGCWScqTpgBgBV49?= =?us-ascii?Q?+6E6QIZ+4SL0nIrknp9Npmhrgmca1FAXkal1q1uUbtD56f3KN9XTapI/2he0?= =?us-ascii?Q?gQG8MDo55AXeW3MX/N83bfDyq3XYUfuE2iM7xTl14Py+TyxPxnCzo75YcD+W?= =?us-ascii?Q?NvwhTdv1+GhkppHaJmNR2TXf6nqefiRGA3IV17ArxD4jZKw5FxFtiYXE+qqe?= =?us-ascii?Q?9YCB8pZbbA7jtq/bTs7kjwur4AFq7GSoTBs3yJlBIhxZQ0htulIoebrgquY7?= =?us-ascii?Q?tt1RExEgJ2OcozNO05JjRgxgxGQmM1Od+KNi35RYEbiAFNzhJvraGsy/NEyS?= =?us-ascii?Q?DAlHn25As6JymjETI021zo4+dKsqXjKL4uzl+09vTKT5axVFELy7BBdajkAM?= =?us-ascii?Q?4PpUzsHhbeP00XElbW+3UW1+942eOmUY+U7Lb88lq687WjRQf/YldT/eajXL?= =?us-ascii?Q?Xrw+phYmoxzHHpzNb5INIHwlpu9CF5lQOKPJLbAtKz86X7w2ORW4cEaluaCU?= =?us-ascii?Q?LL/5ui+U6Op9AWGwo5KycNxq9iFk0ZXFAg/exDn1dIhcUDVUyhL13eZQ3ByX?= =?us-ascii?Q?kV8ftVxtGT/meghiO1gGeyVNW2S74JJC3jaJO9lWN4ktW6AuQ9L24fkYU86W?= =?us-ascii?Q?uL4OCeHbudjH+UNcV94KVIJXVX/E5KYr1+DSdMhBAY00BnV4COydVtq4HA0C?= =?us-ascii?Q?pKK6XVLb4BRJy9tAYxyj4uQDkh6tNmlFDl8mCn3mTA2lScN8TMV7APmciwKd?= =?us-ascii?Q?UnlCwQRlf6KULGVjvZaK5YVRCdItyBUEmKWHJ2KTocejVxg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0130;6:yNZtkBrwkUy9VGnCZDrUrGFEORH+qds1mV3ACvVU79JrJ2z4/Hrjz//9Eh2oq9In8hwRH5/Gg1RHpaf4Ok+dzafkSV6YIZE+crfqEZ9WVNye1Re2pq0W+zoIj0i1iF0dTNStq4P8qxWzvGozxukFpvswSrT3xiZF97s8U72keeUemVkbL3JCwv2ESylhkTjLbaxhTpq24MNTyRfUAdY852NuhEoYVnIhwELy1v4KOrslgSYeYXtuMEyip6dqXpH+ixGS/16mNfT7ItWHBjkZdXHxBOp1KdSC/WNLRpXFJB1VMTF6u+VdI/rm74/49LkZjuG+KOExCQjXu6VKs3aj7SkUPXf9sK6oSCrVNDubr60GgUheybzvBaa/hU7HKHsISpHCzLdx0C14fMR7nSSDyHY1NRBM9PmARpNNcxx3rvfseiJwtcypTGfiKGWJoiGPXwadGnxppXdmom/tW0XG4/nGoks/qAFoIhd9gXUgw3t6bb6Uc3B4yiYXmDT1XXHmWtmmP5rzc6bfFy791IYiQRHZVpjyu2aX1OAC5p2EpEY= X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0130;5:IlzdZJCYudYpR06Q8hdAuD806HmTyecbnIICRm3emCv6v4hnhSYeqfhOSz4EiC8r0Rlr8GSa5dwBEYmGeDiI3GjMSNm9dOn8VEIlaFcRTIogqEBQDm+V78QGTn9zpt/HpOh2WQ5fc1oMQ3u98433gKkGE9W7G5EUWDmebWRHtoBOY/ikrDkXwjzB2Ek9WbmCnLYlD7k3fseKbR8OafHsLNatfzeHbviQdAWuqJpMjDBCLzYTZn1jwxmRe3HXeH6MIgXod7Ly++Jzhyy27Y+T6MivamYNn71jUW9KesK7C7BzggNd5ggJRTtEfmWgvfR29EA+AJDuFytFm0y+ma4RMMEJNWOxpRS8Iws8fXk4T8vnzaWCh50TBvBxu24fNs4S+SC5SrLF5RDsUn4ZIXnjJAEN0gikYtJZjJkq2dAAdEG5XF8DRUAM55jRlWVz+GG73CCk/GZ6zZA1bLCCpZxzDbqvaEWYSoKd3JtnJCkY1+voSH/KnfbMszz948Ks5wqJ;24:eqUeBtpEq2SaDYSCG/swRRaxxYNEyuBN0hqW2UtopPvM2hOkkkO4q9R7rRrUnMQxw/Vl1WRTv5LllZbzJ5BUxyb4ZXtdq0VYnbns/leq9Rk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0130;7:5rJnxbAs+e0CrhrEENqQOER/qlzGSXvJ6UZnC/o99YDKEg0JGWE5zdjGoQf0hKGWxQrKwH5SM6lt2tjHBaX2+yHo3AAsJoQvMn+laOUeg3/XnCi8O5O20mmOsLz+eh7XdP7csOHHaotzFOLv/qdtUWtlqLPdQkp3lTzkKxZQaRn17dGnXY/NQfKMghBczF2+723/W24ymnUDhnEbtD6NQYQyPXxTmvqtlwNFAvkdeXhPOqKyXLcJLeR+OUZw+pn98qldqeJ/B5sZXAc4omjw6PvnOuYBJXRqk46HlDETVTwd1WIaAxY3RFVVaiyw3f3PfpIS52mmIYJylNkqElJ1Lg==;20:YZZ5mq7OV2jP9FZ2jQasLCXUJPZOZbOY4WxreSMJLXMSnHyBl3haMg+LWIWzDcbfJCJn4xbD8P2E9PTyQpLxRm4lMBPVcdbBPtbKVit46XtuNQkCnzgAqnm9Z0qtdbls4QAKe+4CRdsE2l6xHOFCDu98gzBpn4t4wuBLblEM1QpiximQm7o0GBpoTu2u/9sXH+8jp2/en1DP1rjoqpTqLLPQDabAsCWzCmf8lNN7+qXvL5RS0JF5QTGm/ZxcEqbo X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2017 19:53:58.2402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yazen Ghannam AMD systems have non-core, shared MCA banks within a Die. These banks are controlled by a master CPU per Die. If this CPU is offlined then all the shared banks are disabled in addition to the CPU's core banks. Also, Fam17h systems may have SMT enabled. The MCA_CTL register is shared between SMT thread siblings. If a CPU is offlined then all its sibling's MCA banks are also disabled. Do a vendor check for AMD and return early when offling a CPU. Signed-off-by: Yazen Ghannam --- arch/x86/kernel/cpu/mcheck/mce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 5cfbaeb..e317a95 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -1917,7 +1917,8 @@ static void vendor_disable_error_reporting(void) * inhibit reporting for all shared resources on the socket like the * last level cache (LLC), the integrated memory controller (iMC), etc. */ - if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) + if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL || + boot_cpu_data.x86_vendor == X86_VENDOR_AMD) return; mce_disable_error_reporting(); -- 2.7.4