From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764AbdFGIuc (ORCPT ); Wed, 7 Jun 2017 04:50:32 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7387 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdFGIua (ORCPT ); Wed, 7 Jun 2017 04:50:30 -0400 From: zhongjiang To: CC: , , , Subject: [PATCH] mm: correct the comment when reclaimed pages exceed the scanned pages Date: Wed, 7 Jun 2017 16:31:06 +0800 Message-ID: <1496824266-25235-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.5937BB0B.0088,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b79cb2124ac4af0d69396811ecd416f5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit e1587a494540 ("mm: vmpressure: fix sending wrong events on underflow") declare that reclaimed pages exceed the scanned pages due to the thp reclaim. it is incorrect because THP will be spilt to normal page and loop again. which will result in the scanned pages increment. Signed-off-by: zhongjiang --- mm/vmpressure.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/vmpressure.c b/mm/vmpressure.c index 6063581..0e91ba3 100644 --- a/mm/vmpressure.c +++ b/mm/vmpressure.c @@ -116,8 +116,9 @@ static enum vmpressure_levels vmpressure_calc_level(unsigned long scanned, /* * reclaimed can be greater than scanned in cases - * like THP, where the scanned is 1 and reclaimed - * could be 512 + * like reclaimed slab pages, shrink_node just add + * reclaimed page without a related increment to + * scanned pages. */ if (reclaimed >= scanned) goto out; -- 1.7.12.4