From: Stefan Schoefegger <stefan.schoefegger@ginzinger.com>
To: <linux-pci@vger.kernel.org>
Cc: Stefan Schoefegger <stefan.schoefegger@ginzinger.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Jingoo Han <jingoohan1@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:PCI DRIVER FOR IMX6"
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option
Date: Wed, 7 Jun 2017 13:36:11 +0200 [thread overview]
Message-ID: <1496835374-13053-1-git-send-email-stefan.schoefegger@ginzinger.com> (raw)
In-Reply-To: <1472121518-9340-1-git-send-email-stefan.schoefegger@ginzinger.com>
Link speed must not be limited to gen1 during link test for compliance
tests
Signed-off-by: Stefan Schoefegger <stefan.schoefegger@ginzinger.com>
---
Changes since v1:
- pci-imx6.c moved to dwc directory
drivers/pci/dwc/Kconfig | 10 ++++++++++
drivers/pci/dwc/pci-imx6.c | 21 ++++++++++++---------
2 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig
index b7e15526d676..b6e9ced5a45d 100644
--- a/drivers/pci/dwc/Kconfig
+++ b/drivers/pci/dwc/Kconfig
@@ -77,6 +77,16 @@ config PCI_IMX6
select PCIEPORTBUS
select PCIE_DW_HOST
+config PCI_IMX6_COMPLIANCE_TEST
+ bool "Enable pcie compliance tests on imx6"
+ depends on PCI_IMX6
+ default n
+ help
+ Enables support for pcie compliance test on FSL iMX SoCs.
+ The link speed wouldn't be limited to gen1 when enabled.
+ Enable only during compliance tests, otherwise
+ link detection will fail on some peripherals.
+
config PCIE_SPEAR13XX
bool "STMicroelectronics SPEAr PCIe controller"
depends on PCI
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index 19a289b8cc94..b0fbe52e25b0 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -533,15 +533,18 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie)
u32 tmp;
int ret;
- /*
- * Force Gen1 operation when starting the link. In case the link is
- * started in Gen2 mode, there is a possibility the devices on the
- * bus will not be detected at all. This happens with PCIe switches.
- */
- tmp = dw_pcie_readl_dbi(pci, PCIE_RC_LCR);
- tmp &= ~PCIE_RC_LCR_MAX_LINK_SPEEDS_MASK;
- tmp |= PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN1;
- dw_pcie_writel_dbi(pci, PCIE_RC_LCR, tmp);
+ if (!IS_ENABLED(CONFIG_PCI_IMX6_COMPLIANCE_TEST)) {
+ /*
+ * Force Gen1 operation when starting the link. In case the
+ * link is started in Gen2 mode, there is a possibility the
+ * devices on the bus will not be detected at all. This
+ * happens with PCIe switches.
+ */
+ tmp = dw_pcie_readl_dbi(pci, PCIE_RC_LCR);
+ tmp &= ~PCIE_RC_LCR_MAX_LINK_SPEEDS_MASK;
+ tmp |= PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN1;
+ dw_pcie_writel_dbi(pci, PCIE_RC_LCR, tmp);
+ }
/* Start LTSSM. */
if (imx6_pcie->variant == IMX7D)
--
2.11.0
next parent reply other threads:[~2017-06-07 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1472121518-9340-1-git-send-email-stefan.schoefegger@ginzinger.com>
2017-06-07 11:36 ` Stefan Schoefegger [this message]
2017-06-12 23:49 ` Bjorn Helgaas
2017-06-13 2:00 ` Richard Zhu
2017-06-13 5:55 ` Schöfegger Stefan
2017-06-13 5:43 ` Schöfegger Stefan
2017-06-13 13:58 ` Bjorn Helgaas
2017-06-14 5:52 ` Schöfegger Stefan
2017-06-14 19:11 ` Fabio Estevam
2017-06-19 6:43 ` Schöfegger Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496835374-13053-1-git-send-email-stefan.schoefegger@ginzinger.com \
--to=stefan.schoefegger@ginzinger.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®