From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdFGV7i (ORCPT ); Wed, 7 Jun 2017 17:59:38 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:52799 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdFGV7g (ORCPT ); Wed, 7 Jun 2017 17:59:36 -0400 From: Darwin Dingel To: Pavel Machek CC: Boris Brezillon , "richard@nod.at" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "cyrille.pitchen@atmel.com" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "mark.marshall@omicronenergy.com" , "b44839@freescale.com" , "prabhakar@freescale.com" Subject: Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Thread-Topic: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages Thread-Index: AQHS1a9YfHoXWHxki0Gq0osrnQN2hKIOQmcAgAvEYpk= Date: Wed, 7 Jun 2017 21:59:32 +0000 Message-ID: <1496872770936.46522@alliedtelesis.co.nz> References: <5f665145ea304d3a9e1ecb39c51a951e@svr-chch-ex1.atlnz.lc> <20170531204913.GC16962@amd> <95d9297bf6604c1f8fe9c36a231b8a06@svr-chch-ex1.atlnz.lc>,<20170531221554.GA25597@amd> In-Reply-To: <20170531221554.GA25597@amd> Accept-Language: en-NZ, en-US Content-Language: en-NZ X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.32.1.10] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v57LxgrQ028730 Hi Pavel, Looks like uboot has similar IFC driver. Do you have plans to apply this change to uboot as well? Cheers, Darwin ​ From: Pavel Machek Sent: Thursday, 1 June 2017 10:15 a.m. To: Darwin Dingel Cc: Boris Brezillon; richard@nod.at; dwmw2@infradead.org; computersforpeace@gmail.com; marek.vasut@gmail.com; cyrille.pitchen@atmel.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; mark.marshall@omicronenergy.com; b44839@freescale.com; prabhakar@freescale.com Subject: Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages   Hi! > > You meen "errors = 0"? Does that actually make a difference? It is a > > local variable, and continue makes sure the value is not used: > > > > I missed the 'continue' statement there. In that case we don't need to > reset 'error'. Yes, thanks, I wanted to double-check. If you could take a look at PATCHv2 -- it should have the problems fixed. Your Acked-by would be nice ;-). Thanks a lot,                                                                         Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html