From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, pjt@google.com, luto@amacapital.net,
efault@gmx.de, torvalds@linux-foundation.org,
Waiman Long <longman@redhat.com>
Subject: [PATCH-cgroup 3/5] cgroup: Make Kconfig prompt of debug cgroup more accurate
Date: Tue, 13 Jun 2017 17:18:03 -0400 [thread overview]
Message-ID: <1497388685-31207-4-git-send-email-longman@redhat.com> (raw)
In-Reply-To: <1497388685-31207-1-git-send-email-longman@redhat.com>
The Kconfig prompt and description of the debug cgroup controller
more accurate by saying that it is for debug purpose only and its
interfaces are unstable.
Signed-off-by: Waiman Long <longman@redhat.com>
---
init/Kconfig | 7 +++++--
kernel/cgroup/debug.c | 6 ++++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 1d3475f..5f9d139 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1205,11 +1205,14 @@ config CGROUP_BPF
inet sockets.
config CGROUP_DEBUG
- bool "Example controller"
+ bool "Debug controller"
default n
+ depends on DEBUG_KERNEL
help
This option enables a simple controller that exports
- debugging information about the cgroups framework.
+ debugging information about the cgroups framework. This
+ controller is for control cgroup debugging only. Its
+ interfaces are not stable.
Say N.
diff --git a/kernel/cgroup/debug.c b/kernel/cgroup/debug.c
index 1c209aa..cbe77a2 100644
--- a/kernel/cgroup/debug.c
+++ b/kernel/cgroup/debug.c
@@ -1,3 +1,9 @@
+/*
+ * Debug controller
+ *
+ * WARNING: This controller is for cgroup core debugging only.
+ * Its interfaces are unstable and subject to changes at any time.
+ */
#include <linux/ctype.h>
#include <linux/mm.h>
#include <linux/slab.h>
--
1.8.3.1
next prev parent reply other threads:[~2017-06-13 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 21:18 [PATCH-cgroup 0/5] cgroup: Make debug controller useful for debugging Waiman Long
2017-06-13 21:18 ` [PATCH-cgroup 1/5] cgroup: Keep accurate count of tasks in each css_set Waiman Long
2017-06-13 21:18 ` [PATCH-cgroup 2/5] cgroup: Move debug cgroup to its own file Waiman Long
2017-06-13 21:18 ` Waiman Long [this message]
2017-06-13 21:18 ` [PATCH-cgroup 4/5] cgroup: Make debug cgroup support v2 and thread mode Waiman Long
2017-06-13 21:18 ` [PATCH-cgroup 5/5] cgroup: Enable debug controller only with cgroup_debug boot option Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497388685-31207-4-git-send-email-longman@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome