From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Byron Stanoszek <gandalf@winds.org>, linux-kernel@vger.kernel.org
Subject: Re: NFS stop/start problems (related to datagram shutdown bug?)
Date: Tue, 6 Feb 2001 10:27:16 +0100 (CET) [thread overview]
Message-ID: <14975.50036.444871.571598@charged.uio.no> (raw)
In-Reply-To: <14975.15829.623996.534161@notabene.cse.unsw.edu.au>
In-Reply-To: <Pine.LNX.4.21.0102051728340.1460-100000@winds.org> <14975.15829.623996.534161@notabene.cse.unsw.edu.au>
>>>>> " " == Neil Brown <neilb@cse.unsw.edu.au> writes:
> The attached patch might fix it, so if you are having
> reproducable problems, it might be worth applying this patch.
> Trond: any comments?
> +
> + spin_lock_bh(&serv->sv_lock);
> if (!--(svsk->sk_inuse) && svsk->sk_dead) {
> + spin_unlock_bh(&serv->sv_lock);
> dprintk("svc: releasing dead socket\n");
> sock_release(svsk->sk_sock);
> kfree(svsk);
> }
> + else
> + spin_unlock_bh(&serv->sv_lock);
> }
Looks correct, but there's a similar problem in svc_delete_socket()
(see the setting of sk_dead, and subsequent test for sk_inuse).
Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-06 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-05 22:35 Byron Stanoszek
2001-02-05 22:42 ` Alan Cox
2001-02-05 22:47 ` Byron Stanoszek
2001-02-05 23:57 ` Neil Brown
2001-02-06 0:43 ` Byron Stanoszek
2001-02-06 1:18 ` Neil Brown
2001-02-06 9:27 ` Trond Myklebust [this message]
2001-02-06 14:33 Byron Stanoszek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14975.50036.444871.571598@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=gandalf@winds.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®