mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Luis Ressel <aranea@aixah.de>, Paul Moore <paul@paul-moore.com>,
	Eric Paris <eparis@parisplace.org>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"moderated list:SELINUX SECURITY MODULE" <selinux@tycho.nsa.gov>,
	"open list:SECURITY SUBSYSTEM" 
	<linux-security-module@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selinux: Assign proper class to PF_UNIX/SOCK_RAW sockets
Date: Mon, 19 Jun 2017 16:10:59 -0400	[thread overview]
Message-ID: <1497903059.27645.9.camel@tycho.nsa.gov> (raw)
In-Reply-To: <20170618214532.3031-1-aranea@aixah.de>

On Sun, 2017-06-18 at 23:45 +0200, Luis Ressel wrote:
> For PF_UNIX, SOCK_RAW is synonymous with SOCK_DGRAM (cf.
> net/unix/af_unix.c). This is a tad obscure, but libpcap uses it.

No Signed-off-by?

Feel free to add my:
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

> ---
>  security/selinux/hooks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 819fd6858b49..1a331fba4a3c 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -1275,6 +1275,7 @@ static inline u16
> socket_type_to_security_class(int family, int type, int protoc
>  		case SOCK_SEQPACKET:
>  			return SECCLASS_UNIX_STREAM_SOCKET;
>  		case SOCK_DGRAM:
> +		case SOCK_RAW:
>  			return SECCLASS_UNIX_DGRAM_SOCKET;
>  		}
>  		break;

  reply	other threads:[~2017-06-19 20:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-18 21:45 Luis Ressel
2017-06-19 20:10 ` Stephen Smalley [this message]
2017-06-19 21:33 Luis Ressel
2017-06-20 19:49 ` Paul Moore
2017-06-20 20:04   ` Stephen Smalley
2017-06-20 21:43     ` Paul Moore
2017-06-21  9:48       ` Luis Ressel
2017-06-21 19:04         ` Paul Moore
2017-07-10 22:25           ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497903059.27645.9.camel@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=aranea@aixah.de \
    --cc=eparis@parisplace.org \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=selinux@tycho.nsa.gov \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®