From: Sumit Semwal <sumit.semwal@linaro.org>
To: shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: keescook@chromium.org, decot@googlers.com,
linux-kernel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: [PATCH v3] selftests: lib: Skip tests on missing test modules
Date: Tue, 20 Jun 2017 10:18:18 +0530 [thread overview]
Message-ID: <1497934098-15995-1-git-send-email-sumit.semwal@linaro.org> (raw)
With older kernels, printf.sh and bitmap.sh fail because they can't find
the respective test modules they are looking for.
Use modprobe dry run to check for missing test_XXX module. Error out with
the same error code as prime_numbers.sh.
v3: As pointed out by Kees, modules can be in-built too, so use 'modprobe
-q -n' to check presence of the module, instead of 'find ..'.
v2: Per Shuah's review, search for the module rather than do modprobe.
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
---
tools/testing/selftests/lib/bitmap.sh | 4 ++++
tools/testing/selftests/lib/printf.sh | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/tools/testing/selftests/lib/bitmap.sh b/tools/testing/selftests/lib/bitmap.sh
index 2da187b6ddad..b073c22a3435 100755
--- a/tools/testing/selftests/lib/bitmap.sh
+++ b/tools/testing/selftests/lib/bitmap.sh
@@ -1,5 +1,9 @@
#!/bin/sh
# Runs bitmap infrastructure tests using test_bitmap kernel module
+if ! /sbin/modprobe -q -n test_bitmap; then
+ echo "bitmap: [SKIP]"
+ exit 77
+fi
if /sbin/modprobe -q test_bitmap; then
/sbin/modprobe -q -r test_bitmap
diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
index 4fdc70fe6980..cbf3b124bd94 100755
--- a/tools/testing/selftests/lib/printf.sh
+++ b/tools/testing/selftests/lib/printf.sh
@@ -1,5 +1,9 @@
#!/bin/sh
# Runs printf infrastructure using test_printf kernel module
+if ! /sbin/modprobe -q -n test_printf; then
+ echo "printf: [SKIP]"
+ exit 77
+fi
if /sbin/modprobe -q test_printf; then
/sbin/modprobe -q -r test_printf
--
2.7.4
next reply other threads:[~2017-06-20 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 4:48 Sumit Semwal [this message]
2017-06-23 16:11 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497934098-15995-1-git-send-email-sumit.semwal@linaro.org \
--to=sumit.semwal@linaro.org \
--cc=decot@googlers.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®