From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196AbdFUC5w (ORCPT ); Tue, 20 Jun 2017 22:57:52 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:38897 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752990AbdFUC5v (ORCPT ); Tue, 20 Jun 2017 22:57:51 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="20292455" From: Dou Liyang To: , , CC: Dou Liyang , David Rientjes , Michal Hocko , Subject: [PATCH v2] mm: Drop useless local parameters of __register_one_node() Date: Wed, 21 Jun 2017 10:57:26 +0800 Message-ID: <1498013846-20149-1-git-send-email-douly.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.5.5 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 0A4D447C6D37.A15FE X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... initializes local parameters "p_node" & "parent" for register_node(). But, register_node() does not use them. Remove the related code of "parent" node, cleanup __register_one_node() and register_node(). Cc: Andrew Morton Cc: David Rientjes Cc: Michal Hocko Cc: isimatu.yasuaki@jp.fujitsu.com Signed-off-by: Dou Liyang Acked-by: David Rientjes --- V1 --> V2: Rebase it on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm drivers/base/node.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 73d39bc..d8dc830 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -288,7 +288,7 @@ static void node_device_release(struct device *dev) * * Initialize and register the node device. */ -static int register_node(struct node *node, int num, struct node *parent) +static int register_node(struct node *node, int num) { int error; @@ -567,19 +567,14 @@ static void init_node_hugetlb_work(int nid) { } int __register_one_node(int nid) { - int p_node = parent_node(nid); - struct node *parent = NULL; int error; int cpu; - if (p_node != nid) - parent = node_devices[p_node]; - node_devices[nid] = kzalloc(sizeof(struct node), GFP_KERNEL); if (!node_devices[nid]) return -ENOMEM; - error = register_node(node_devices[nid], nid, parent); + error = register_node(node_devices[nid], nid); /* link cpu under this node */ for_each_present_cpu(cpu) { -- 2.5.5