From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbdFUTrA (ORCPT ); Wed, 21 Jun 2017 15:47:00 -0400 Received: from mail-bl2nam02on0040.outbound.protection.outlook.com ([104.47.38.40]:8474 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751028AbdFUTq5 (ORCPT ); Wed, 21 Jun 2017 15:46:57 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; From: Yazen Ghannam To: linux-edac@vger.kernel.org Cc: Borislav Petkov , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, Yazen Ghannam Subject: [PATCH v2] x86/mce: Always save severity in machine_check_poll Date: Wed, 21 Jun 2017 14:46:42 -0500 Message-Id: <1498074402-98633-1-git-send-email-Yazen.Ghannam@amd.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR1001CA0015.namprd10.prod.outlook.com (10.174.165.28) To BN6PR1201MB0131.namprd12.prod.outlook.com (10.174.114.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb643bc9-7edf-476d-f47a-08d4b8de4619 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR1201MB0131; X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0131;3:EvWAGsiMc5qORAtn+kndiBdU2eeB+SWre4PwHg0sueMXkmIeTc3ZRx9O8Wa/OnhrU4BhL8xtpFpoCXtZszvc6PKxPEUYx3jnx7Dp9NG83qR4a3EyyuC78tVYkQq02NBh8L3yiYc1SCy+H2F16eWdjeE1h5r80+FyYY//DpybrwWKPmx60d82KjtLzT34gIgE+/I7x8Xya61vP3BCnc9XV85WLZHq0n5ha0FjFbcnrRglkwN9eN7PnijvUDFHWkcTq+qFDOFcYclW63il/jd/GIW0XOxJkhmYBMLkKggf9Os+tUIpCP71GVbr4VjU78qGr0nEHWOITUNIqegmB8EyTAloZltAECQXiH+DPNwCBrQ=;25:uSoiQQ7q2ovtBX8Uw+Bn+bFs/Elcfva0gxITG2pK/7wi6CgI85bvJyAG3cbfR6yKz+WgGZkPdRTDLOiNx4MngGi79J6sV5On0bKeBDlEO6MRqjHwRa8hteEt+GK/tXW4E8iXVLCmkVs6rPyrtcBlKwG4l9a/9WrMf7Ula5OKpifHux7MYgLRvK5w7xTPMT2KOjLnrECnczlJJtZRjyLO2k5HVc1SRqDoyT0AjtTztgHjbnLZJe/GRf6N//o+UpyApOVIc2mDo2O24EuDZ0Iwq2pGFBTukMh2GDuxJ9272gdYJpiIKMsKc0ZltC2ytr7qrNBTDN1LNX5FisCFyDUC6DZcjUMMnoSO9MhFRaerXurBaN8Zfl5Ce7TO/Dtqr6FXKKpW0a+Nanf1BlEf0LZJxCMK1mrFCtUign7Sy/2IfB0h+jBDtWd0XvyzM2VD61/kNh74Jqz8RjtZmvXnCb1dRL+L4lzOb5i0S15/hyojv6I= X-MS-TrafficTypeDiagnostic: BN6PR1201MB0131: X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0131;31:xrpQYaKPzOR6HpiKMkSSmm3ewiXDYX/iZXNZ9gE1meMVNZue7o7ocpb2iIpvCRa1aZP2UV109953z+XuWcO7EqFX1EkEcw1rHepvJNgOSwyD/QP6Fh7izS1umxh5U8C9t8RBamkj3+FWIX4BA5sd+FJub5fKKqD0+5XytL3Fc1Tks9hSYPjDx1NPkjZRz25oIKSDVjPpBw+4L7yWrJ/QTBIWehwJKLbw7MJVO4aJiEA=;20:ynvjxNuJtaBt375yQDansH5HId2DZNogwPQVwkE0LqUDU9mW97LeEMn1/WauA5T9JM8czjGsUgpbPKKBD3pN7yfU4iPdf7oQFeSb/gwzg8L0YKY1GoRq7QpHTGcE5oQyN/RFcd00TNjgg/uPPt4jwJ3FFtdVZPU96V5ujYl8nz/dm8kGXV23qpUK6yO8iwUm7xobR2K7izii/A6gLu36JJqcYSU/ommgRKkAhJrNPHYEn/ebOvl3cLGx5zKHvYPb2dzcz8LXGjgnWFFP6Ppa0jq7XFFXibSUz7Dcf9J9Fin6bLMcSk9V4mvBUnQWdmPtGu3M0GZBaADfWAsc5DBED03faxflTTCP3d5gy+xwoMcuN5FDPed4QHC/oVru9sY496+CadqrAUs27nnXVzfbICRZk4JC/klS82bv+53iQKo21HtmurfXxN7pW7HEZdHqNmBU8AN1IZUhCCmdlrHCYd3/XGIpfQlQnmsy6HCWZl26yjXWaOvIyP8jVCZRYb89 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(42068640409301); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR1201MB0131;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR1201MB0131; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR1201MB0131;4:uRopVNM062sy4/v5lownfWDtIlLRftO30L5rYxJi?= =?us-ascii?Q?uud8POl/WNxJg8/1ct3vdRzczwu8j/HuwDFYGUtaQkDgrEZSIygmRNVKufzz?= =?us-ascii?Q?p7f7UtLe/o2V9239qMmLW5O3Ngzq0Ykv+uYHprKv2PJN4dLfU+tNbvFXuZWb?= =?us-ascii?Q?Zm7ErnPCnHGZwVN4SOQTtNKn4l+gyBA2IKPCZxNXlKsCL+gEeC7FJLIsW5Eg?= =?us-ascii?Q?0Roh4VO3IY6fFzeiRxsAeq2hdw73DMhVR6hYfSiLEmmajeNOrYjvvgXCUwEp?= =?us-ascii?Q?7H/j7L3bkX/Td/Fl/hhVtRn7w9LMi6Ci/ttb7ZTlU+EgMFXnjjOSDpyfDobt?= =?us-ascii?Q?IlWB8zHus3keMkNpNgwAW5yifQ/Q7nLOVqB0AuEohDm4ReAzwd7cKmWMDeKb?= =?us-ascii?Q?kgkKNjHK6454a05x4sBjBOsbyhRgcWVQ+dWdcyEugzAUyZuWYBujAOahlHhV?= =?us-ascii?Q?mbXxk4Owl1skosmD/icbfOfrkU/QBaILTu7IgrfofaVuz0onQjQMCzwNH1nT?= =?us-ascii?Q?UqUn5kaqHddbmLZIYQYhXBPBIBA+fQCMOfNp+sEo8rvMM7ZZQYalgXaeJ8of?= =?us-ascii?Q?PYg3xsX8nuIFBQQQC135YLOGe8X0wmSnJTC/Uc6lMS4jWFJgNtek2q2h3NtE?= =?us-ascii?Q?2UnoIxVukRiaKIzlfbAqF9Uo5AZpf/5I+qMRmdco1fedOcVZTaLlbekrEFA1?= =?us-ascii?Q?uclBgiQrOF5dO5oipBx+TA4FNIbjwUCYkdBoAvkO2cMODExvU2D1CYoF63nQ?= =?us-ascii?Q?D/J3Q0zL39ThhZhIc4GEtGdQC6VREGbBPNBxROE0JarwySdDLx/PlWxLAgR4?= =?us-ascii?Q?jyaADtn8eDaUOw7eCXl1YfEKDTJiakjGwv/9Sa6QZ7qBVnYWSddojyf6AaZK?= =?us-ascii?Q?EJXY5U5xVNmWftOpAO4Vz1RyoWRBSEyGVf9vEeWnzamV3WR+IFbvWTY2lQg6?= =?us-ascii?Q?gb43o23Cie8HdpcDZC4GZ4SRSCiS/b0m8uWbMrCPbb08sfgL9KXRtGCde3pb?= =?us-ascii?Q?9KQ76pCtZ3MTEj6w1Ki8eaVskTw5OyGA1vXzLjQ9eZSX64QIXDEkJjhUlKIL?= =?us-ascii?Q?34kRcvO1072m3JViaLJ6sBlKMSK/bVYZtpiDcz9aM8GgsrX8XWDVwP3XxjYx?= =?us-ascii?Q?+FspI1MS+TNBioR303/kKLa2YmLCcRFKB+A37tkjM0ywkRwe0uZqll0PRkFd?= =?us-ascii?Q?i150ZoEFd4yiG0KExlDEJy4kBI2Eo8Q9N6Ao0rNLbKaOiDqLhr0q7dlEu6c1?= =?us-ascii?Q?LQCNm+LWvD2sjIfxZqc=3D?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39400400002)(39410400002)(39850400002)(39860400002)(39450400003)(5660300001)(72206003)(50986999)(8676002)(48376002)(50466002)(5003940100001)(189998001)(2351001)(2361001)(2906002)(305945005)(53416004)(478600001)(36756003)(42186005)(47776003)(6306002)(54906002)(6486002)(86362001)(4326008)(110136004)(38730400002)(53936002)(7736002)(66066001)(6666003)(966005)(25786009)(50226002)(3846002)(6116002)(81166006)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR1201MB0131;H:yaz-diesel.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR1201MB0131;23:3HJNUz0SpDAidigf+m8uFxjxhh7XSgLYTCwFUFc?= =?us-ascii?Q?8Gbk4q9dM7m6NNQ+pwee2csdi0XTHraj6Pv9pmGogeb5UNDsGeeyYrs/es9o?= =?us-ascii?Q?PeveG6bTbyNBBa786yHUzQ0hSobbCbn5r9xJdXXxn9W+a3rAPY8QASpJtahV?= =?us-ascii?Q?W9FHHpO78m7acx8FtKO+//UkhKkDy9q+ccfJzgkIHXuZMIo9S2VjrNp6GHl7?= =?us-ascii?Q?A7yDjMlrM7bLox1f+ZO5ObeSmsPjopxYBdVbXYQcc5tdtQW3+4BUcLTxjqeJ?= =?us-ascii?Q?5WaAaSC7cXr81iunYpGnzB9sppDH/s51vcyp+DzT9zLa+YhPT20IvH1Qwtri?= =?us-ascii?Q?f8zTfwr88/m65YKS86/v5j3svriQv9ILU1cqiRX3jynl6CHpoz2lNGGS/MmU?= =?us-ascii?Q?8IE+64a6DJH4xBy7FRTLrST/t13Q48HHjJ1aoK1//bD8TRKFGWAFc8JqeN1O?= =?us-ascii?Q?UDAc0beCbGy73YP2cjNRCTSIGTCvOgHi618n7BIu6dw//A/VHPaVsrWrKhT4?= =?us-ascii?Q?t9gq8bFTfu2KoQEVFbYwfsWAqHjlIB5BKP1GbuMxFhgLy9cV23cpbRbXiaa/?= =?us-ascii?Q?pbpLrWb/mK0Y3r3ZZuw6JWDz/ib3mIz3acQBimGvtENxxrpAd9W4FJ76B3vx?= =?us-ascii?Q?qA5gkAENUWssfzXWFPHyZcN4AEnM7JDcT0UcRUYSC6G1u6vAHdS/0q4uTKnH?= =?us-ascii?Q?vt5yICAO3kvpiGI/leQRpUqsNuNBpMcvGgzwg79vA6F9Wml91+V1EKgGh03M?= =?us-ascii?Q?k+H1bU7Xgu9EF3xUt9RTx3WpxSnxbzu3WSQqo5rftztsKaPoYJrMCiPPdWUq?= =?us-ascii?Q?svEHHHubPAls/5M1LPWjJrVqqFsHj5wdeWShyara9WjaEWzuE+wQBo3U3mLg?= =?us-ascii?Q?nAGXOlUV9wHfv/QENA+BZ0scGtkRB9tJ9GrxD8ce/d/rUcI6EHVcpISFD14t?= =?us-ascii?Q?6588EcAvhtt37Wgu6heuDi0ucVbNyEIBa3dOcyXNkgQZiGg6RlbnEdqmMGGq?= =?us-ascii?Q?L3NsAmYL7+461/LIj8lybM3hiFys/6kHi6McuMbjWznCu0ME41x4zqdIkUug?= =?us-ascii?Q?4pCiQiTA=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR1201MB0131;6:B72fkzC2LPToTAfUn9Fjkqvrf4Vh40aUlMBMg8dc?= =?us-ascii?Q?sz2PfSQjJnP9g6H1xZiMeNuMoIuRa4xCJzdAPJtxh3G4APLeyo92oCIhe2ZP?= =?us-ascii?Q?bGm6RTCpBbRQCK39oPsQ2DXfw+QTEOdEsMAroE4/2k5hQAeugn43DDPAWT9a?= =?us-ascii?Q?AJXjYe2Hf3nbQFvHbIqRWdlecy6PwyRoJ/0dv4U8s2PwCxK4Pi2/UkB1To+l?= =?us-ascii?Q?6aNDOSeXOUI6C6GioG56mKZKv+iybOFh4YNO4b7Lia0bZnu4GIS7n+NrvVr1?= =?us-ascii?Q?MUuIZEF2x61OirboVWo7POHznulNF93Pug0YX3Cyq5j/gUD0hvXsq3M0tCxz?= =?us-ascii?Q?Jl1b6gUdhOY7ye1qTVSG7WtBV3T2Poxy0jkCcUFiwuBda//QRgdOe2X6qNOq?= =?us-ascii?Q?FUf0mMVR9WGzynO7Q/ZpmEfCeV9CLnElhNGVMjcXHSgmMOz1rrHTWi9mB7kr?= =?us-ascii?Q?UjcIzDRmIP0THydGlVcxdWVWxoNaZ+/5Mip33nreRyn4GSQY4YBoWjjcbMvQ?= =?us-ascii?Q?qqEzpgMLp1J3RkNCI46qK/Pkrk3PstkioRzR7O/I6zPm1ySQ/SVC9VBjq+XH?= =?us-ascii?Q?1uHIp+6XkqeS2Pr8b9TLFPUzJNc8e5WE2HSh7o/NGxQ3L1X9SHIyKKIoZEru?= =?us-ascii?Q?fi35OnwvY7Xk6F/JZ2RCwaCfp1xVCotP7h0ytYpf3e9vZNpxt2O9yMUMK/US?= =?us-ascii?Q?Y4hfbJOWMUXzQUO3AbFh7FHp9WDUsPnVR7CCQ9qubkeLoSPCENHY0o9IE/R9?= =?us-ascii?Q?8jxiyDeJ3pQdXapp95e4jW/zy5H1YFeDu5vEfrINRjRm/bA7gJPj9f8iXmYf?= =?us-ascii?Q?fS3fqzpQ9f/VtCpoKbgWJmH7pFlnO0s62DjmKT+xAtf1dMAudrjE/dH/KtWQ?= =?us-ascii?Q?m+zkDTbk2m9yLPV26V6kFh8yM/kbZfurj1J5Btdsgyipw5QTSzHYc/ktjR/9?= =?us-ascii?Q?5xF41gX6AOYBURG6YQc4VGbZ2X+Mo3XsT+DEdv0I4serURA+NJ5vNAwceYbU?= =?us-ascii?Q?0RxCO4UIxWKEB6QrDnp13ts8?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0131;5:TKKxj4Nx3Bdhn1DQIWbmprR/4VqOSs0adY5h2EaG9yI7KmqficOvxhb3nz0p8B6p8wmM0cwPzaUFMJrohQdbrlsjTW9uA/MDqiVRLgIqgU/2MbvfX05Jl8+03MEmM6ApRI20tIN2z1ygOQ04n+mcI8+aa0iPRX0fxVOMkkUIxFc+eAuFrVykGNNXIEPBRdCh4p/53sWNaD+JURPbhm8zg8nmRPtWWM8HcLMe5tuVTRDEpmhwTSgCIIoDJvjYpj/cYvEdYnrn6LZr2Y/ApzQxGnob9ugk4ueSKUL3NvDRmSiJWIppElrSspnAipmNJZGMclSUtpI8j999YpWiouMlgOJcpjrQYvq9qNU1PKkWS4+2+PFAtVgilsmFOVmrDFLCJKjW7e3iYeMGict8NK5OmpjdxeSitrY3XP5hn5YM23XtWECFzdE/Ahv5fr8mcjeMcYFk40pkJ8oTeMwnFbvbVhd8AzM/R7SSuGqjOF3vittVnEvCzu1JLUpEcgFrk1Ap;24:6Q0QCRnE8nW/a5gNBNQdebPHoiq9Bs1hxGmAiPtNIWta2ul5cgCqZV4ByLYSNBWVM6WJjDAAgoTsU7gZuZI4XvaqCtGxeU9kNNCfB4lIb5M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0131;7:6fkXjf6kHRg1J3QI+lc2M2nXYN3MctHFESjPMrpJOLoOZwNnvg8a8E8qvHAjL3uC1pAJxuRV8dOMhr/yLgePlhBfAbV0IRgGsZmVVeqw0D/aHxXvwy9Kp/kb2fbW00+KeE4syvtQUPKaxlh22/7OW+9nJqSCN2B7PPYkHdENu/Sj0TF3EYs5XffgZb/Cjny62UCgq1g4t4iuacL5nx1rNnX65llTdJtOxWFJoJnwI0neuZXsEAHio7R+KH7EiIM6pfuNo8ZtcfjA1e5j6HLZBdgzAqbXnTtoa6CJ26CnSRzkdEUmQys+QKBhYrwVfjdbbHriCpX9aU+UR6Ssa+CxvoQVKYiwe3Wm8ZJ8LZ7bJ3fegS85HkZ2F6Z0QJddkdpSSOiQV1HJbDgEAqDcZCnkGl6SQgwGY94mqklkbmexFX8OL9XiTsRxLO+IpxdzmNKixZ549iBFv7/hqaZgvp6EnQH2lWRsH50KWvQ/D+iQoTn4SydepILWfAgPBoCa28UVPHFoSlyIsOnnWj+XhFRjPYJg3hicpw9wS7efr7ALtDqaBK1HG5k8Yv8Ng8tZt2zrDWs5+S2oxkOPPHKLggdsLLRD5rYGpzo0qOFkH13RRi6ZDrvFnHtgpqt+22VHD+Nx4D2hX0EffPudnED47cqdT0LBW18NtEY4elX+/+gkAET9LEhiY4/epVSb2Px1MiCGsZFpEhec89h4tH7k6Ub5AWvGyoJmf1uZftcA38NJqOsW0etfXNBgk2blHdX7/NHK3xdbdi5806PPx2UOk4G5I37gB8vikY4OzXTplkdyJsQ= X-Microsoft-Exchange-Diagnostics: 1;BN6PR1201MB0131;20:mp0yl2x4JGAVme+weMv9V6qLChApEmM38CmzhVcszlUK8fgjZQ/WFuE9Z/szBkuZeCFN02qwY6+BXvaYq96dSUNp/X6VufzB077pRUsiXs561d7M2+DwolkjScsb2Y//xNkzOZeVG5vTE3JOoMic7MJE9ZQP9B2Yq2kjzYHm26SV8UckPhuz+lN9U1ggMfqnCIHmDQrDdkhzFCLYNY/NFGbU1VgGsDVemorjGPhu2WxI8FE6ehLvXccETOeAAr7j X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 19:46:55.1001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yazen Ghannam The severity gives a hint as to how to handle the error. The notifier blocks can then use the severity to decide on an action. It's not necessary for machine_check_poll() to filter errors for the notifier chain, since each block will check its own set of conditions before handling an error. Also, there isn't any urgency for machine_check_poll() to make decisions based on severity like in do_machine_check(). If we can assume that a severity is set then we can use them in more notifier blocks. For example, the CEC block can check for a "KEEP" severity rather than checking bits in the status. This isn't possible now since the severity is not set except for "DEFFRRED/UCNA" errors with a valid address. Save the severity since we have it, and let the notifier blocks decide if they want to do anything. Signed-off-by: Yazen Ghannam --- Link: https://lkml.kernel.org/r/1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com v1->v2: * Expand commit message. arch/x86/kernel/cpu/mcheck/mce.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index b58b77808ce4..6dde0497efc7 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -673,7 +673,6 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b) { bool error_seen = false; struct mce m; - int severity; int i; this_cpu_inc(mce_poll_count); @@ -710,11 +709,7 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b) mce_read_aux(&m, i); - severity = mce_severity(&m, mca_cfg.tolerant, NULL, false); - - if (severity == MCE_DEFERRED_SEVERITY && mce_is_memory_error(&m)) - if (m.status & MCI_STATUS_ADDRV) - m.severity = severity; + m.severity = mce_severity(&m, mca_cfg.tolerant, NULL, false); /* * Don't get the IP here because it's unlikely to -- 2.7.4