From: Jaya Durga <rjdurga@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
rvarsha016@gmail.com, julia.lawall@lip6.fr,
binoy.jayan@linaro.org, arnd@arndb.de, louie.lu@hopebaytech.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Jaya Durga <rjdurga@gmail.com>, Jaya Durga <jayad@cdac.in>
Subject: [PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal
Date: Thu, 22 Jun 2017 15:42:35 +0530 [thread overview]
Message-ID: <1498126355-26540-1-git-send-email-rjdurga@gmail.com> (raw)
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR'
are not preferred.Consider using octal permissions '0644'.
Signed-off-by: Jaya Durga <jayad@cdac.in>
--6
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
*/
static int wifi_test;
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
module_param(wifi_test, int, 0644);
module_param(initmac, charp, 0644);
module_param(video_mode, int, 0644);
--
1.9.1
next reply other threads:[~2017-06-22 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 10:12 Jaya Durga [this message]
2017-06-23 17:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498126355-26540-1-git-send-email-rjdurga@gmail.com \
--to=rjdurga@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jayad@cdac.in \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=louie.lu@hopebaytech.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome