mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
To: Shuah Khan <shuah@kernel.org>
Cc: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Subject: [PATCH 3/3] selftests/intel_pstate: fix undefined reference when building
Date: Fri, 23 Jun 2017 12:37:26 +0200	[thread overview]
Message-ID: <1498214246-1244-4-git-send-email-marcin.nowakowski@imgtec.com> (raw)
In-Reply-To: <1498214246-1244-1-git-send-email-marcin.nowakowski@imgtec.com>

Currently the build fails with:

/tmp/ccmgtz8N.o: In function `main':
aperf.c:(.text+0x278): undefined reference to `sqrt'
collect2: error: ld returned 1 exit status

Replace LDFLAGS with LDLIBS to ensure proper ordering of arguments in
build rules.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
 tools/testing/selftests/intel_pstate/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/intel_pstate/Makefile b/tools/testing/selftests/intel_pstate/Makefile
index 19678e9..80fd0ba 100644
--- a/tools/testing/selftests/intel_pstate/Makefile
+++ b/tools/testing/selftests/intel_pstate/Makefile
@@ -1,5 +1,5 @@
 CFLAGS := $(CFLAGS) -Wall -D_GNU_SOURCE
-LDFLAGS := $(LDFLAGS) -lm
+LDLIBS := $(LDFLAGS) -lm
 
 TEST_GEN_FILES := msr aperf
 
-- 
2.7.4

  parent reply	other threads:[~2017-06-23 10:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 10:37 [PATCH 0/3] kselftest build errors Marcin Nowakowski
2017-06-23 10:37 ` [PATCH 1/3] selftests/{net,memfd}: fix undefined references to external libraries Marcin Nowakowski
2017-06-23 10:37 ` [PATCH 2/3] selftests/gpio: fix build error Marcin Nowakowski
2017-06-28  8:34   ` Fathi Boudra
2017-06-23 10:37 ` Marcin Nowakowski [this message]
2017-06-23 19:44 ` [PATCH 0/3] kselftest build errors Shuah Khan
2017-06-28  8:30   ` Fathi Boudra
2017-06-28 14:21     ` Shuah Khan
2017-06-29  8:37       ` Fathi Boudra
2017-07-12  9:30         ` Naresh Kamboju
2017-07-24 18:28           ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498214246-1244-4-git-send-email-marcin.nowakowski@imgtec.com \
    --to=marcin.nowakowski@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®