From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754588AbdFWOHd convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Jun 2017 10:07:33 -0400
Received: from mout.gmx.net ([212.227.17.22]:60194 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754035AbdFWOHc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Jun 2017 10:07:32 -0400
Message-ID: <1498226839.31539.13.camel@gmx.de>
Subject: Re: [patch-rt v2] rtmutex: Fix lock stealing logic
From: Mike Galbraith <efault@gmx.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rt-users <linux-rt-users@vger.kernel.org>
Date: Fri, 23 Jun 2017 16:07:19 +0200
In-Reply-To: <20170623093341.547ce155@gandalf.local.home>
References: <20170616105610.rbc6itylcrsla56l@linutronix.de>
         <1497805317.6229.3.camel@gmx.de> <1498203434.3988.5.camel@gmx.de>
         <20170623093341.547ce155@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
X-Provags-ID: V03:K0:jvur0RCwh13wYWE0C8wxIvQn/sfEGyIdwxTnTjDEpMi3WfeyYMx
 /s80gIeTB4okIImLATw4WC2AUF86anbNvTf2LZoeTR5ZVog5N9SCZy8S52lqLBHFr57YVbc
 j9YGXa3dj0rUPQoIAtNKiNmwQuSzEXUCS3qgLKIboA0oWk7psmnftFG0qjUIWxUay2N6CiT
 p6joP4LvFDRXEsP6WHRuA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:UcbDW9C65ek=:XsyioyVxMNw/cCKxYund8F
 LeD+yQO1HYBS5yjgdrq37wR4wMo+5kwLPRKCBMjFFy88sxYzhoPlKa6Icu1XYD4dklzyx3HIb
 HIGqopNcRz2El9yNHtp/NS0VDA10X1rvTUj6ctxGiu+VtzdVvBETLzYu+Aiomd7tkz30D34q1
 fAhwvwHhrjIGlM2H7VnbGfNt4IuAm/NXixfAQIVBtyMKzjcz/VywekhzOrJNW6G03wfh2jkoz
 WZmPHYLAp6PG0SJ2KXHiTD7f+U+rzhuqXZwXtVJWcQBC3qG1eexJK7PvCaxcXT1KHwPxF06WZ
 XTOQ3B9bBI1dZcj6OrAWfGZOetYsKVWt+9Fa6IKt9Rw7WblMWWGUMcN6YM9a9vI0yvX5MzzoI
 T/klQVMJL1ChWIqekmQt3hDLOSUTIdUabQW6Xae3KOFQVa4LmDwpvA6NwroGb9uIF5wKtRii9
 Izmm/vyeQXZ/QN/FAIa09ihymzCRGplXkzkA40NtcJZw1dI/dsPXB1Jspw1K8kDM5nFwC6dGT
 cAcHP4LCYRo+MG37c2HUOtHu7xCy0Y0oFbz5tHCqm5FXPm2brV8PsdZ9uFeQQw0JX00jwSKQA
 l2lCP6FwgXcwhtPv/l7Eo5TfChOCKfXLFWUrXgDh0+5SMQFh9V3boSA+mDgUaRoGbe/x6WwZn
 JSMFNmdBEsXn/tcsoJH9k87QHj2Uih4/JF3unmPa/SZ7XQs3puIOpq5pTFx0j7fBsLyGtwU3q
 qBU5OirlKQC9PYe4oKuhcB38dmhSL2ESRvq/IfV5ftmMFlDyoD6Rvj8p9UNulDWqJ3u1cazge
 UNIki+t
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-06-23 at 09:33 -0400, Steven Rostedt wrote:
>  				  struct task_struct *task,
> > @@ -886,20 +901,16 @@ static int __try_to_take_rt_mutex(struct
> >  	 */
> >  	if (waiter) {
> >  		/*
> > -		 * If waiter is not the highest priority waiter of
> > -		 * @lock, give up.
> > +		 * If waiter is not the highest priority waiter of @lock,
> > +		 * or its peer when lateral steal is allowed, give up.
> >  		 */
> > -		if (waiter != rt_mutex_top_waiter(lock)) {
> > -			/* XXX rt_mutex_waiter_less() ? */
> > +		if (!rt_mutex_steal(lock, waiter, mode))
> >  			return 0;
> > -		}
> > -
> >  		/*
> >  		 * We can acquire the lock. Remove the waiter from the
> >  		 * lock waiters tree.
> >  		 */
> >  		rt_mutex_dequeue(lock, waiter);
> > -
> 
> I liked that space.

I like minus signs in diffstat, that one was a freebee.  Maintainers
can revive it if they like, or I can post a V3 with it revived as well
as s/rt_mutex_steal/rt_mutex_claim.

	-Mike