From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbdF1SHM (ORCPT ); Wed, 28 Jun 2017 14:07:12 -0400 Received: from a2nlsmtp01-05.prod.iad2.secureserver.net ([198.71.225.49]:40692 "EHLO a2nlsmtp01-05.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdF1SHE (ORCPT ); Wed, 28 Jun 2017 14:07:04 -0400 x-originating-ip: 107.180.71.197 From: Long Li To: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Cc: Long Li Subject: [PATCH resend] cifs: Do not modify mid entry after submitting I/O in cifs_call_async Date: Wed, 28 Jun 2017 11:05:54 -0700 Message-Id: <1498673154-30879-1-git-send-email-longli@exchange.microsoft.com> X-Mailer: git-send-email 1.7.1 X-CMAE-Envelope: MS4wfMurDgNm1kdbH2adAi/ECNF/daBy8IEDvUyBRxcgtSeDBtp6V3rxGBJ0+2lnhmPmLYHctIz7W9432o+SUmGeEkFjyN85MkyeSV3sBkEMaJtIWc6xEAG7 JxJfl1DDwoq9munVKRZOiLqr8LjyV/wL8VnDNK4gOHZllI11Y8tMntXdIEz/AhM1aT5WfOeZ4igi67ILQBbjDwrAEuFzNBQlvLgXqWfLy1W1gU2esGwUg5b4 zKn8YyTxhuNaBQXC2/c2q1W5tOdhvDaw9DIohXnhuc1/ywQSD7vCP8uGaSK8EeBnsstwO5dKvAWRPA9+B4SxVa2AX0H3bGdngcqFAWQJypc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Long Li In cifs_call_async, server response may return as soon as I/O is submitted. Because mid entry is freed on the return path, do not modify it after I/O is submitted. Signed-off-by: Long Li --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 47a125e..ba62aaf 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst, spin_unlock(&GlobalMid_Lock); + cifs_save_when_sent(mid); cifs_in_send_inc(server); rc = smb_send_rqst(server, rqst, flags); cifs_in_send_dec(server); - cifs_save_when_sent(mid); if (rc < 0) { server->sequence_number -= 2; -- 2.7.4